summaryrefslogtreecommitdiff
path: root/syntax-checks.mk
diff options
context:
space:
mode:
authorStefano Lattarini <stefano.lattarini@gmail.com>2012-06-02 09:54:17 +0200
committerStefano Lattarini <stefano.lattarini@gmail.com>2012-06-02 09:54:17 +0200
commite92bd2e745cc8273654b51cc1c3712211e9b3def (patch)
tree8e3d352b0ae1cb6c66c7cf4a7951b3b70d73a6e3 /syntax-checks.mk
parent21da52c2d428168f06fecf1d7527dc5d1505633a (diff)
parent6476663785760c46e5ed81ccdede6449a3345ced (diff)
downloadautomake-e92bd2e745cc8273654b51cc1c3712211e9b3def.tar.gz
Merge branch 'maint'
* maint: news: document deprecation of configure.in news: put planned backward compatibilities early sync: update files from upstream with "make fetch" maint: deprecate 'configure.in' as autoconf input maint: post-release minor version bump release: stable release 1.12.1 copyright: update copyright years in a couple of files tests: avoid spurious failures with Solaris 9 cscope program maintcheck: fix a spurious failure perf: beginning of a performance testsuite aclocal: declare function prototypes, do not use '&' in function calls news: support for configure.in will be dropped in future automake versions tests: fix botched heading comments in 'lex-clean-cxx.sh' [ng] maintcheck: some tweaks and fixlets help: fix a typo in the list of warning categories maint: version bump after beta release release: beta release 1.12.0b (will become 1.12.1) release: remove overly picky check Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Diffstat (limited to 'syntax-checks.mk')
-rw-r--r--syntax-checks.mk12
1 files changed, 6 insertions, 6 deletions
diff --git a/syntax-checks.mk b/syntax-checks.mk
index f3886314a..235961295 100644
--- a/syntax-checks.mk
+++ b/syntax-checks.mk
@@ -94,10 +94,10 @@ sc_perl_syntax:
@perllibdir="./lib$(PATH_SEPARATOR)$(srcdir)/lib" $(PERL) -c -w automake
@perllibdir="./lib$(PATH_SEPARATOR)$(srcdir)/lib" $(PERL) -c -w aclocal
-## expect no instances of '${...}'. However, $${...} is ok, since that
+## Expect no instances of '${...}'. However, $${...} is ok, since that
## is a shell construct, not a Makefile construct.
sc_no_brace_variable_expansions:
- @if grep -F '$${' $(ams) | grep -F -v '$$$$'; then \
+ @if grep -v '^ *#' $(ams) | grep -F '$${' | grep -F -v '$$$$'; then \
echo "Found too many uses of '\$${' in the lines above." 1>&2; \
exit 1; \
else :; fi
@@ -271,19 +271,19 @@ $(sc_tests_plain_check_rules): sc_tests_plain_% :
## Tests should only use END and EOF for here documents
## (so that the next test is effective).
sc_tests_here_document_format:
- @if grep '<<' $(xtests) | grep -Ev '\b(END|EOF)\b|\bstd::cout <<'; then \
+ @if grep '<<' $(xtests) | grep -Ev '\b(END|EOF)\b|\bcout <<'; then \
echo 'Use here documents with "END" and "EOF" only, for greppability.' 1>&2; \
exit 1; \
fi
## Tests should never call exit directly, but use Exit.
## This is so that the exit status is transported correctly across the 0 trap.
-## Ignore comments, testsuite self tests, and one perl line in ext2.sh.
+## Ignore comments and our testsuite's own self tests.
sc_tests_Exit_not_exit:
@found=false; for file in $(xtests); do \
case $$file in */self-check-*) continue;; esac; \
- res=`sed -n -e '/^#/d; /^\$$PERL/d' -e '/<<.*END/,/^END/b' \
- -e '/<<.*EOF/,/^EOF/b' -e '/exit [$$0-9]/p' $$file`; \
+ res=`sed -n -e '/^#/d' -e '/<<.*END/,/^END/b' -e '/<<.*EOF/,/^EOF/b' \
+ -e '/exit [$$0-9]/p' $$file`; \
if test -n "$$res"; then \
echo "$$file:$$res"; \
found=true; \