summaryrefslogtreecommitdiff
path: root/maintainer
diff options
context:
space:
mode:
authorStefano Lattarini <stefano.lattarini@gmail.com>2013-05-23 20:12:17 +0200
committerStefano Lattarini <stefano.lattarini@gmail.com>2013-05-23 20:12:17 +0200
commit86e45fe19374b87b6a9adaeb3ecc93e51c7d54a7 (patch)
treee692ec2434926772c17accc76e7581f972b8e976 /maintainer
parent8d7108702485dca61841a642202b892f8038e15c (diff)
parent3ce4015f1bfff6277840502b080cfd2b22e05870 (diff)
downloadautomake-86e45fe19374b87b6a9adaeb3ecc93e51c7d54a7.tar.gz
Merge branch 'micro' into maint
* micro: tests: avoid '$MAKE' redirections, use 'run_make' instead tests: avoid use of redirected 'run_make' invocations lint: warn against redirected 'run_make' invocations comments: next GNU make release 4.0, not 3.83 tests: fix a potential spurious failure due to global config.site HACKING: it's OK to do testsuite refactoring in a micro version Signed-off-by: Stefano Lattarini <stefano.lattarini@gmail.com>
Diffstat (limited to 'maintainer')
-rw-r--r--maintainer/syntax-checks.mk11
1 files changed, 11 insertions, 0 deletions
diff --git a/maintainer/syntax-checks.mk b/maintainer/syntax-checks.mk
index e849d1ba6..d29ce3047 100644
--- a/maintainer/syntax-checks.mk
+++ b/maintainer/syntax-checks.mk
@@ -62,6 +62,7 @@ sc_tests_no_source_defs \
sc_tests_obsolete_variables \
sc_tests_here_document_format \
sc_tests_command_subst \
+sc_tests_no_run_make_redirect \
sc_tests_exit_not_Exit \
sc_tests_automake_fails \
sc_tests_required_after_defs \
@@ -346,6 +347,16 @@ sc_tests_no_source_defs:
exit 1; \
fi
+## Invocation of 'run_make' should not have output redirections.
+sc_tests_no_run_make_redirect:
+ @if grep -Pzo '.*(\$$MAKE|\brun_make)\b(.*(\\\n))*.*>.*' $(xtests); \
+ then \
+ echo 'Do not redirect stdout/stderr in "run_make" or "$$MAKE"' \
+ 'invocations,' >&2; \
+ echo 'use "run_make {-E|-O|-M}" instead.' >&2; \
+ exit 1; \
+ fi
+
## Use AUTOMAKE_fails when appropriate
sc_tests_automake_fails:
@if grep -v '^#' $(xtests) | grep '\$$AUTOMAKE.*&&.*exit'; then \