diff options
author | christian mueller <christian.ei.mueller@bmw.de> | 2012-05-03 14:40:20 +0200 |
---|---|---|
committer | christian mueller <christian.ei.mueller@bmw.de> | 2012-05-24 13:40:22 +0200 |
commit | 6681a98594680fe6ab15abeeb0ea915c44d7ad6a (patch) | |
tree | b1dbb1d46a5019963d4061fb4463032ef4deb09d /AudioManagerDaemon/src/CAmDbusWrapper.cpp | |
parent | bfafb8c4ded216a2cae6e376e69c9bc2dca117e6 (diff) | |
download | audiomanager-6681a98594680fe6ab15abeeb0ea915c44d7ad6a.tar.gz |
* [GAM-74] resolving issues found by coverity scan
Signed-off-by: christian mueller <christian.ei.mueller@bmw.de>
Diffstat (limited to 'AudioManagerDaemon/src/CAmDbusWrapper.cpp')
-rw-r--r-- | AudioManagerDaemon/src/CAmDbusWrapper.cpp | 17 |
1 files changed, 13 insertions, 4 deletions
diff --git a/AudioManagerDaemon/src/CAmDbusWrapper.cpp b/AudioManagerDaemon/src/CAmDbusWrapper.cpp index 592d58e..76290ee 100644 --- a/AudioManagerDaemon/src/CAmDbusWrapper.cpp +++ b/AudioManagerDaemon/src/CAmDbusWrapper.cpp @@ -26,6 +26,7 @@ #include <string> #include <cassert> #include <cstdlib> +#include <stdexcept> #include "shared/CAmDltWrapper.h" #include "shared/CAmSocketHandler.h" @@ -104,8 +105,8 @@ CAmDbusWrapper::CAmDbusWrapper(CAmSocketHandler* socketHandler, DBusBusType type } if (DBUS_REQUEST_NAME_REPLY_PRIMARY_OWNER != ret) { - logError("DBusWrapper::DBusWrapper Wrapper is not the Primary Owner ! Another instance already running?", ret); - exit(1); + logError("DBusWrapper::DBusWrapper Wrapper is not the Primary Owner ! Another instance already running?"); + throw std::runtime_error("DBusWrapper::DBusWrapper Wrapper is not the Primary Owner ! Another instance already running?"); } } @@ -260,9 +261,15 @@ void CAmDbusWrapper::removeWatchDelegate(DBusWatch *watch, void *userData) std::map<DBusWatch*, sh_pollHandle_t>::iterator iterator = mMapHandleWatch.begin(); iterator = mMapHandleWatch.find(watch); if (iterator != mMapHandleWatch.end()) + { mpSocketHandler->removeFDPoll(iterator->second); - logInfo("DBusWrapper::removeWatch removed watch with handle", iterator->second); - mMapHandleWatch.erase(iterator); + logInfo("DBusWrapper::removeWatch removed watch with handle", iterator->second); + mMapHandleWatch.erase(iterator); + } + else + { + logError("DBusWrapper::removeWatch could not find handle !"); + } } void CAmDbusWrapper::toogleWatch(DBusWatch *watch, void *userData) @@ -302,6 +309,8 @@ dbus_bool_t CAmDbusWrapper::addTimeout(DBusTimeout *timeout, void* userData) dbus_bool_t CAmDbusWrapper::addTimeoutDelegate(DBusTimeout *timeout, void* userData) { + (void)userData; + if (!dbus_timeout_get_enabled(timeout)) return (false); |