summaryrefslogtreecommitdiff
path: root/atspi
Commit message (Collapse)AuthorAgeFilesLines
...
* Fix meson deprecation in call to pkgconfig.generate()Federico Mena Quintero2022-05-241-1/+1
|
* Merge branch 'va_end' into 'master'Mike Gorse2022-03-271-2/+5
|\ | | | | | | | | _atspi_dbus_call_partial: add missing va_end call See merge request GNOME/at-spi2-core!73
| * Move va_end from _atspi_dbus_call_partial_va to _atspi_dbus_call_partialSamuel Thibault2022-03-241-2/+5
| | | | | | | | | | The C standard says that va_end has to be called in the same function as va_start.
* | listeners: Fix crash on NULL listenerSamuel Thibault2022-03-131-7/+15
|/ | | | | We shouldn't call _atspi_device_listener_get_path before checking that listener is not NULL.
* Reorder g_free around g_slist_removeFederico Mena Quintero2021-12-141-1/+1
|
* _atspi_dbus_handle_event(): assert that the event source is not NULL before ↵Federico Mena Quintero2021-12-141-0/+2
| | | | | | | | | | | | | | processing the event Once we demarshal, the event.source should not be NULL. It can come from the message path if it is *not* being a ScreenReader event, or from a variant argument. Fixes static-scan warnings of this sort: ../../../atspi/atspi-event-listener.c:248:9: warning: Access to field 'accessible_parent' results in a dereference of a null pointer (loaded from field 'source') [core.NullDereference] if (event->source->accessible_parent) ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* _atspi_dbus_handle_event(): return early if the category or interface name ↵Federico Mena Quintero2021-12-141-0/+7
| | | | | | | | | | | is NULL I don't know why the interface would be NULL, but dbus_message_get_interface() can return that. We return DBUS_HANDLER_RESULT_NOT_YET_HANDLED in the same way as the other error case, but note that the caller of this function ignores the return value.
* Reorder g_free around g_slist_removeFederico Mena Quintero2021-12-141-1/+1
| | | | To avoid using a freed pointer. It's harmless, but static-scan complains.
* spi_display_name() - make conditional on HAVE_X11Federico Mena Quintero2021-12-131-37/+37
| | | | | This function is only called by get_accessibility_bus_address_x11(), which is already conditional on HAVE_X11.
* Fix function prototypeFederico Mena Quintero2021-11-231-1/+1
| | | | | device_remove_datum already implicitly casts its cb to a AtspiDeviceListenerSimpleCB, which takes a const *event.
* AtspiDevice key grab fixesMike Gorse2021-05-123-8/+81
|
* Fix double free when removing event listenersMike Gorse2021-04-211-1/+4
| | | | Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/35
* AtspiDeviceListenerCB: remove const from event prototypeMike Gorse2021-02-232-2/+3
| | | | | | | | The parameter is marked with (transfer full), and the code expects the caller to free the event, so adjust the prototype to clarify the expected behavior. Also fix a related memory leak in atspi-device-legacy.c. Fixes #31
* Remove debug printMike Gorse2021-02-221-1/+0
|
* atspi_accessible_get_(name|description): fix memory leakMike Gorse2021-02-221-0/+6
| | | | This is likely what the backed-out part of !53 was trying to do.
* Fix an invalid free introduced in 2.39.90, along with some warningsMike Gorse2021-02-223-7/+7
| | | | Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/30
* Fix memory leaksBartlomiej Grzelewski2021-02-123-1/+46
| | | | | | | | | | | * Release memory before pointer overwrite. * Reduce memory leaks reported in ref_accessible. * Remove leak connected with atspi_state_type_get_type. * Remove memory leak in atspi_event_listener_register_from_callback_full. * Reduce memory leaks reported on program exit. Change-Id: Ifde65dd44643f2e58442cf70809703f979436e09
* Device fixesMike Gorse2021-01-273-30/+331
|
* Fix build with X11 dep disabledMichael Catanzaro2021-01-111-8/+8
|
* Add device APIMike Gorse2021-01-119-2/+1368
| | | | | | | | | | | This is intended to replace the registry-based method for capturing keystrokes. It is needed because gtk 4 no longer sends key notifications in a way that atk-bridge can process them. Unlike the original API, key grabs are separated from key notifications. Clients wishing to consume keystrokes must proactively register a grab for the given key. Currently, there is a backend for X11 and an unfinished legacy back end using the old registry-based method. Hopefully, there will be a mutter/wayland back end in the future, but we need to define a protocol there first.
* misc: unref bus at the end of cleanupShinwoo Kim2020-10-191-8/+9
| | | | | | | | The g_object_run_dispose needs bus as below. g_object_run_dispose > atspi_application_dispose > _atspi_bus So close, unref and set bus to NULL after using bus is done.
* Minor code clean-upMike Gorse2020-09-041-4/+5
|
* Fix handling of event listener removals during an event callbackMike Gorse2020-09-021-2/+29
| | | | | | We should not modify event_listeners while we are iterating through it. Otherwise, we may crash. If an event listener is removed from within an event callback, then defer the removal until the callback has ended.
* _atspi_dbus_set_interfaces: Fix memory leak when called with invalid signatureMike Gorse2020-08-241-1/+1
| | | | Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/24
* Fix a compiler warningMike Gorse2020-08-191-1/+1
|
* Merge branch 'patch-1' into 'master'Mike Gorse2020-08-101-1/+1
|\ | | | | | | | | Keep indentation See merge request GNOME/at-spi2-core!47
| * Keep indentationShinwoo Kim2020-08-101-1/+1
| |
* | Fix possible memory leakMike Gorse2020-08-101-0/+1
|/ | | | Thanks to Shimwoo Kim for spotting.
* constants: Fix typos in two _COUNT constantsColomban Wendling2020-08-051-2/+2
|
* atspi_accessible_set_cache_mask: relax assertMike Gorse2020-06-241-1/+1
| | | | | | | | | | | | | | | | Atspi_accessible_set_cache_mask checks that it is being passed an application's root accessible, and this sometimes fails and generates a warning similar to the following, even when orca passes what it sees as the application's root accessible: (orca:18809): dbind-CRITICAL **: 09:27:25.951: atspi_accessible_set_cache_mask: assertion 'accessible == accessible->parent.app->root' failed I suspect that this is caused by atk-bridge being initialized and caching the root accessible and atk_get_root() is subsequently redefined, in the case of an application that loads more than one atk implementor, such as Firefox. This is indicative of a problem that should be fixed elsewhere--possibly gtk+ and/or firefox shouldn't override atk_get_root if it already has an implementation--but warning and failing here isn't helpful.
* Fix use after free when an event listener is destroyedMike Gorse2020-06-161-6/+4
| | | | | | Properly remove event listeners from the list when they are deregistered. Fixes a crash that can happen when orca exits. Similar issue to https://gitlab.gnome.org/GNOME/at-spi2-core/issues/22
* Fix documentation for the new mode_changed signalMike Gorse2020-06-111-0/+1
|
* Merge branch 'pkgconfig-fix' into 'master'Mike Gorse2020-06-111-1/+1
|\ | | | | | | | | meson: De-duplicate deps of 'Requires' in pkgconfig file See merge request GNOME/at-spi2-core!28
| * meson: De-duplicate deps of 'Requires' in pkgconfig fileSoapux2020-05-191-1/+1
| | | | | | | | | | | | Fix my mistake of listing dependencies in 'requires' as a string instead of as pkgconfig dependencies. It was causing duplicates in 'Requires.private'.
* | Fix use-after-free when a device listener is destroyedColomban Wendling2020-06-111-1/+3
| | | | | | | | Fixes #22.
* | Fix mode-changed signal registrationMike Gorse2020-06-091-1/+1
| | | | | | | | https://gitlab.gnome.org/GNOME/orca/issues/36
* | Add mode-changed signalMike Gorse2020-06-074-3/+37
| | | | | | | | | | | | Add a signal to allow a screen reader to indicate that its mode has changed. https://gitlab.gnome.org/GNOME/orca/issues/36
* | Use the event name when sending screen reader events over dbusMike Gorse2020-05-274-32/+37
|/ | | | | | | | | For screen reader events, look at the name of the signal and convert it, rather than hard-coding "RegionChanged." This is necessary to allow screen_reader_signal_watcher to process signals that will be added in the future. https://gitlab.gnome.org/GNOME/orca/issues/36
* Documentation fixMike Gorse2020-02-161-1/+0
|
* Add ATSPI_ROLE_MARK and ATSPI_ROLE_SUGGESTIONJoanmarie Diggs2020-01-161-1/+15
| | | | | | These roles are needed to improve the accessibility of rich text editors and other collaborative tools. The new roles parallel what was added to IAccessible2 in Windows.
* Fix source reproducibilityJoshua Watt2019-11-201-1/+1
| | | | | | | | | The generated enum type files can be included in source packages meant for debugging, and thus need to be reproducible. Replace the absolute include of the header with the basename. This is sufficient because the target include files are always in the include path anyway. Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
* Fix use after free when freeing an eventMike Gorse2019-09-041-1/+1
|
* Clarify atspi_editable_text_insert_text documentationMike Gorse2019-08-281-2/+2
| | | | | | | Clarify that the length parameter expects a count of bytes. This matches the corresponding atk documentation. Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/9
* Relicense as LGPL 2.1Mike Gorse2019-08-2859-230/+230
| | | | Fixes https://gitlab.gnome.org/GNOME/at-spi2-core/issues/2
* Fix outdated FSF addressMike Gorse2019-08-2757-114/+114
|
* Merge branch 'early_quit_warn' into 'master'Mike Gorse2019-08-261-2/+3
|\ | | | | | | | | misc: Do not warn on no reply from pending get_items call See merge request GNOME/at-spi2-core!22
| * misc: Do not warn on no reply from pending get_items callSamuel Thibault2019-08-251-2/+3
| | | | | | | | | | | | | | | | Like DBUS_ERROR_SERVICE_UNKNOWN, this may happen in normal use. For instance, during the at-spi2-atk testsuite, in the atk_test_accessible_set_cache_mask testcase, we may make the application quit before get_items gets to be replied to.
* | cleanup: Avoid disposing NULLSamuel Thibault2019-08-251-1/+2
| | | | | | | | | | | | In case atspi_application_dispose was previously called for an application, the app field of its root will be NULL. In such a case cleanup should not try to dispose it.
* | atspi_accessible_dispose: Avoid unreferencing NULLSamuel Thibault2019-08-251-1/+8
|/ | | | | | | | The children array may contain NULL entries, when the children have not all been inspected yet for instance. In such a case atspi_accessible_dispose's call to g_ptr_array_free would warn out when freeing array items with g_object_unref. We should thus check for NULL to avoid such warning.
* Support mutter remote desktop interface for key/mouse eventsMike Gorse2019-08-056-0/+488
| | | | | | | | | | | | | | Mutter now has a remote desktop interface with methods to synthesize keyboard and mouse events. This functionality has not been available through AT-SPI on wayland since it uses X-specific functions. Also add atspi_set_reference_window. Probably a work in progress; doesn't appear to be behaving as intended. Also requires that introspection be enabled on gnome-shell. Ie, gsettings set org.gnome.shell introspect true https://bugzilla.gnome.org/show_bug.cgi?id=709999 https://gitlab.gnome.org/GNOME/at-spi2-core/issues/14
View Lorry Controller Status