diff options
author | Abhijeet Kasurde <akasurde@redhat.com> | 2021-06-14 15:34:19 +0530 |
---|---|---|
committer | GitHub <noreply@github.com> | 2021-06-14 05:04:19 -0500 |
commit | 4acad228f081912025f44bcca83eedb69f107a6d (patch) | |
tree | 4c41bde4133f11cef8b2edcf0e96f3f0dee15ac7 /test/integration/targets | |
parent | 8b17e5b9229ffaecfe10a4881bc3f87dd2c184e1 (diff) | |
download | ansible-4acad228f081912025f44bcca83eedb69f107a6d.tar.gz |
[bp-2.9] firewalld: Ensure idempotency (#74992)
Fixes: https://github.com/ansible-collections/ansible.posix/issues/179
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
Diffstat (limited to 'test/integration/targets')
-rw-r--r-- | test/integration/targets/firewalld/tasks/port_test_cases.yml | 71 | ||||
-rw-r--r-- | test/integration/targets/firewalld/tasks/run_all_tests.yml | 18 |
2 files changed, 58 insertions, 31 deletions
diff --git a/test/integration/targets/firewalld/tasks/port_test_cases.yml b/test/integration/targets/firewalld/tasks/port_test_cases.yml index 5891e7520e..2beb8ca2c7 100644 --- a/test/integration/targets/firewalld/tasks/port_test_cases.yml +++ b/test/integration/targets/firewalld/tasks/port_test_cases.yml @@ -1,20 +1,63 @@ # Test playbook for the firewalld module - port operations # (c) 2017, Adam Miller <admiller@redhat.com> +# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) -# This file is part of Ansible -# -# Ansible is free software: you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation, either version 3 of the License, or -# (at your option) any later version. -# -# Ansible is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Ansible. If not, see <http://www.gnu.org/licenses/>. +- name: firewalld port range test permanent enabled + firewalld: + port: 5500-6950/tcp + permanent: true + state: enabled + register: result + +- name: assert firewalld port range test permanent enabled worked + assert: + that: + - result is changed + +- name: firewalld port range test permanent enabled rerun (verify not changed) + firewalld: + port: 5500-6950/tcp + permanent: true + state: enabled + register: result + +- name: assert firewalld port range test permanent enabled rerun worked (verify not changed) + assert: + that: + - result is not changed + +- name: firewalld port test permanent enabled + firewalld: + port: 6900/tcp + permanent: true + state: enabled + register: result + +- name: assert firewalld port test permanent enabled worked + assert: + that: + - result is changed + +- name: firewalld port test permanent enabled + firewalld: + port: 6900/tcp + permanent: true + state: enabled + register: result + +- name: assert firewalld port test permanent enabled worked + assert: + that: + - result is not changed + +- name: firewalld port test disabled + firewalld: + port: "{{ item }}" + permanent: true + state: disabled + loop: + - 6900/tcp + - 5500-6950/tcp - name: firewalld port test permanent enabled firewalld: diff --git a/test/integration/targets/firewalld/tasks/run_all_tests.yml b/test/integration/targets/firewalld/tasks/run_all_tests.yml index d463ef206f..822a2b87b7 100644 --- a/test/integration/targets/firewalld/tasks/run_all_tests.yml +++ b/test/integration/targets/firewalld/tasks/run_all_tests.yml @@ -1,20 +1,6 @@ # Test playbook for the firewalld module # (c) 2017, Adam Miller <admiller@redhat.com> - -# This file is part of Ansible -# -# Ansible is free software: you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation, either version 3 of the License, or -# (at your option) any later version. -# -# Ansible is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with Ansible. If not, see <http://www.gnu.org/licenses/>. +# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) - name: Ensure /run/firewalld exists file: @@ -28,8 +14,6 @@ # firewalld port operation test cases - include_tasks: port_test_cases.yml - # Skipping on CentOS 8 due to https://github.com/ansible/ansible/issues/64750 - when: not (ansible_facts.distribution == "CentOS" and ansible_distribution_major_version is version('8', '==')) # firewalld source operation test cases - import_tasks: source_test_cases.yml |