diff options
| author | Matt Martz <matt@sivel.net> | 2017-11-13 10:51:18 -0600 |
|---|---|---|
| committer | ansibot <ansibot@users.noreply.github.com> | 2017-11-13 11:51:18 -0500 |
| commit | 99d4f5bab4d334c0457a0cc6635f3104ca672834 (patch) | |
| tree | fc9525a0fe6df89b03e629eeb0fa2c216dbfe266 /lib/ansible/playbook/role/__init__.py | |
| parent | 464ded80f563483327208313e6bc78ce2cff2c4f (diff) | |
| download | ansible-99d4f5bab4d334c0457a0cc6635f3104ca672834.tar.gz | |
Remove uses of assert in production code (#32079)
* Remove uses of assert in production code
* Fix assertion
* Add code smell test for assertions, currently limited to lib/ansible
* Fix assertion
* Add docs for no-assert
* Remove new assert from enos
* Fix assert in module_utils.connection
Diffstat (limited to 'lib/ansible/playbook/role/__init__.py')
| -rw-r--r-- | lib/ansible/playbook/role/__init__.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/ansible/playbook/role/__init__.py b/lib/ansible/playbook/role/__init__.py index c9106e90d8..90d6abb14f 100644 --- a/lib/ansible/playbook/role/__init__.py +++ b/lib/ansible/playbook/role/__init__.py @@ -22,7 +22,7 @@ __metaclass__ = type import collections import os -from ansible.errors import AnsibleError, AnsibleParserError +from ansible.errors import AnsibleError, AnsibleParserError, AnsibleAssertionError from ansible.module_utils.six import iteritems, binary_type, text_type from ansible.playbook.attribute import FieldAttribute from ansible.playbook.base import Base @@ -293,7 +293,8 @@ class Role(Base, Become, Conditional, Taggable): def add_parent(self, parent_role): ''' adds a role to the list of this roles parents ''' - assert isinstance(parent_role, Role) + if not isinstance(parent_role, Role): + raise AnsibleAssertionError() if parent_role not in self._parents: self._parents.append(parent_role) |