diff options
| author | Matt Martz <matt@sivel.net> | 2018-10-12 10:43:09 -0500 |
|---|---|---|
| committer | Toshio Kuratomi <a.badger@gmail.com> | 2018-10-12 10:38:38 -0700 |
| commit | 30c1a1933ed31d1f40bf66fc5fb01bcb61e31845 (patch) | |
| tree | 4a9e22419aa466c314676da3021355753193d214 /lib/ansible/playbook/play.py | |
| parent | dcc37b6eb910e1414580aadc5e7b8504ec24dc35 (diff) | |
| download | ansible-30c1a1933ed31d1f40bf66fc5fb01bcb61e31845.tar.gz | |
[stable-2.7] Do not use mutable defaults in FieldAttribute, instead allow supplying a callable for defaults of mutable types. Fixes #46824 (#46833).
(cherry picked from commit a06a5ded617fceba93dd8e7f4dc826f72a9c2c1d)
Co-authored-by: Matt Martz <matt@sivel.net>
Diffstat (limited to 'lib/ansible/playbook/play.py')
| -rw-r--r-- | lib/ansible/playbook/play.py | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/lib/ansible/playbook/play.py b/lib/ansible/playbook/play.py index 9d519a1b95..370a77f4df 100644 --- a/lib/ansible/playbook/play.py +++ b/lib/ansible/playbook/play.py @@ -63,22 +63,22 @@ class Play(Base, Taggable, Become): _gather_timeout = FieldAttribute(isa='int', default=None, always_post_validate=True) # Variable Attributes - _vars_files = FieldAttribute(isa='list', default=[], priority=99) - _vars_prompt = FieldAttribute(isa='list', default=[], always_post_validate=False) + _vars_files = FieldAttribute(isa='list', default=list, priority=99) + _vars_prompt = FieldAttribute(isa='list', default=list, always_post_validate=False) # Role Attributes - _roles = FieldAttribute(isa='list', default=[], priority=90) + _roles = FieldAttribute(isa='list', default=list, priority=90) # Block (Task) Lists Attributes - _handlers = FieldAttribute(isa='list', default=[]) - _pre_tasks = FieldAttribute(isa='list', default=[]) - _post_tasks = FieldAttribute(isa='list', default=[]) - _tasks = FieldAttribute(isa='list', default=[]) + _handlers = FieldAttribute(isa='list', default=list) + _pre_tasks = FieldAttribute(isa='list', default=list) + _post_tasks = FieldAttribute(isa='list', default=list) + _tasks = FieldAttribute(isa='list', default=list) # Flag/Setting Attributes _force_handlers = FieldAttribute(isa='bool', always_post_validate=True) _max_fail_percentage = FieldAttribute(isa='percent', always_post_validate=True) - _serial = FieldAttribute(isa='list', default=[], always_post_validate=True) + _serial = FieldAttribute(isa='list', default=list, always_post_validate=True) _strategy = FieldAttribute(isa='string', default=C.DEFAULT_STRATEGY, always_post_validate=True) _order = FieldAttribute(isa='string', always_post_validate=True) |