summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRick Elrod <rick@elrod.me>2021-05-21 13:13:04 -0500
committerGitHub <noreply@github.com>2021-05-21 13:13:04 -0500
commit4f0e584ea4f905ca2101ac0525ea90398f35d256 (patch)
tree7667805b7367a8f2eb631ad824afdf285de0ac48
parentd1db5366a25d7d53541da5ec322105170585c3c1 (diff)
downloadansible-4f0e584ea4f905ca2101ac0525ea90398f35d256.tar.gz
[2.9] [tests] add websocket-client constraint, python 2 (#74750)
Change: - websocket-client >= 1 requires python 3, so add constraint for python 2. Test Plan: - ci_complete Signed-off-by: Rick Elrod <rick@elrod.me> * avoid a mysql_variables check on rhel 8 Signed-off-by: Rick Elrod <rick@elrod.me>
-rw-r--r--changelogs/fragments/ansible-test-constraints-websocket-client.yml2
-rw-r--r--test/integration/targets/mysql_variables/tasks/main.yml8
-rw-r--r--test/lib/ansible_test/_data/requirements/constraints.txt1
3 files changed, 11 insertions, 0 deletions
diff --git a/changelogs/fragments/ansible-test-constraints-websocket-client.yml b/changelogs/fragments/ansible-test-constraints-websocket-client.yml
new file mode 100644
index 0000000000..5a598e5c60
--- /dev/null
+++ b/changelogs/fragments/ansible-test-constraints-websocket-client.yml
@@ -0,0 +1,2 @@
+minor_changes:
+ - ansible-test - cap websocket-client on python 2 because 1.0.0 stops supporting it.
diff --git a/test/integration/targets/mysql_variables/tasks/main.yml b/test/integration/targets/mysql_variables/tasks/main.yml
index 1b3fd3f4c4..3508c05a8c 100644
--- a/test/integration/targets/mysql_variables/tasks/main.yml
+++ b/test/integration/targets/mysql_variables/tasks/main.yml
@@ -133,6 +133,10 @@
# ============================================================
# Verify mysql_variable fails when setting an incorrect value (out of range)
#
+# This test started failing on RHEL 8 randomly, even though no packages saw an
+# update and nothing else seems to have changed. Several of us were unable to
+# pinpoint the root cause of the issue, so for now we just skip RHEL 8 for this
+# particular check.
- name: set mysql variable value to a number out of range
mysql_variables:
variable: max_tmp_tables
@@ -140,8 +144,12 @@
login_unix_socket: '{{ mysql_socket }}'
register: result
ignore_errors: true
+ when:
+ - not (ansible_distribution == 'RedHat' and ansible_distribution_major_version is version('8', '=='))
- include: assert_fail_msg.yml output={{result}} msg='Truncated incorrect'
+ when:
+ - not (ansible_distribution == 'RedHat' and ansible_distribution_major_version is version('8', '=='))
# ============================================================
# Verify mysql_variable fails when setting an incorrect value (incorrect type)
diff --git a/test/lib/ansible_test/_data/requirements/constraints.txt b/test/lib/ansible_test/_data/requirements/constraints.txt
index 12edeccae7..a277e27b86 100644
--- a/test/lib/ansible_test/_data/requirements/constraints.txt
+++ b/test/lib/ansible_test/_data/requirements/constraints.txt
@@ -42,6 +42,7 @@ MarkupSafe < 2.0.0 ; python_version < '3.6' # MarkupSafe >= 2.0.0. requires Pyth
botocore >= 1.10.0 # adds support for the following AWS services: secretsmanager, fms, and acm-pca
setuptools < 45 ; python_version <= '2.7' # setuptools 45 and later require python 3.5 or later
cffi != 1.14.4 # Fails on systems with older gcc. Should be fixed in the next release. https://foss.heptapod.net/pypy/cffi/-/issues/480
+websocket-client < 1 ; python_version < '3' # version 1.0.0 drops support for python 2
# freeze pylint and its requirements for consistent test results
astroid == 2.3.3