summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFelix Fontein <felix@fontein.de>2021-04-03 18:26:33 +0200
committerGitHub <noreply@github.com>2021-04-03 11:26:33 -0500
commitd523263945da457f7c84ea79bd4840c8891c90d7 (patch)
treee2e15085eddbd909420beed3671321b6eab7f4dc
parent6b8c35cd41633fb54966b343bef0791f1cc0e8a0 (diff)
downloadansible-d523263945da457f7c84ea79bd4840c8891c90d7.tar.gz
Backport of https://github.com/ansible-collections/community.general/pull/2018. (#73912)
-rw-r--r--changelogs/fragments/community.general-2018-missing-no_log-again.yml2
-rw-r--r--lib/ansible/modules/storage/netapp/_na_cdot_user.py2
2 files changed, 3 insertions, 1 deletions
diff --git a/changelogs/fragments/community.general-2018-missing-no_log-again.yml b/changelogs/fragments/community.general-2018-missing-no_log-again.yml
new file mode 100644
index 0000000000..7410b7643e
--- /dev/null
+++ b/changelogs/fragments/community.general-2018-missing-no_log-again.yml
@@ -0,0 +1,2 @@
+security_fixes:
+- "na_cdot_user - mark the ``set_password`` parameter as ``no_log`` to avoid leakage of secrets (https://github.com/ansible-collections/community.general/pull/2018)."
diff --git a/lib/ansible/modules/storage/netapp/_na_cdot_user.py b/lib/ansible/modules/storage/netapp/_na_cdot_user.py
index c3580091da..69008ff0b9 100644
--- a/lib/ansible/modules/storage/netapp/_na_cdot_user.py
+++ b/lib/ansible/modules/storage/netapp/_na_cdot_user.py
@@ -132,7 +132,7 @@ class NetAppCDOTUser(object):
choices=['community', 'password',
'publickey', 'domain',
'nsswitch', 'usm']),
- set_password=dict(required=False, type='str', default=None),
+ set_password=dict(required=False, type='str', default=None, no_log=True),
role_name=dict(required=False, type='str'),
vserver=dict(required=True, type='str'),