summaryrefslogtreecommitdiff
path: root/tools
Commit message (Collapse)AuthorAgeFilesLines
* all: SPDX header conversionLubomir Rintel2019-09-101-15/+1
| | | | | $ find * -type f |xargs perl contrib/scripts/spdx.pl $ git rm contrib/scripts/spdx.pl
* build: use regexp in gtkdoc --ignore-decorators optionBeniamino Galvani2019-09-061-7/+0
| | | | | | | gtkdoc-scan supports regular expressions in the --ignore-decorators command-line option. Since it is easier to use a regexp than grepping macros from a source file, revert the ugly solution from commit 2d941dc95a1d ('build: fix errors when building with gtk-doc 1.32').
* build: fix errors when building with gtk-doc 1.32Beniamino Galvani2019-09-051-0/+7
| | | | | | | | | | | | | | | | | | gtkdoc-scan 1.32 performs stricter checks on structures definitions and so it complains on: /build/networkmanager/src/NetworkManager/libnm/./nm-vpn-plugin-old.h:0: warning: partial declaration (struct) : typedef struct { NM_DEPRECATED_IN_1_2 GObject parent; } NMVpnPluginOld NM_DEPRECATED_IN_1_2; because of the unrecognized token 'NM_DEPRECATED_IN_1_2'. Pass all allowed macros to gtkdoc-scan through the --ignore-decorators argument. https://gitlab.gnome.org/GNOME/gtk-doc/issues/98 https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/238
* settings: rework tracking settings connections and settings pluginsThomas Haller2019-07-161-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Completely rework how settings plugin handle connections and how NMSettings tracks the list of connections. Previously, settings plugins would return objects of (a subtype of) type NMSettingsConnection. The NMSettingsConnection was tightly coupled with the settings plugin. That has a lot of downsides. Change that. When changing this basic relation how settings connections are tracked, everything falls appart. That's why this is a huge change. Also, since I have to largely rewrite the settings plugins, I also added support for multiple keyfile directories, handle in-memory connections only by keyfile plugin and (partly) use copy-on-write NMConnection instances. I don't want to spend effort rewriting large parts while preserving the old way, that anyway should change. E.g. while rewriting ifcfg-rh, I don't want to let it handle in-memory connections because that's not right long-term. -- If the settings plugins themself create subtypes of NMSettingsConnection instances, then a lot of knowledge about tracking connections moves to the plugins. Just try to follow the code what happend during nm_settings_add_connection(). Note how the logic is spread out: - nm_settings_add_connection() calls plugin's add_connection() - add_connection() creates a NMSettingsConnection subtype - the plugin has to know that it's called during add-connection and not emit NM_SETTINGS_PLUGIN_CONNECTION_ADDED signal - NMSettings calls claim_connection() which hocks up the new NMSettingsConnection instance and configures the instance (like calling nm_settings_connection_added()). This summary does not sound like a lot, but try to follow that code. The logic is all over the place. Instead, settings plugins should have a very simple API for adding, modifying, deleting, loading and reloading connections. All the plugin does is to return a NMSettingsStorage handle. The storage instance is a handle to identify a profile in storage (e.g. a particular file). The settings plugin is free to subtype NMSettingsStorage, but it's not necessary. There are no more events raised, and the settings plugin implements the small API in a straightforward manner. NMSettings now drives all of this. Even NMSettingsConnection has now very little concern about how it's tracked and delegates only to NMSettings. This should make settings plugins simpler. Currently settings plugins are so cumbersome to implement, that we avoid having them. It should not be like that and it should be easy, beneficial and lightweight to create a new settings plugin. Note also how the settings plugins no longer care about duplicate UUIDs. Duplicated UUIDs are a fact of life and NMSettings must handle them. No need to overly concern settings plugins with that. -- NMSettingsConnection is exposed directly on D-Bus (being a subtype of NMDBusObject) but it was also a GObject type provided by the settings plugin. Hence, it was not possible to migrate a profile from one plugin to another. However that would be useful when one profile does not support a connection type (like ifcfg-rh not supporting VPN). Currently such migration is not implemented except for migrating them to/from keyfile's run directory. The problem is that migrating profiles in general is complicated but in some cases it is important to do. For example checkpoint rollback should recreate the profile in the right settings plugin, not just add it to persistent storage. This is not yet properly implemented. -- Previously, both keyfile and ifcfg-rh plugin implemented in-memory (unsaved) profiles, while ifupdown plugin cannot handle them. That meant duplication of code and a ifupdown profile could not be modified or made unsaved. This is now unified and only keyfile plugin handles in-memory profiles (bgo #744711). Also, NMSettings is aware of such profiles and treats them specially. In particular, NMSettings drives the migration between persistent and non-persistent storage. Note that a settings plugins may create truly generated, in-memory profiles. The settings plugin is free to generate and persist the profiles in any way it wishes. But the concept of "unsaved" profiles is now something explicitly handled by keyfile plugin. Also, these "unsaved" keyfile profiles are persisted to file system too, to the /run directory. This is great for two reasons: first of all, all profiles from keyfile storage in fact have a backing file -- even the unsaved ones. It also means you can create "unsaved" profiles in /run and load them with `nmcli connection load`, meaning there is a file based API for creating unsaved profiles. The other advantage is that these profiles now survive restarting NetworkManager. It's paramount that restarting the daemon is as non-disruptive as possible. Persisting unsaved files to /run improves here significantly. -- In the past, NMSettingsConnection also implemented NMConnection interface. That was already changed a while ago and instead users call now nm_settings_connection_get_connection() to delegate to a NMSimpleConnection. What however still happened was that the NMConnection instance gets never swapped but instead the instance was modified with nm_connection_replace_settings_from_connection(), clear-secrets, etc. Change that and treat the NMConnection instance immutable. Instead of modifying it, reference/clone a new instance. This changes that previously when somebody wanted to keep a reference to an NMConnection, then the profile would be cloned. Now, it is supposed to be safe to reference the instance directly and everybody must ensure not to modify the instance. nmtst_connection_assert_unchanging() should help with that. The point is that the settings plugins may keep references to the NMConnection instance, and so does the NMSettingsConnection. We want to avoid cloning the instances as long as they are the same. Likewise, the device's applied connection can now also be referenced instead of cloning it. This is not yet done, and possibly there are further improvements possible. -- Also implement multiple keyfile directores /usr/lib, /etc, /run (rh #1674545, bgo #772414). It was always the case that multiple files could provide the same UUID (both in case of keyfile and ifcfg-rh). For keyfile plugin, if a profile in read-only storage in /usr/lib gets modified, then it gets actually stored in /etc (or /run, if the profile is unsaved). -- While at it, make /etc/network/interfaces profiles for ifupdown plugin reloadable. -- https://bugzilla.gnome.org/show_bug.cgi?id=772414 https://bugzilla.gnome.org/show_bug.cgi?id=744711 https://bugzilla.redhat.com/show_bug.cgi?id=1674545
* tools: export more symbols from NetworkManager binary to pluginsth/various-settings-cleanup-3Thomas Haller2019-06-261-1/+1
| | | | | Plugins also may use nmtst_*() functions (when built with --with-more-asserts) or c_list_*(). Whitelist them too.
* settings: drop ibft settings pluginth/drop-ibft-settings-pluginThomas Haller2019-06-201-4/+9
| | | | | | | | | | | | | | | The functionality of the ibft settings plugin is now handled by nm-initrd-generator. There is no need for it anymore, drop it. Note that ibft called iscsiadm, which requires CAP_SYS_ADMIN to work ([1]). We really want to drop this capability, so the current solution of a settings plugin (as it is implemented) is wrong. The solution instead is nm-initrd-generator. Also, on Fedora the ibft was disabled and probably on most other distributions as well. This was only used on RHEL. [1] https://bugzilla.redhat.com/show_bug.cgi?id=1371201#c7
* all: drop emacs file variables from source filesThomas Haller2019-06-111-1/+0
| | | | | | | | | | | | | | | | | | | | | | We no longer add these. If you use Emacs, configure it yourself. Also, due to our "smart-tab" usage the editor anyway does a subpar job handling our tabs. However, on the upside every user can choose whatever tab-width he/she prefers. If "smart-tabs" are used properly (like we do), every tab-width will work. No manual changes, just ran commands: F=($(git grep -l -e '-\*-')) sed '1 { /\/\* *-\*- *[mM]ode.*\*\/$/d }' -i "${F[@]}" sed '1,4 { /^\(#\|--\|dnl\) *-\*- [mM]ode/d }' -i "${F[@]}" Check remaining lines with: git grep -e '-\*-' The ultimate purpose of this is to cleanup our files and eventually use SPDX license identifiers. For that, first get rid of the boilerplate lines.
* build: install dispatcher dirs in /usrLubomir Rintel2019-04-261-0/+3
| | | | | | The dispatcher looks there for scripts now. This actually doesn't break the RPM build, since it doesn't mind extra empty directories in buildroot. Good.
* tools: fix out-of-tree build test "tools/check-docs.sh" for duplicate ↵Thomas Haller2019-04-231-1/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | generated sources When we do an in-tree-build with autotools and an out-of-tree build with meson (all in the same source directory), then we have the following files: libnm-core/nm-core-enum-types.h libnm/nm-enum-types.h build/libnm-core/nm-core-enum-types.h build/libnm/nm-enum-types.h This caused "tools/check-docs.sh" for `ninja -C build test` to fail, because the files are detected twice: --- command --- /data/src/NetworkManager/tools/check-docs.sh /data/src/NetworkManager /data/src/NetworkManager/build --- stderr --- 8a9 > nm-core-enum-types 38a40 > nm-enum-types *** Error: libnm classes not included in docs/libnm/libnm-docs.xml *** -------
* tools: cleanup path variable in "tools/check-docs.sh"Thomas Haller2019-04-231-7/+7
| | | | | - don't append the path separator to the SOURCEDIR variable. Instead, use the path separator when we need it.
* all: goodbye libnm-glibLubomir Rintel2019-04-162-3/+1
| | | | | | | | | | | | | | | | | | | | | | | This removes libnm-glib, libnm-glib-vpn, and libnm-util for good. The it has been replaced with libnm since NetworkManager 1.0, disabled by default since 1.12 and no up-to-date distributions ship it for years now. Removing the libraries allows us to: * Remove the horrible hacks that were in place to deal with accidental use of both the new and old library in a single process. * Relief the translators of maintenance burden of similar yet different strings. * Get rid of known bad code without chances of ever getting fixed (libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c) * Generally lower the footprint of the releases and our workspace If there are some really really legacy users; they can just build libnm-glib and friends from the NetworkManager-1.16 distribution. The D-Bus API is stable and old libnm-glib will keep working forever. https://github.com/NetworkManager/NetworkManager/pull/308
* Revert "all: goodbye libnm-glib"Lubomir Rintel2019-04-032-1/+3
| | | | | | We need this for a little little longer :( This reverts commit 1de8383ad9fdfc8f552117e5d109bdfa7005634b.
* lldp: support IEEE 802.3 TLVsBeniamino Galvani2019-03-271-1/+12
| | | | | | | | Add support for IEEE 802.3 organizationally specific TLVs: - MAC/PHY configuration/status (IEEE 802.1AB-2009 clause F.2) - power via medium dependent interface (clause F.3) - maximum frame size (clause F.4)
* lldp: support multiple PPVIDsBeniamino Galvani2019-03-271-0/+10
| | | | | As done for VLANs, add a new 'ppvids' attribute that reports all 'port and protocol VLAN ID' TLVs for the neighbor.
* lldp: support multiple vlansBeniamino Galvani2019-03-271-1/+11
| | | | | | | | | | | Previously we exported the contents of VLAN Name TLV in the 'vid' (uint32) and 'vlan-name' (string) attributes. This is not entirely correct as the TLV can appear multiple times. We need a way to export all the VLAN IDs and names for the neighbor. Add a new 'vlans' attribute which obsoletes the other two and is an array of dictionaries, where each dictionary contains the 'vid' and 'name' keys.
* lldp: add support for management address TLVBeniamino Galvani2019-03-271-0/+15
| | | | | | Support the management address TLV (IEEE 802.1AB-2009 clause 8.5.9). The TLV can appear multiple times and so it is exported on D-Bus as an array of dictionaries.
* cli: add lldp output testsBeniamino Galvani2019-03-271-0/+36
| | | | Check the result of 'nmcli device lldp' command.
* all: goodbye libnm-glibLubomir Rintel2019-03-192-3/+1
| | | | | | | | | | | | | | | | | | | | | | | This removes libnm-glib, libnm-glib-vpn, and libnm-util for good. The it has been replaced with libnm since NetworkManager 1.0, disabled by default since 1.12 and no up-to-date distributions ship it for years now. Removing the libraries allows us to: * Remove the horrible hacks that were in place to deal with accidental use of both the new and old library in a single process. * Relief the translators of maintenance burden of similar yet different strings. * Get rid of known bad code without chances of ever getting fixed (libnm-glib/nm-object.c and libnm-glib/nm-object-cache.c) * Generally lower the footprint of the releases and our workspace If there are some really really legacy users; they can just build libnm-glib and friends from the NetworkManager-1.16 distribution. The D-Bus API is stable and old libnm-glib will keep working forever. https://github.com/NetworkManager/NetworkManager/pull/308
* tests: Fix variant_from_dbus() for arrays of UInt32Frédéric Danis2019-03-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Using test-networkmanager-servic.py, I get the following error when trying to add manual config with a dns address: Error: g-io-error-quark: Traceback (most recent call last): File "/usr/lib/python2.7/dist-packages/dbus/service.py", line 707, in _message_cb retval = candidate_method(self, *args, **keywords) File "tools/test-networkmanager-service.py", line 1727, in AddConnection return self.add_connection(con_hash) File "tools/test-networkmanager-service.py", line 1731, in add_connection con_inst = Connection(self.c_counter, con_hash, do_verify_strict) File "tools/test-networkmanager-service.py", line 1601, in __init__ NmUtil.con_hash_verify(con_hash, do_verify_strict=do_verify_strict) File "tools/test-networkmanager-service.py", line 497, in con_hash_verify BusErr.raise_nmerror(e) File "tools/test-networkmanager-service.py", line 419, in raise_nmerror raise e Exception: Unsupported value ipv4.dns = dbus.Array([dbus.UInt32(168430090L), dbus.UInt32(218893066L)], signature=dbus.Signature('u'), variant_level=1) (Cannot convert array element to type 'u': Must be number, not Variant) https://mail.gnome.org/archives/networkmanager-list/2019-March/msg00013.html (cherry picked from commit 9a71d7d273e42a0d959240c6deb56cb0397eb6dd)
* clients/test: vary RSN capabilities across APsLubomir Rintel2019-02-051-2/+13
| | | | | This allows us to test if we distinguish WPA1, WPA2 and WPA3 in the client.
* all: return output dictionary from "AddAndActivate2"Thomas Haller2019-01-141-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a "a{sv}" output argument to "AddAndActivate2" D-Bus API. "AddAndActivate2" replaces "AddAndActivate" with more options. It also has a dictionary argument to be forward compatible so that we hopefully won't need an "AddAndActivate3". However, it lacked a similar output dictionary. Add it for future extensibility. I think this is really to workaround a shortcoming of D-Bus, which does provide strong typing and type information about its API, but does not allow to extend an existing API in a backward compatible manner. So we either resort to Method(), Method2(), Method3() variants, or a catch-all variant with a generic "a{sv}" input/output argument. In libnm, rename "nm_client_add_and_activate_connection_options()" to "nm_client_add_and_activate_connection2()". I think libnm API should have an obvious correspondence with D-Bus API. Or stated differently, if "AddAndActivateOptions" would be a better name, then the D-Bus API should be renamed. We should prefer one name over the other, but regardless of which is preferred, the naming for D-Bus and libnm API should correspond. In this case, I do think that AddAndActivate2() is a better name than AddAndActivateOptions(). Hence I rename the libnm API. Also, unless necessary, let libnm still call "AddAndActivate" instead of "AddAndActivate2". Our backward compatibility works the way that libnm requires a server version at least as new as itself. As such, libnm theoretically could assume that server version is new enough to support "AddAndActivate2" and could always use the more powerful variant. However, we don't need to break compatibility intentionally and for little gain. Here, it's easy to let libnm also handle old server API, by continuing to use "AddAndActivate" for nm_client_add_and_activate_connection(). Note that during package update, we don't restart the currently running NetworkManager instance. In such a scenario, it can easily happen that nmcli/libnm is newer than the server version. Let's try a bit harder to not break that. Changes as discussed in [1]. [1] https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/37#note_79876
* meson: add check on settings docsBeniamino Galvani2018-12-121-0/+19
| | | | | Move the autotools check on settings docs to a shell script and call it from meson too.
* core: add checks on connection default propertiesBeniamino Galvani2018-12-011-4/+48
| | | | | | | | | | Add a new CON_DEFAULT() macro that places a property name into a special section used at runtime to check whether it is a supported connection default. Unfortunately, this mechanism doesn't work for plugins so we have to enumerate the connection defaults from plugins in the daemon using another CON_DEFAULT_NOP() macro.
* build: check that the list of supported config options is up to dateBeniamino Galvani2018-12-011-0/+28
| | | | | Add a script run during 'make check' to verify that all config options are in the list of supported ones.
* libnm: Add support to pass options to AddAndActivateConnectionBenjamin Berg2018-11-171-0/+6
| | | | | | | This adds the new methods nm_client_add_and_activate_connection_options_* and ports the existing methods to use the new AddAndActivateConnection2 call rather than AddAndActivateConnection, allowing further parameters to be passed in.
* build: meson: fix wrong man page linkBeniamino Galvani2018-11-081-1/+1
| | | | | | Fixes: 98b4a19a536ddb9f75611deaa272ae5661c5df4d https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/78
* tests: simulate old LastScan wifi value in test-networkmanager-service.pybg/issue39Beniamino Galvani2018-11-021-10/+2
| | | | | In this way clients will randomly find that the AP list is older than 30 seconds and they will issue a new scan.
* build: fix check-docs.sh for out-of-tree buildsThomas Haller2018-10-251-6/+31
| | | | Fixes: 7a59cd274485e4c0345c563d48e516967630d7f0
* docs: rework check-docs test scriptThomas Haller2018-10-251-14/+40
| | | | | | | | Try to make check-docs.sh script more readable. Also, previously the script would check that one side was a subset of the other side. Tighten this check up, now both sides of the comparison must agree and yield the same lines.
* docs: fix bashism in tools/check-docs.shMichael Biebl2018-10-251-1/+1
| | | | [thaller@redhat.com: fixed issue in original patch]
* build: fix ibft option in create-exports-NetworkManager.shBeniamino Galvani2018-10-241-1/+1
|
* tests: support UInt64 type in test-networkmanager-service.pyThomas Haller2018-10-171-3/+6
| | | | and also accept "gsm" connection-type. Both will be used next.
* acd/tests: skip NAcd tests under valgrindThomas Haller2018-10-041-2/+5
| | | | | | | | | | | | | | Under valgrind, we cannot create an NAcd instance. --10916-- WARNING: unhandled amd64-linux syscall: 321 --10916-- You may be able to write your own handler. --10916-- Read the file README_MISSING_SYSCALL_OR_IOCTL. --10916-- Nevertheless we consider this a bug. Please report --10916-- it at http://valgrind.org/support/bug_reports.html. This limitation already poses a problem, because running NetworkManager under valgrind might fail. However, for tests it doesn't matter and we can just skip them.
* build: silence message in "tools/create-exports-NetworkManager.sh" about ↵Thomas Haller2018-10-011-2/+2
| | | | | | | | | | | | | missing directory When building with meson -Dppp=false, the following message is printed during build: [623/671] Generating NetworkManager.ver with a custom command. find: ‘./src/ppp/’: No such file or directory The message is harmless. Hide it. https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues/43
* build: meson: fix install scriptBeniamino Galvani2018-09-281-4/+7
| | | | | | Fix directory paths and modes. Fixes: 98b4a19a536ddb9f75611deaa272ae5661c5df4d
* build: meson: fix computing NM exported symbolsBeniamino Galvani2018-09-191-1/+6
| | | | | | | | | | | | | | | | | | The script didn't include all the symbols needed by plugins because libNetworkManager.a, as built by meson, doesn't include symbols from other static libraries that are linked in. Since we used libNetworkManager.a to know which symbols are potentiall available from NM, the result was an incomplete list. Unfortunately, the only way to include the whole static library is to create a dependency object and use 'link_whole', but this is only available in meson >= 0.46. Since 'link_whole' is available for executables in meson >= 0.40, create a fake executable and use that to enumerate symbols. Also add tests to check that plugins can be loaded correctly. Fixes: dfa2a2b40c866bf7a5484b72639464c31b80e7da
* build: meson: support $DESTDIR in installation scriptBeniamino Galvani2018-09-191-0/+44
| | | | | | | Adapt the meson post-installation script to handle the $DESTDIR variable supplied by user to specify the installation target directory. While at it, convert the script to shell because it seems simpler to me.
* docs: misc. typos pt2luz.paz2018-09-171-1/+1
| | | | | | | | | | | | | | | | | | | | | Remainder of typos found using `codespell -q 3 --skip="./shared,./src/systemd,*.po" -I ../NetworkManager-word-whitelist.txt` whereby whitelist consists of: ``` ans busses cace cna conexant crasher iff liftime creat nd sav technik uint ``` https://github.com/NetworkManager/NetworkManager/pull/205
* build: support meson builds in create-exports scriptBeniamino Galvani2018-09-131-6/+15
| | | | (cherry picked from commit 9b4bc0824c1d8925f1ecfa4856757d322f030427)
* build: fix whitelisting c-siphash symbols in NetworkManager.ver for device ↵Thomas Haller2018-09-051-1/+1
| | | | | | | | | | | | plugin NetworkManager.ver needs to whitelist symbols needed by device, settings, and ppp plugin. Fix the generator script to also allow using c_siphash_*() symbols. These are needed by nm_hash_*(). Without this, wifi device plugin is broken. Fixes: ccf36ff4cea6eb6a7ecd872563dfbd3a00f8cfdf
* all: point git references to the GitLab instanceLubomir Rintel2018-08-271-1/+1
| | | | https://gitlab.freedesktop.org/NetworkManager/NetworkManager/merge_requests/2
* tests/trivial: rename ip4_addr_ne32() to ip4_addr_be32() in ↵Thomas Haller2018-07-111-7/+9
| | | | | | | | | | | | | | test-networkmanager-service.py The function is supposed to return the IPv4 address as 32 bit integer in network byte order (bit endian). The ip4_addr_ne32() name is confusing, because "ne" commonly stands for "native endianness". Compare also "unaligned.h" and unaligned_read_ne32(), which also stands for native endianness (host order), not network order (big endian). Rename.
* docs: include missing documentation in libnm and D-Bus docsLubomir Rintel2018-06-281-0/+22
| | | | | | Check that we don't repeat the omission in future. (cherry picked from commit cb1172ee3d929dddb3313fd4611160fa8cd5b3e6)
* tests: don't exit test-networkmanager-service.py after 20 secondsThomas Haller2018-06-181-5/+0
| | | | | | | | | Tests might just take longer than 20 seconds. Also, we already watch stdin to determine whether the service should exit. (cherry picked from commit 4e18ef49bf2527b4c29a0bdff2faddf0194dd5bd)
* tests: improve NetworkManager stub service for Wi-Fi scanningThomas Haller2018-06-181-6/+34
| | | | | | | | | | | | Now that nmcli initiates a scan before displaying Wi-Fi networks, the stub service must properly support that as well. For the moment, the stub service chooses "now" as LastScan timestamp. This causes nmcli not to trigger a new scan, because nmcli gives unstable output if multiple nmcli processes in parallel race to trigger a Wi-Fi scan. That should be fixed. (cherry picked from commit 56a0488bbae38f8d802b1cc32ba94c1640f70bc6)
* tests: fix race in setting signal strength for Wi-Fi AP in NM stubThomas Haller2018-06-181-24/+2
| | | | | | | | | | | | | | | | | This opens the tests up to races. If we want to change the strength, we need to do it in a controlled, race-free manner. This is especially the case, because clients/tests run a large number of nmcli instances in parallel, and it's thus racy which signal the nmcli processes will see. This also fixes a bug at self._dbus_property_set(IFACE_WIFI_AP, PRP_WIFI_AP_STRENGTH, strength) @strength must be a D-Bus type, so that python-dbus knows the correct type for serialization. (cherry picked from commit 7e118c00916aa7dd3f04752debbcc09569d6effe)
* tools/test-service: utilize nm_utils_get_timestamp_msec()Lubomir Rintel2018-06-151-1/+1
| | | | This is probably better than a hardcoded timestamp.
* wifi: expose LastScan as milliseconds not secondsLubomir Rintel2018-06-151-1/+1
| | | | | This doesn't wrap around in 68 years of uptime and is consistent with o.fd.NM.Checkpoint.Created.
* clients/tests: fix unstable tests for Python2 vs. Python3Thomas Haller2018-06-141-11/+17
| | | | | | | | | | | | | | Currently, nmcli does not sort the list of available connections for display. Instead, it shows them in the order as NetworkManager exposes them on D-Bus. Previously, test-networkmanager-service.py, would generate the list of available connections by iterating the connections dictionary. In Python (at least until Python 3.6), the order when iterating over dictionaries is undefined. This inconsistancy lets tests behave differently depending on the python version. Possibly with Python 3.4 and 3.5, tests might even behave differently between individual runs (since Python there uses siphash with a randomized hash seed).
* wifi: expose the LastScan propertyLubomir Rintel2018-06-131-0/+2
| | | | | This is the time when the last Wi-Fi scan finished. It will help clients decide whether the AP list is fresh enough.
View Lorry Controller Status