summaryrefslogtreecommitdiff
path: root/cli/src
Commit message (Collapse)AuthorAgeFilesLines
* cli: fix bridge priority default value (rh #1073664)Jiří Klimeš2014-03-171-2/+2
| | | | | | It is 32768 (0x8000) instead of 128 (0x80). 13c348d fixes that in the setting. https://bugzilla.redhat.com/show_bug.cgi?id=1073664
* cli: sanitize team config before setting it into propertyJiří Klimeš2014-03-121-1/+12
| | | | | | | | Replace '\r' and '\n' chareacter with a space in the configuration. libteamdctl sends the config to team daemon using its usock interface that separates parameters with '\n'. Related: rh #1051517
* cli: accept prefix "ifname/", "uuid/" or "id/" for 'master' argumentJiří Klimeš2014-03-121-12/+50
| | | | | | | | nmcli con add type team-slave ifname em2 master team-master0 nmcli con add type team-slave ifname em2 master id/team-master0 It helps to disambiguate values for cases where they may overlap, e.g. "team0" -> "ifname/team0" or "id/team0"
* cli: allow specifying 'master' for slaves as connection ID (rh #1057494)Jiří Klimeš2014-03-121-12/+69
| | | | | | | | | | | nmcli con add type *-slave ifname em1 master <ifname|UUID|name> 'master' property of 'connection' setting has to be either interface name or connection UUID of master connection. However, to make nmcli more convenient for users, we also allow specifying connection name and translating it to UUID automatically. https://bugzilla.redhat.com/show_bug.cgi?id=1057494
* cli: fix a crash when trying to set a white-space string as IP (rh #1071394)Jiří Klimeš2014-03-031-18/+22
| | | | | | | | | | | | nmcli con modify my-profile ipv4.addr " " nmcli con modify my-profile ipv6.addr " " Note: Empty string should be used to remove IPs, and 'method' might be needed to set to 'auto' simultaneously, as well. $ nmcli con modify profile1 ipv4.addr "" ipv4.method auto https://bugzilla.redhat.com/show_bug.cgi?id=1071394
* cli: update 'nmcli con modify' helpJiří Klimeš2014-02-281-2/+3
|
* cli: update 'remove' command description for 'nmcli con edit'Jiří Klimeš2014-02-281-5/+12
| | | | to reflect that user can specify a value or index to remove values.
* cli: allow removing properties by-value (in addition to by-index)Jiří Klimeš2014-02-281-156/+592
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It works both in 'nmcli con modify' and 'nmcli con edit'. The following properties are supported (all container-type properties except properties with option names): ipv4.dns ipv4.dns-searches ipv4.addresses ipv4.routes ipv6.dns ipv6.dns-searches ipv6.addresses ipv6.routes 802-1x.eap 802-1x.altsubject-matches 802-1x.phase2-altsubject-matches connection.permissions connection.secondary 802-3-ethernet.mac-address-blacklist 802-11-wireless.mac-address-blacklist 802-11-wireless-security.proto 802-11-wireless-security.pairwise 802-11-wireless-security.group vlan.ingress-priority-map vlan.egress-priority-map
* cli: support removing items from container-type properties in 'nmcli con modify'Jiří Klimeš2014-02-281-13/+44
| | | | | | | | | | | | | | | | | | | | | Synopsis: nmcli con modify -<property>.<setting> <value> 'value' can be empty ("") to remove the whole property value value (in this case the behaviour is the same as without '-'). Or the 'value' is an index of the item to remove, or an option name (for a few properties that have option names, like bond.options or ethernet.s390-options). $ nmcli con mod myeth ipv4.dns "10.0.0.55 10.0.0.66 8.8.8.8 8.8.4.4" ---> ipv4.dns: 10.0.0.55, 10.0.0.66, 8.8.8.8, 8.8.4.4 $ nmcli con mod myeth -ipv4.dns 1 ---> ipv4.dns: 10.0.0.55, 8.8.8.8, 8.8.4.4 ---> bond.options: mode=balance-rr $ nmcli con mod bond0 +bond.options "mii=500, downdelay=800" ---> bond.options: downdelay=800,miimon=500,mode=balance-rr $ nmcli con mod bond0 -bond.options downdelay ---> bond.options: miimon=500,mode=balance-rr
* cli: allow modifying multiple properties by 'nmcli con modify'Jiří Klimeš2014-02-281-72/+100
| | | | | | | | | This is necessary especially for cases where properties depend on each other. So you need to set them in one command, else the profile won't validate. Examples: nmcli con mod em1-1 ipv4.method manual ipv4.addr "192.168.1.2/24,10.10.1.5/8" nmcli con mod profile ipv4.method link-local ipv4.addr ""
* cli: set vs. append property value by 'nmcli con modify' (rh #1044027)Jiří Klimeš2014-02-281-4/+19
| | | | | | | | | | | | | | | | | | | | Previously 'nmcli con modify' appended values for multi-value properties. This commit makes 'nmcli con modify' overwrite the whole value. You can choose appending values by prefixing the setting.property with '+' sign. For simple (not container) properties the behaviour is the same both with and without the '+', of course. Synopsis: nmcli connection modify [+]<setting>.<property <value> Example: ---> ipv4.dns = 1.2.3.4 $ nmcli connection modify my-em1 ipv4.dns 8.8.8.8 ---> ipv4.dns = 8.8.8.8 $ nmcli connection modify my-em1 +ipv4.dns 8.8.4.4 ---> ipv4.dns = 8.8.8.8 8.8.4.4 https://bugzilla.redhat.com/show_bug.cgi?id=1044027
* cli: allow temporary connection modification by 'nmcli con modify'Jiří Klimeš2014-02-281-6/+11
| | | | nmcli connection modify [--temporary] ...
* trivial: more wrong compiler warningsThomas Haller2014-02-271-1/+1
| | | | | | | | | | | | connection_parser.c: In function 'make_ip4_setting': connection_parser.c:660:33: error: 'method' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (!is_static_block && strstr (method, "dhcp")) { connections.c: In function ‘load_cmd_line_edit_lib’: connections.c:5744:17: error: ‘module’ may be used uninitialized in this function [-Werror=maybe-uninitialized] g_module_close (module); Signed-off-by: Thomas Haller <thaller@redhat.com>
* replace snprintf by g_snprintfThomas Haller2014-02-241-2/+1
| | | | | | Use the glib wrapper for snprintf. Signed-off-by: Thomas Haller <thaller@redhat.com>
* cli: allow resetting the connection.master to NULLThomas Haller2014-02-241-2/+6
| | | | | | | | Without this patch, the following two commands fail: nmcli connection modify em1 connection.master nmcli connection modify em1 connection.master "" Signed-off-by: Thomas Haller <thaller@redhat.com>
* cli: better checking of WEP key types in nmcli interactive editor (rh #1040964)Jiří Klimeš2014-02-171-11/+54
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1040964
* libnm-util, libnm-glib: add versioned deprecation/availability macrosDan Winship2014-02-131-0/+1
| | | | | | | | | | | | | | | | Add versioned NM_DEPRECATED_IN_* and NM_AVAILABLE_IN_* macros, and tag new/deprecated functions accordingly. (All currently-deprecated functions are assumed to have been deprecated in 0.9.10.) Add NM_VERSION_MIN_REQUIRED and NM_VERSION_MAX_ALLOWED macros which can be set to determine which versions will cause warnings. With the current settings, external consumers of the libnm-util/libnm-glib APIs will have MIN_REQUIRED and MAX_ALLOWED both set to NM_VERSION_0_9_8 by default, meaning they will get warnings about functions added in 0.9.10. NM internally sets NM_VERSION_MAX_ALLOWED to NM_VERSION_NEXT_STABLE to ensure that it is always allowed to use all APIs.
* cli: show warning when setting band/channel for infra mode (rh #1000096)Thomas Haller2014-02-133-4/+60
| | | | | | | | | | | | | | The band/channel property is not considered when connecting to an access point. Print a warning, when setting one of these values in edit mode. For now, don't forbid the user to make such setting. Also, because in the future, wpa_supplicant might support this. https://bugzilla.redhat.com/show_bug.cgi?id=999997 https://bugzilla.redhat.com/show_bug.cgi?id=1000096 Signed-off-by: Thomas Haller <thaller@redhat.com>
* cli: fix crash if active connection doesn't have a device (rh #1064333)Jiří Klimeš2014-02-121-7/+13
| | | | | | | | | | $ nmcli dev connect wlan0 This can happen for example when some other process disconnects the connection being connected. Also fix printing a message on success. https://bugzilla.redhat.com/show_bug.cgi?id=1064333
* cli: persistent vs. temporary save for 'nmcli con edit'Jiří Klimeš2014-01-301-16/+65
|
* cli: allow creating temporary (unsaved) connection with 'nmcli con add'Jiří Klimeš2014-01-301-4/+32
|
* cli: handle hidden-SSID access points correctlyDan Williams2014-01-231-11/+17
|
* cli: allow processing all connections with the same nameJiří Klimeš2014-01-231-22/+61
| | | | | | | | | | When there are multiple connection profiles of the same name, we used to take and process only the first one. We change the behaviour to process all the connections now in these commands: nmcli connection show <duplicated name> nmcli connection down <duplicated name> nmcli connection delete <duplicated name>
* cli: consolidate active and configured connections (rh #997999)Jiří Klimeš2014-01-233-325/+528
| | | | | | | | | | | | | | | | | | | | | | Handle connection profiles in a single 'show' command instead of 'show active' and 'show configured'. nmcli con show [--active] [[id|uuid|path|apath] <bla>] nmcli con show : display all connection profiles nmcli con show --active : only display active connection profiles (filters out inactive profiles) nmcli con show myeth : display details of "myeth" profile, and also active connection info (if the profile is active) nmcli -f profile con show myeth : only display "myeth"'s static configuration nmcli -f active con show myeth : only display active details of "myeth" nmcli -f connection.id,ipv4,general con show myeth : display "connection.id"a property "ipv4" setting and "GENERAL" group of active data https://bugzilla.redhat.com/show_bug.cgi?id=997999
* cli: always get up-to-date dirty statusJiří Klimeš2014-01-211-10/+13
|
* cli: fix crash when edited profile was removed by another client (rh #1011942)Jiří Klimeš2014-01-211-12/+57
| | | | | | | | | Use g_weak_ref_get() that either returns an object with reference increment or returns NULL. That fixes the problem. However, in the long run we should rework the editor loop trying to merge that with GMainLoop, which could help for various issues. https://bugzilla.redhat.com/show_bug.cgi?id=1011942
* cli: fix TAB-completion and 'goto' after saving connectionJiří Klimeš2014-01-201-3/+15
| | | | | On 'save' we replace settings in the local connection, so we also need to update stored setting pointers.
* trivial: annotate/adjust some code to appease CoverityDan Winship2014-01-161-1/+1
|
* cli: fix printing error on incorrect 'nmcli -f blah dev show'Jiří Klimeš2014-01-101-3/+8
| | | | Don't print extra empty lines before the error.
* cli: add 'help' for second level commands (bgo #698237) (rh #1034119)Jiří Klimeš2014-01-093-118/+565
| | | | | | | | | | | | | In addition to 'nmcli connection help', you can now use: nmcli con up help nmcli con down help nmcli dev wifi help etc. The help option can also be in the form of --help/-h, or even shortened. https://bugzilla.gnome.org/show_bug.cgi?id=698237 https://bugzilla.redhat.com/show_bug.cgi?id=1034119
* cli: fix leaks for getter functions (release GValue)Thomas Haller2014-01-081-4/+16
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* cli: display MTU for devicesJiří Klimeš2013-12-201-28/+29
|
* cli: simplify getting device hardware addressesJiří Klimeš2013-12-201-17/+1
|
* cli: more compact format for device info (nmcli device show) (rh #998003)Jiří Klimeš2013-12-201-33/+41
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=998003
* cli: get IP/DHCP config directly from the NMActiveConnection (rh #1036132)Dan Winship2013-12-191-44/+16
| | | | | | | Now that NMActiveConnection has IP and DHCP config info, use that directly in "nmcli con show active" rather than getting it from the connection's device; this way, we get the right info for VPN connections as well.
* cli: support PPPoE connection types in 'nmcli con add'Jiří Klimeš2013-12-181-0/+127
|
* cli: consider empty value as "*" for "Interface name [*]: " prompt (rh #953397)Jiří Klimeš2013-12-181-2/+5
| | | | | | And, do it right this time. https://bugzilla.redhat.com/show_bug.cgi?id=953397
* Revert "cli: consider empty value as "*" for "Interface name: " prompt"Jiří Klimeš2013-12-181-4/+6
| | | | | | This reverts commit 3cb0bf6bc06293a224bfda4967457af69be89bfc. It broke 'ifname' being required as a mandatory parameter as decided in https://bugzilla.gnome.org/show_bug.cgi?id=698113
* cli: 'id' option for 'nmcli con add type vlan' is mandatory (rh #953397)Jiří Klimeš2013-12-181-1/+1
| | | | | | So update documentation accordingly. https://bugzilla.redhat.com/show_bug.cgi?id=953397
* cli: fix compilation without WiMAXJiří Klimeš2013-12-171-5/+0
|
* cli: allow '--field group.field' for nmcli con show conf <bla>Jiří Klimeš2013-12-173-110/+166
| | | | | | | | | That means you can display single property. Example: $ nmcli -f connection.id,802-3-ethernet.mtu s c my-eth-profile connection.id: my-eth-profile 802-3-ethernet.mtu: auto
* cli: allow '--field group.field' for nmcli con show active <bla>Jiří Klimeš2013-12-171-21/+79
| | | | | | | Example: $ nmcli -f general.name,ip4.address c s a myeth GENERAL.NAME: myeth IP4.ADDRESS[1]: ip = 10.34.25.228/23, gw = 10.34.25.254
* cli: allow specifying 'group.name' syntax for '--fields'Jiří Klimeš2013-12-179-178/+262
| | | | | | | | | | | | | | | | | and use it for 'nmcli device show'. This allows filtering output not only for whole groups, but also for individual fields in commands that print data in groups (sections). Example: $ nmcli -f general.device,general.driver,ipv4,ipv6.address device show eth0 GENERAL.DEVICE: eth0 GENERAL.DRIVER: e1000e IP4.ADDRESS[1]: ip = 10.0.5.228/23, gw = 10.0.5.254 IP4.ADDRESS[2]: ip = 5.5.5.5/32, gw = 5.5.5.1 IP4.DNS[1]: 192.168.122.1 IP4.DNS[2]: 8.8.8.8 IP4.DOMAIN[1]: mycompany.com
* cli: fix description of connection parameters and specify some default valuesJiří Klimeš2013-12-131-2/+2
|
* cli: support PPPoE connection type in nmcli connection editorJiří Klimeš2013-12-111-2/+7
|
* cli: add active connections to 'nmcli device status'Jiří Klimeš2013-12-091-8/+41
|
* cli: fix nmcli help for connection object (rh #1036545)Jiří Klimeš2013-12-021-1/+1
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1036545
* nmcli: fix connecting VLANs without an explicit interface-name (rh #1034908)Jiří Klimeš2013-11-281-5/+26
| | | | | | | | | nm_connection_get_virtual_iface_name() doesn't work when determining virtual connections, because for VLANs it can return NULL. See also commit e1e4740648d3ee522c8a80d1af6282afce94f53d. https://bugzilla.redhat.com/show_bug.cgi?id=1034908
* cli: add support for DCB settingsDan Williams2013-11-273-1/+561
|
* cli: add NMC_RESULT_ERROR_NOT_FOUND and use as appropriateDan Winship2013-11-223-20/+23
| | | | | | | This will allow callers to distinguish "no such connection" from "connection failed to activate", etc. https://bugzilla.redhat.com/show_bug.cgi?id=1022256