| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
| |
nm_utils_hwaddr_ntoa() is not suitable, because it only
allows up to NM_UTILS_HWADDR_LEN_MAX characters.
Also, let's do lower-case and no separator character.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For some device types, we use the DEVTYPE from sysfs to determine the
link type. However, the way we read from sysfs can race with device
renames and we could miss the chance to read DEVTYPE correctly.
This doesn't completely fix the sysfs race, but cures the boot-time race
with systemd renaming the device while we are initializing the link.
We ideally should use GUDev for all sysfs accesses, but that would need
some more work for this particular case as currently we need the link type
before we have an udev device instance.
https://bugzilla.gnome.org/show_bug.cgi?id=764803
Co-Authored-By: Beniamino Galvani <bgalvani@redhat.com>
|
| |
|
|
|
| |
Fixes: 89d1e466157839096b446068a780cb2563424a5a
Tested-by: Celti on IRC
|
| |
|
|
|
| |
The value cannot be unset. It must be set to one of the two currently
supported values.
|
| |
|
|
| |
(cherry picked from commit 3ad7be3e6a124fe9e279ec6d9de06c423ca50cc2)
|
| |\ |
|
| | | |
|
| | | |
|
| |/
|
|
| |
https://mail.gnome.org/archives/networkmanager-list/2016-April/msg00075.html
|
| |\
| |
| |
| | |
Some cleanup of "nm-sleep-monitor-systemd.c"
|
| | |
| |
| |
| |
| | |
The lifetime of the proxy is not necesarily the same as the lifetime
of the NMSleepMonitor instance. Disconnect the signals during dispose().
|
| | |
| |
| |
| |
| |
| | |
The daemon does not run with a particular locale of a user. Localizing
makes no sense (at least, we don't do it usually and it would make
logging localized).
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
As we don't take a reference on @self during the asynchronous
request, we must properly support cancelling in case of early
destruction.
I think, it's gdbus' responsibility not to leak any file descriptors
when cancelling a D-Bus request that returns file descriptors. Thus,
our usual pattern works here too.
|
| | |
| |
| |
| |
| | |
When destroing the sleep monitor before the D-Bus proxy is created,
we must cancel creation of the proxy.
|
| | | |
|
| | |
| |
| |
| |
| | |
To release resources, dispose() is preferred over finalize()
because it is called earlier.
|
| | | |
|
| |/ |
|
| |
|
|
|
|
| |
@error
Fixes: 07a9364d9c151bc3086a863759d31d0857ae011e
|
| |
|
|
| |
Fixes: 4271c9650c1cfcbd487cc471099b1c0c9bbfa290
|
| |
|
|
| |
Fixes: f15c412015647b378a187bdf98ccf8cd75eb0475
|
| |
|
|
|
|
|
| |
libnm-core/nm-vpn-plugin-info.c: In function ‘nm_vpn_plugin_info_get_auth_dialog’:
shared/gsystem-local-alloc.h:53:46: error: ‘prog_basename’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
Fixes: a3f94f451b910bbaf38a172f6bb9a2050a9553e5
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidepid
When mounting /proc with hidepid, we might fail to read the
start-time of the process from /proc/$PID/stat. In this case,
we should just accept a start-time of zero.
On the other side of authentication, polkit should accept a zero
start-time too.
nm_utils_get_start_time_for_pid() has other uses in NetworkManager,
mostly when killing a process from a PIDFILE or during
nm_utils_kill_process_sync(). In both these cases, this will only
succeed if we try to kill a process that also runs a root.
For processes started by the current instance, we don't care about the
PIDFILE and use nm_utils_kill_child_?sync() -- so there is no problem
with hidepid there.
https://bugzilla.gnome.org/show_bug.cgi?id=764502
|
| |\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=765329
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
Re-add nm_vpn_plugin_info_get_service(). This function *is* useful
and could be used by nm-applet.
This reverts commit 3517084b92aa64817ce8cd82163e5ab6e1947017.
|
| |/
|
|
|
|
|
| |
_nm_vpn_plugin_info_list_load_dir()
No need to assert against an empty dirname. It's not different from
any other non-existing directory and we should be graceful about that.
|
| | |
|
| |
|
|
|
|
| |
And for @out_state, return ' ' instead of '\0' in case of
failure. That is more friendly, when the user happens to
print the value.
|
| |
|
|
|
|
| |
Otherwise the types links would be dangling or resolved to slightly
irrelevant documentation in libnm or completely irrelevant documentation
in libnm-util.
|
| |
|
|
|
|
| |
It isn't right in that context -- NMDevice is a libnm-core object,
not a bus object. In rendered documentation this would generate
a dangling link.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
| |
Pass an empty configuration file otherwise dnsmasq loads
"/etc/dnsmasq.conf".
We already allow for a config.d/ directory "/etc/NetworkManager/dnsmasq.d"
to allow the user to overwrite configuration. We don't want to consider
the global config file.
Fixes: 497a8aa5c6463404200a3fcc745aa65396dc4f22
|
| |\
| |
| |
| |
| | |
https://mail.gnome.org/archives/networkmanager-list/2016-March/msg00144.html
https://bugzilla.gnome.org/show_bug.cgi?id=765043
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
Use DBus to make nameserver updates rather than restarting the dnsmasq binary
again and again.
Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
https://mail.gnome.org/archives/networkmanager-list/2016-March/msg00144.html
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
The 4 private fields pid, watch_id, progname and pidfile strictly
belong together. When spawning a child, we set all 4 of them and
when killing the child all get cleared. Cleanup to code to always
set those 4 fields together.
|
| | |
| |
| |
| |
| | |
dispose() already calls nm_dns_plugin_child_kill(), which clears
both pidfile and progname.
|
| |/ |
|
| | |
|
| |
|
|
|
|
|
| |
wifi_utils_is_wifi() only has one caller, so it's very clear
what the passed in @sysfs_path contains. Instead of accepting
a redundant argument, compute the sysfs path internally based
on @iface alone.
|
| |
|
|
| |
And while at it, don't pass the sysfs_path but instead the ifname to it.
|
| |
|
|
|
| |
It is interesting to find in the logfile when we write to "/etc/resolv.conf"
or our internal version "/var/run/NetworkManager/resolv.conf".
|
| |
|
|
|
|
|
| |
When NetworkManager exits, it must preserve the DNS configuration of
devices that are left up.
Fixes: 9498ea507eb1d5042736c4351337e91b9c13bdf6
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
The main purpose of audit logging is to understand who did what to the
system configuration, so it is useful to log also the list of changed
properties when a connection is updated:
op="connection-update"
uuid="2f3e48fc-5f47-41d9-9278-d2871378df43"
name="pppoe1"
args="pppoe.username,pppoe.password" <========
pid=9523
uid=1001
result="success"
|
| |
|
|
|
| |
Fixes an assertion failure on WWAN connection attempts that fail before
secrets are requested.
|
| |\
| |
| |
| | |
https://bugzilla.gnome.org/show_bug.cgi?id=765303
|
