summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* nm-online: obtain NMClient asynchronouslylr/async-onlineLubomir Rintel2017-01-041-90/+82
| | | | | | | | | | | | | | | | Before: $ time nm-online real 0m0.438s user 0m0.192s sys 0m0.023s After: $ time ./clients/nm-online real 0m0.096s user 0m0.060s sys 0m0.010s
* exported-object: merge extending counter for D-Bus paths to 64bitThomas Haller2017-01-0312-16/+20
|\
| * exported-object: don't use "/0" for D-Bus paths but start with 1Thomas Haller2017-01-031-1/+1
| | | | | | | | | | | | Only use non-negative index values for the D-Bus path. This is purely cosmetical, as the actual path value should be treated as opaque. Still, avoid using 0 and start counting at 1.
| * exported-object: don't clone class_export_path for counter cacheThomas Haller2017-01-031-1/+1
| | | | | | | | It's a static string anyway.
| * exported-object: make export_path D-Bus counter 64 bitThomas Haller2017-01-032-6/+8
| | | | | | | | | | | | An overflow of the 32 bit guint is possible and rather ugly because the D-Bus path should be unique and not repeat. Avoid that by extending the counter to 64 bit.
| * exported-object: use NM_EXPORT_PATH_NUMBERED() macroThomas Haller2017-01-0310-10/+10
| |
| * exported-object: add NM_EXPORT_PATH_NUMBERED() macroThomas Haller2017-01-031-0/+2
|/
* ifcfg-rh: merge branch 'th/ifcfg-shvar-line-bgo776467'Thomas Haller2017-01-022-221/+275
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=776467
| * ifcfg-rh: refactor svOpenFile() to use nm_utils_fd_get_contents()Thomas Haller2017-01-021-68/+62
| | | | | | | | | | | | | | | | | | | | Use nm_utils_fd_get_contents() which has precisely all the steps implemented to read data from a file descriptor. There is a downside to this: previously you could compile shvar.c without nm-core-utils.c. Now, the ifcfg implementation gained a dependency on NM core utils. That would matter if we one day would like to build shvar.c without core NetworkManager utils (but that is not planned).
| * ifcfg-rh: add assertions for handling lines in "shvar.c"Thomas Haller2017-01-021-0/+47
| | | | | | | | Just assert that the shvarLine instances are in a valid state.
| * ifcfg-rh: refactor handling of lines in shvar.cThomas Haller2017-01-021-115/+126
| | | | | | | | | | | | | | | | Pre-process each line and parse the key and value. Thus, keep the key already prepared. The point is to do the parsing early and keep the data in a more suitable format in shvarLine.
| * ifcfg-rh: refactor searching and replacing shvarLine in svhar.cThomas Haller2017-01-011-86/+76
| | | | | | | | | | | | | | | | | | The shlist_delete*() are now named wrong, as they don't delete the list entry. Anyway, they have only one caller, it's clearer to inline them. This way, during svSetValue() we need to iterate the entire list only once.
| * shared: add nm_str_skip_leading_spaces() macroThomas Haller2016-12-251-0/+12
|/
* manager: better handle failures in AddAndActivateConnectionBeniamino Galvani2016-12-231-1/+2
| | | | | | nm_settings_add_connection_dbus() invokes the activation_add_done() callback with a NULL @new_connection in case of error: add a check to prevent a crash.
* policy: don't apply DNS configuration for non-active devicesBeniamino Galvani2016-12-211-1/+1
| | | | | | | | Don't apply DNS configuration of non-active devices (for example unmanaged ones which have a non-empty DNS configuration read from a DHCP lease). https://bugzilla.redhat.com/show_bug.cgi?id=1405431
* wifi: don't request new PSK for locally-generated ↵Dan Williams2016-12-201-1/+11
| | | | | | | WLAN_REASON_DISASSOC_DUE_TO_INACTIVITY errors This usually indicates that the driver missed beacons from the AP, due to driver bugs or faulty power-save management. It doesn't mean that the PSK is wrong.
* libnm: add nm_utils_version() function to query libnm version at runtimeThomas Haller2016-12-203-0/+21
| | | | | if (nm_utils_version () < NM_ENCODE_VERSION (1, 5, 0)) g_error ("Requires at least version 1.5.0");
* libnm: add public macro NM_VERSION for the current build-time version of libnmThomas Haller2016-12-202-0/+3
|
* core: merge branch 'th/cancel-get-secrets-bgo776168'Thomas Haller2016-12-206-43/+162
|\ | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=776168
| * ethernet: cancel get-secrets request in ethernet deviceThomas Haller2016-12-201-20/+66
| | | | | | | | Same as for NMDeviceWifi.
| * wifi: cancel get-secrets request in wifi deviceThomas Haller2016-12-201-20/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I got an assertion failure: wifi_secrets_cb: assertion 'nm_device_get_state (device) == NM_DEVICE_STATE_NEED_AUTH' failed with backtrace [1]. I think, we have to keep track of the pending secrets request and cancel it when the device state changes. [1]: #0 0x00007fad615a7a21 _g_log_abort (libglib-2.0.so.0) #1 0x00007fad615a8e2d g_logv (libglib-2.0.so.0) #2 0x00007fad615a8f8f g_log (libglib-2.0.so.0) #3 0x000055e45e3fc718 get_secrets_cb (NetworkManager) #4 0x000055e45e3dfada _get_secrets_info_callback (NetworkManager) #5 0x000055e45e460d8d req_complete_release (NetworkManager) #6 0x000055e45e462a7f _con_get_try_complete_early (NetworkManager) #7 0x000055e45e462cb6 request_start (NetworkManager) #8 0x00007fad6159e8e7 g_idle_dispatch (libglib-2.0.so.0) #9 0x00007fad615a1e42 g_main_dispatch (libglib-2.0.so.0) #10 0x00007fad615a21c0 g_main_context_iterate (libglib-2.0.so.0) #11 0x00007fad615a24e2 g_main_loop_run (libglib-2.0.so.0) #12 0x000055e45e2bf561 main (NetworkManager) #13 0x00007fad60d97401 __libc_start_main (libc.so.6) #14 0x000055e45e2bfc6a _start (NetworkManager)
| * act-request: allow omitting the @self argument in ↵Thomas Haller2016-12-206-6/+37
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | nm_act_request_cancel_secrets() Previously, we would require a @self argument and the @call_id in nm_act_request_cancel_secrets(), although the @call_id already has a pointer to @self. In principle that is not necessary, but it makes the API a bit more robust as you need to care about the lifetime of the @req as well. However it is a bit inconvenient, because it requires that caller to track both the activation request and the call-id. Now, allow nm_act_request_get_secrets() to instruct the call-id to take an additional reference to @self. Later on, we would allow to omit the argument during cancelling. We only allow this, if the call-id takes a reference to @self.
| * act-request: use NULL return value instead of "0"Thomas Haller2016-12-201-1/+1
|/
* build: don't run GIR tools on private headersBeniamino Galvani2016-12-201-1/+0
| | | | | | Fixes the warning: libnm-glib/nm-object-private.h:28: Warning: NMClient: symbol='PropertyMarshalFunc': Unknown namespace for identifier 'PropertyMarshalFunc'
* exported-object: fix memory leakBeniamino Galvani2016-12-201-1/+2
| | | | Fixes: 8c4e824997dec18c5dc7a7dedd4053f51fece8f7
* dns: fix memory leakBeniamino Galvani2016-12-201-2/+3
| | | | Fixes: e3c67177ac7234923f53c51473f77df8a2cb0f20
* dns: remove duplicate declaration of singleton instanceBeniamino Galvani2016-12-201-4/+2
|
* libnm/docs: clarify "ipvx.dns-priority" setting in documentationThomas Haller2016-12-191-5/+9
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1403594
* device: don't try to get carrier detection support when unrealizingBeniamino Galvani2016-12-192-8/+14
| | | | | get_generic_capabilities() is called with a 0 ifindex when unrealizing: don't call nm_platform_link_supports_carrier_detect() is such case.
* build: remove "src/NetworkManager.ver-orig"Thomas Haller2016-12-183-594/+2
| | | | | | Generating "src/NetworkManager.ver" each time seems to work well. Thus, src/NetworkManager.ver-orig is unused an gets easily out of date. Just remove it. It's not useful anymore.
* NEWS: belatedly add news entry for th/preserve-fake-perm-hwaddr-bgo772880Thomas Haller2016-12-161-0/+3
| | | | This was already part of 1.5.2-dev.
* NEWS: add entry about th/sysctl-ifname-race-bgo775613 branchThomas Haller2016-12-161-0/+3
|
* contrib/rpm: fix obsoletes_ppp_plugin versionThomas Haller2016-12-161-1/+3
| | | | | | | The ppp package split was introduced during 1.5.3 development. Thus, we obsolete packages < 1:1.5.3. Also, add conditionals around ppp-devel build-requirement.
* build: always use the right python for generate-settings-docs.pyMichael Catanzaro2016-12-161-0/+1
| | | | | | Fixes: 6070fe697a4ccf9c90817f6d7268ba184fc744ea https://bugzilla.gnome.org/show_bug.cgi?id=775768
* release: bump version to 1.5.3 (development)1.5.3-devLubomir Rintel2016-12-151-1/+1
|
* NEWS: update for a development snapshotLubomir Rintel2016-12-151-1/+22
|
* build: build documentation for o.fd.NM.DnsManagerLubomir Rintel2016-12-153-1/+4
| | | | Fixes: 14105ece56b65fed64bade4013b105f7adaad27b
* contrib/rpm: obsolete the pre-ppp-split version from the main packageLubomir Rintel2016-12-151-1/+2
| | | | | To ensure smooth upgrade path. While at it, move the BR to a more usual place.
* man: replace libnm-util reference with libnm-core in nm-settings pageJiří Klimeš2016-12-151-3/+3
|
* libnm-core: (trivial) fix a typoJiří Klimeš2016-12-151-1/+1
|
* cli: (trivial) fix a typoJiří Klimeš2016-12-151-1/+1
|
* man: add unsupported settings to the list in nm-settings-ifcfg-rh pageJiří Klimeš2016-12-151-1/+1
|
* man/ifcfg-rh: mark some ifcfg-rh variables with (+) as NM extensionsJiří Klimeš2016-12-153-4/+4
|
* cli: enable TAB-completion for connection.lldp in interactive editorJiří Klimeš2016-12-151-1/+4
|
* cli: enable TAB-completion for connection.metered in interactive editorJiří Klimeš2016-12-151-1/+5
|
* cli: add SLAVE field for 'nmcli con show' outputJiří Klimeš2016-12-151-2/+6
| | | | | | It helps listing or searching for slave connections. For example, one can do $ nmcli -f name,uuid,type,slave connection show | awk '$NF == "bridge"' to show all bridge slave connections.
* ifcfg-rh/tests: avoid using g_assert_null() APIFrancesco Giudici2016-12-151-1/+1
| | | | Fixes: 2852b509456d9e8caf6338fdc7d9cff1da76484e
* merge: branch 'lr/ifcfg-device-rh1369008'Lubomir Rintel2016-12-157-82/+164
|\ | | | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1369008
| * ifcfg-rh: write the master device name even if the master property is an UUIDlr/ifcfg-device-rh1369008Lubomir Rintel2016-12-155-26/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | | | We used MASTER, BRIDGE and TEAM_MASTER keys for a differnet purpose than the network.service did, confusing the legacy tooling. Let's do our best to write compatible configuration files: * Add *_UUID properties that won't clash with initscripts * Ignore non-*_UUID keys on read if *_UUID is present * If the connection.master is an UUID of a connection with a connection.interface-name, write the uuid into the *_UUID key while setting the non-*_UUID key to the interface name for compatibility https://bugzilla.redhat.com/show_bug.cgi?id=1369091
| * ifcfg-rh: add test case for remembering the unset valuesLubomir Rintel2016-12-151-0/+1
| | | | | | | | Validates the previous commit.
View Lorry Controller Status