summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* ---wip--- core, platform: handle interface name renaming (rh #1063383)jk/iface-rename-rh1063383Jiří Klimeš2014-02-143-1/+73
| | | | | https://bugzilla.redhat.com/show_bug.cgi?id=1063383 https://bugzilla.redhat.com/show_bug.cgi?id=1063379
* ifcfg-rh: allow missing (empty TEAM_CONFIG), which is valid configurationJiří Klimeš2014-02-142-3/+10
| | | | | | | | | | | | When config is NULL libteam will use its own default configuration. Commit 76c3bd9898611ebbb6b33890257206b5776b79e7 changed that and refused to create 'team' setting making connection invalid. It didn't set an error as well, which resulted in ifcfg-rh: parsing /etc/sysconfig/network-scripts/ifcfg-team ... ifcfg-rh: error: (unknown) GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
* core: don't block startup on assumed connectionsDan Winship2014-02-131-2/+9
| | | | | | | | | | | If we are assuming a connection at startup, the NMManager:startup state doesn't need to wait for that activation to complete, since the underlying device isn't going to change its configuration as a result of it. (In particular, NM considers virbr0 to be stalled at NM_DEVICE_STATE_IP_CONFIG when it assumes it, since if it has no real slaves, it won't yet have carrier. But this shouldn't block startup.)
* tui: fix srcdir != builddir buildJiří Klimeš2014-02-131-0/+1
|
* tui: properly initialize InfiniBand transport-modeJiří Klimeš2014-02-131-0/+6
| | | | | We need to initialize transport-mode because default value is NULL, which is not a valid mode.
* modem-manager: if building systemd support, assume it manages the MM lifecycleAleksander Morgado2014-02-132-27/+47
| | | | | | | We will not explicitly poke MM to start it if NetworkManager is built with systemd support. https://bugzilla.gnome.org/show_bug.cgi?id=703040
* build: improve our use of glib's version macros to catch more bugsDan Winship2014-02-136-7/+52
| | | | | | | | | | | | | | We were setting GLIB_VERSION_MAX_ALLOWED to 2.34, since we provide reimplementations of a few 2.34 functions in nm-glib-compat.h. But this was turning off warnings for the 2.34+ APIs we *didn't* have compat versions of too. Fix this by setting MAX_ALLOWED to 2.32 (same as MIN_REQUIRED), and defining macros to wrap calls to compat-ified functions and disable deprecation warnings around them. This points out several places where we were accidentally using 2.34 APIs without noticing, which need to be fixed now.
* libnm-util, libnm-glib: add versioned deprecation/availability macrosDan Winship2014-02-1350-4/+164
| | | | | | | | | | | | | | | | Add versioned NM_DEPRECATED_IN_* and NM_AVAILABLE_IN_* macros, and tag new/deprecated functions accordingly. (All currently-deprecated functions are assumed to have been deprecated in 0.9.10.) Add NM_VERSION_MIN_REQUIRED and NM_VERSION_MAX_ALLOWED macros which can be set to determine which versions will cause warnings. With the current settings, external consumers of the libnm-util/libnm-glib APIs will have MIN_REQUIRED and MAX_ALLOWED both set to NM_VERSION_0_9_8 by default, meaning they will get warnings about functions added in 0.9.10. NM internally sets NM_VERSION_MAX_ALLOWED to NM_VERSION_NEXT_STABLE to ensure that it is always allowed to use all APIs.
* libnm-util, libnm-glib: add some missing "Since: 0.9.10" tagsDan Winship2014-02-135-0/+40
| | | | | Based on diffing libnm-util.ver and libnm-glib.ver with their 0.9.8 versions.
* trivial: don't open-code g_clear_pointer()Dan Williams2014-02-131-6/+2
|
* libnm-glib: suppress warnings unless LIBNM_GLIB_DEBUG is setDan Williams2014-02-131-41/+36
| | | | | | | | Most of these warnings are things libnm-glib can't do anything about, and they are pretty annoying when running nmcli or nmtui, and libraries usually shouldn't print random warnings anyway. So downgrade them to debug messages that can be enabled if we need to see them.
* trivial: remove unused nm-netlink-monitorDan Williams2014-02-134-683/+0
| | | | Obsoleted by the platform, no longer used.
* core: suppress error message ZONE_ALREADY_SET when adding firewalld zoneThomas Haller2014-02-131-3/+9
| | | | | | | | | | | | | | See also https://bugzilla.redhat.com/show_bug.cgi?id=886432, where firewalld was changed, not to return ZONE_ALREADY_SET for 'changeZone'. However, 'addInterface' can still fail with this error. Suppress the following error lines: <debug> [1392290031.179280] [firewall-manager/nm-firewall-manager.c:117] nm_firewall_manager_add_or_change_zone(): (em1) firewall zone add -> (null) ... <warn> (em1) firewall zone add/change failed: (32) ZONE_ALREADY_SET Signed-off-by: Thomas Haller <thaller@redhat.com>
* cli: show warning when setting band/channel for infra mode (rh #1000096)Thomas Haller2014-02-133-4/+60
| | | | | | | | | | | | | | The band/channel property is not considered when connecting to an access point. Print a warning, when setting one of these values in edit mode. For now, don't forbid the user to make such setting. Also, because in the future, wpa_supplicant might support this. https://bugzilla.redhat.com/show_bug.cgi?id=999997 https://bugzilla.redhat.com/show_bug.cgi?id=1000096 Signed-off-by: Thomas Haller <thaller@redhat.com>
* core: fix hanging set_logging() dbus call by returning a resultThomas Haller2014-02-121-2/+4
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* cli: fix crash if active connection doesn't have a device (rh #1064333)Jiří Klimeš2014-02-121-7/+13
| | | | | | | | | | $ nmcli dev connect wlan0 This can happen for example when some other process disconnects the connection being connected. Also fix printing a message on success. https://bugzilla.redhat.com/show_bug.cgi?id=1064333
* trivial: fix a typo in a commentJiří Klimeš2014-02-101-1/+1
|
* trivial: fix whitespace and spelling errorThomas Haller2014-02-102-5/+5
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* wifi: do not print dump inconsistency error for get scan commandStanislaw Gruszka2014-02-101-0/+9
| | | | | | | | Avoid printing "nl_recvmsgs() error: (-33) Dump inconsistency detected, interrupted". DUMP_INTR error is harmless for scan (see in code comments). Signed-off-by: Thomas Haller <thaller@redhat.com>
* core: normalize object paths on add_and_activate_connectionStanislaw Gruszka2014-02-101-0/+6
| | | | | | Without this patch I can not setup new hotspot connection. Signed-off-by: Thomas Haller <thaller@redhat.com>
* po: update Assamese (as) translation (bgo #723751)Nilamdyuti Goswami2014-02-061-462/+582
| | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=723751 Signed-off-by: Thomas Haller <thaller@redhat.com>
* build: include the git commit id of HEAD in ./configureThomas Haller2014-02-051-0/+2
| | | | | | | `make dist` packs the 'configure' file in the tarball, so this is useful, to include the commit id into the release tarball. Signed-off-by: Thomas Haller <thaller@redhat.com>
* po: update Gujarati (gu) translation (bgo #723527)Ankitkumar Patel2014-02-041-1409/+4440
| | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=723527 Co-Authored-By: Sweta Kothari <swkothar@redhat.com> Signed-off-by: Thomas Haller <thaller@redhat.com>
* build: drop the libndp submoduleDan Winship2014-02-035-38/+3
| | | | | libndp has existed for a while now. 1.0 was released six months ago. So drop the submodule and just require an installed package.
* man: NetworkManager.conf.5 fixes and updatesDan Winship2014-02-031-48/+86
| | | | | | | | | | | | | | | | | | | The [main] section is not mandatory. Clarify in several places that the keyfile plugin is always used for fallback, and that the [keyfile] section is normally only used if you aren't using any other plugin. Fix some erroneous references to "keyfile" and "ifdown" in the ifupdown section. Update the ifcfg-rh docs to list all currently-supported connection types. Swap the order of ifcfg-suse and ifupdown to make them alphabetical. (Note that ifnet is currently missing.) https://bugzilla.gnome.org/show_bug.cgi?id=720841
* libnm-glib: zero 'secrets' to prevent crash getting secretsDan Williams2014-01-311-1/+1
| | | | | | If the GetSecrets call returned an error (eg, no secrets) then 'secrets' isn't set by dbus_g_proxy_end_call() and is garbage, then gets freed.
* wifi: indicate to the kernel when critical protocols start/stop (bgo #723241)Dan Williams2014-01-311-0/+62
| | | | | | | Add support for the kernel's Wi-Fi critical protocol indication to make DHCP and IPv6 SLAAC more reliable. https://bugzilla.gnome.org/show_bug.cgi?id=723241
* wifi: add nl80211 Critical Protocol indication supportDan Williams2014-01-315-0/+66
| | | | | | | | | | At critical times during the connection process, especially during DHCP and EAPOL, the driver can increase the reliability of communication in an attempt to increase the possibility of success. This could be done by suppressing bluetooth for a short period, or locking in a low (and thus more reliable) bitrate, or enforcing some other interference protection. The 3.10 kernel added nl80211 support for this, so lets use it if we can.
* trivial: fix a coverity warningDan Winship2014-01-311-2/+2
| | | | | "reserved" is unsigned, so CLAMP(reserved, 0, 8) does an unnecessary check.
* core/platform: fix wrong warning log in nm-linux-platformThomas Haller2014-01-311-1/+1
| | | | | | | | | According to documentation, nl_rtgen_request() returns 0 on success. Due to a bug (fixed upstream) in older libnl versions, nl_rtgen_request() returns the number of bytes sent, which caused logging although succeeding. Signed-off-by: Thomas Haller <thaller@redhat.com>
* core: ensure proper handling of sysctl paths in NMDevice (set NULL on dispose)Thomas Haller2014-01-311-6/+9
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* po: update Kannada (kn) translation (bgo #723361)Shankar Prasad2014-01-311-1372/+4058
| | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=723361 Signed-off-by: Thomas Haller <thaller@redhat.com>
* core: minor change of logging output about monotonic_timestampThomas Haller2014-01-311-3/+3
| | | | | | | Make it more clear, what the current monotonic_timestamp is and what's it's offset to CLOCK_BOOTTIME. Signed-off-by: Thomas Haller <thaller@redhat.com>
* core/platform: add debug logging when adding/deleting addressesThomas Haller2014-01-301-4/+28
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* core: Merge branch 'th/get_monotonic_timestamp'Thomas Haller2014-01-3019-106/+173
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add new functions nm_utils_get_monotonic_timestamp_*() to provide means to get timestamps for calculating durations. At several places, we used time() or clock_gettime() for that purpose. Update and unify those places to make use of the new functions. The new functions have the advantage, that the timestamps are guaranteed to be positive and the timestamp is independent of clock adjustments. Internally it uses CLOCK_BOOTTIME/clock_gettime. https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: use nm_utils_get_monotonic_timestamp_s for nm-device-ethernet.c ↵Thomas Haller2014-01-301-5/+5
| | | | | | | | | | | | | | | | (last_pppoe_time) https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: use nm_utils_get_monotonic_timestamp_s for autoconnect_retry_timeThomas Haller2014-01-303-8/+8
| | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: use nm_utils_get_monotonic_timestamp_ms for nm-netlink-monitorThomas Haller2014-01-301-4/+5
| | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: use nm_utils_get_monotonic_timestamp_s for nm_ap_set_last_seenThomas Haller2014-01-303-10/+14
| | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: use nm_utils_get_monotonic_timestamp_s in nm-device-wifi ↵Thomas Haller2014-01-301-2/+2
| | | | | | | | | | | | | | | | (scheduled_scan_time) https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: use nm_utils_get_monotonic_timestamp_s in nm-supplicant-interfaceThomas Haller2014-01-303-10/+11
| | | | | | | | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: use nm_utils_get_monotonic_timestamp_s for timestamp of ↵Thomas Haller2014-01-307-67/+38
| | | | | | | | | | | | | | | | NMPlatformIP[46]Address https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: add nm_utils_get_monotonic_timestamp_* functionsThomas Haller2014-01-302-0/+90
|/ | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=720833 Signed-off-by: Thomas Haller <thaller@redhat.com>
* core/dhcp: fix dispose() of NMDHCPClient to handle multiple invocationsThomas Haller2014-01-301-5/+15
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* tui: properly initialize the IP4 and IP6 settings on new connectionsDan Winship2014-01-302-0/+6
| | | | We need to initialize the methods.
* tui: fix a crash when creating a new connectionDan Winship2014-01-304-8/+8
| | | | | | | | Make all the signals RUN_FIRST instead of RUN_LAST. In particular, this fixes a crash when creating a new connection and activating the listbox directly, in which case nmt_newt_listbox_activated() was running after NmtAddConnection:create_connection() had already quit the form and unrealized the listbox.
* ifcfg-rh: write SLAVE=yes on bond slave connectionsDan Winship2014-01-302-2/+7
| | | | For compatibility with the old network scripts.
* core: Merge branch 'th/ipv6-privacy'Thomas Haller2014-01-3010-31/+268
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This branch fixes two things: - autoconf addresses were added with a /128 prefix, instead of the announced /64. This was done on purpose, to stop the kernel from adding a prefix route for the whole /64 net (in case, where RA has onlink=0). NM adds these routes himself. - temporary addresses (ipv6-privacy, rfc4941) did not work at all ever since NM is doing router discouvery in user space. Both features need help from kernel and libnl. If those versions do not support the new address flags (IFA_F_MANAGETEMPADDR and IFA_F_NOPREFIXROUTE), NM will log a message behave as before: adding /128 autoconf addresses and not private addresses. autoconf addresses as /64: https://bugzilla.redhat.com/show_bug.cgi?id=1044590 https://bugzilla.redhat.com/show_bug.cgi?id=1045118 ipv6-privacy: https://bugzilla.gnome.org/show_bug.cgi?id=705170 https://bugzilla.redhat.com/show_bug.cgi?id=1003859 https://bugzilla.redhat.com/show_bug.cgi?id=1047139 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core/rdisc: add support for IPv6 privacyThomas Haller2014-01-301-28/+96
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add support for ipv6-private addresses. This feature needs support from the kernel and libnl. If there is no system support, temporary addresses are not supported. Log a warning in this case. Depending on whether ipv6-privacy (use_tempaddr) is enabled, we add the address flag IFA_F_MANAGETEMPADDR and the kernel will add temporary addresses for us. https://bugzilla.gnome.org/show_bug.cgi?id=705170 https://bugzilla.redhat.com/show_bug.cgi?id=1003859 https://bugzilla.redhat.com/show_bug.cgi?id=1047139 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core/rdisc: add autoconf addresses as /64 (instead of /128)Thomas Haller2014-01-301-1/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | This feature needs support from the kernel and libnl. If there is no system support, NM acts as before, adding the autoconf address as /128. It does so, to prevent the kernel from adding a route for this prefix. With system support, we add the address as /64 and set the flag IFA_F_NOPREFIXROUTE. https://bugzilla.redhat.com/show_bug.cgi?id=1044590 https://bugzilla.redhat.com/show_bug.cgi?id=1045118 Signed-off-by: Thomas Haller <thaller@redhat.com>
View Lorry Controller Status