summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* keyfile: fix warning when list delimiter is at end of linedcbw/slave-fixesDan Williams2014-03-271-0/+3
| | | | | | | | | Given a field like "1.2.3.4/24," read_field() would return a zero-length string to the caller, which could then pass that string back to read_field() if it expected more input. read_field() assumes that that this input is non-zero in length and prints a warning: CRITICAL **: read_field: assertion '**current' failed
* keyfile: add tests and examples for master/slaveDan Williams2014-03-274-6/+106
|
* libnm-util: if one of slave-type and master is set, both must be setDan Williams2014-03-261-0/+15
| | | | | | | | | | slave-type is required because master may refer to an interface that is not yet created, and thus the details of the slave connection are ambiguous. While we can auto-detect slave-type in some cases (like if a bridge-port setting exists, then slave-type=bridge), that functionality isn't implemented yet and doesn't work for all cases. So for the moment, require that both slave-type and master are set if one is set.
* platform: fix handling of labelsDan Winship2014-03-261-1/+2
| | | | | If an address has a label without a ':' in it (eg, its label is just $DEVICE, not $DEVICE:$NUM), then ignore it.
* devices: if a generated connection doesn't verify, log whyDan Winship2014-03-261-1/+8
|
* ifcfg-rh: add support for ifcfg alias files (rh #1067170)Dan Winship2014-03-2630-78/+1298
|\
| * keyfile: ignore ipv4.address-labelsDan Winship2014-03-261-0/+14
| | | | | | | | For now they are only supported by ifcfg-rh
| * ifcfg-rh: add support for reading and writing ifcfg alias filesDan Winship2014-03-2614-50/+841
| |
| * core: handle IPv4 address labelsDan Winship2014-03-261-2/+8
| | | | | | | | | | Handle address labels when applying or capturing an NMSettingIP4Config.
| * platform: support address labels for IPv4 addressesDan Winship2014-03-267-19/+54
| |
| * libnm-util: add (private API) support for address labels to NMSettingIP4ConfigDan Winship2014-03-265-7/+283
| |
| * libnm-util: add nm-util-private.h header with nm_util_get_private()Dan Winship2014-03-264-0/+98
|/
* dcb: fix testcases for disabling DCB with short-format commandDan Williams2014-03-261-5/+5
| | | | Late-fixup for review comments and I didn't run 'make check'. Bad me.
* wifi: fixup for "wifi: support locking connections to a band (5GHz or 2GHz) ↵Dan Williams2014-03-261-0/+1
| | | | | | (bgo #627571)" The new freq_list option must pass configuration verification.
* dcb: workarounds for lldpad/drivers and some bug fixes (rh #799241)Dan Williams2014-03-252-48/+97
|\
| * dcb: turn off all DCB features when disabling DCBDan Williams2014-03-252-3/+27
| | | | | | | | Don't just disable DCB, but turn off the features too.
| * dcb: ignore fcoeadm success errors like "Connection already created"Dan Williams2014-03-251-5/+13
| | | | | | | | | | | | | | | | | | | | | | | | $ /usr/sbin/fcoeadm -m fabric -c enp3s0f0 fcoeadm: Connection already created on interface enp3s0f0 Try 'fcoeadm --help' for more information. $ echo $? 3 $ Also now log error output of failed commands instead of only when debug logging is enabled.
| * dcb: clean up FCoE tooDan Williams2014-03-251-1/+9
| |
| * dcb: fix memory leakDan Williams2014-03-251-0/+1
| |
| * dcb: set all Priority Group options at the same time (rh #799241)Dan Williams2014-03-252-39/+47
|/ | | | | | | | | | | | | | | | First, lldpad doesn't support disabling priority groups (e:0) without specifying a complete priority group config (which wouldn't be used anyway, since you're turning it off!). While this bug is being fixed upstream, we'll just ignore errors turning off PG, since if you're using DCB on an interface, you probably want to use it all the time. Second, lldpad really wants all PG options on the same configuration line, not split apart, because it validates the complete package of options before applying them, regardless of whether or not they are given in the same command. Since NM was just emitting all the options in separate dcbtool invocations anyway, just combine them all into a single invocation.
* wifi: support locking connections to a band (5GHz or 2GHz) (bgo #627571)Dan Williams2014-03-251-2/+24
| | | | https://bugzilla.gnome.org/show_bug.cgi?id=627571
* tui: allow cancelling "nmtui connect", make ^Z work (rh #1080059)Dan Winship2014-03-255-18/+86
|\
| * tui: allow ^Z to suspend the appDan Winship2014-03-241-0/+10
| | | | | | | | | | | | This way if we end up with bugs that make it otherwise impossible to kill nmtui, you can at least ^Z and then kill it from the command line.
| * tui: allow Esc to cancel "nmtui connect"Dan Winship2014-03-241-16/+57
| |
| * tui: add nmt_newt_widget_get_realized(), realize forms properlyDan Winship2014-03-243-2/+19
|/ | | | | | NmtNewtForm is an NmtNewtWidget, but previously it was only realizing its child, not itself, which is technically wrong (though it had no noticeable effect until get_realized() was added).
* wwan: disconnect modem signals when disposing NMDeviceModemDan Williams2014-03-211-5/+6
|
* tui: add some comments to nmt-newt-form.cDan Winship2014-03-211-1/+20
|
* tui: fix using Escape from main menuDan Winship2014-03-211-3/+4
| | | | | We weren't checking whether the form closed because the menu was activated or because the user hit Escape
* tui: fix crashes in nmtui-connect (rh #1078281)Jiří Klimeš2014-03-211-4/+5
| | | | https://bugzilla.redhat.com/show_bug.cgi?id=1078281
* tui: fix binding of some int/uint properties (rh #1078281)Dan Winship2014-03-213-0/+41
| | | | | | | | | | GLib registers number->string value transforms (meaning that number-valued properties like NMSettingVlan:id or NMSettingWired:mtu get loaded into their NmtNewtEntries correctly), but not the corresponding string->number transforms (meaning changes made in the entries don't get propagated back to the settings, and due to http://bugzilla.gnome.org/show_bug.cgi?id=726574, there's no warning about this). Fix this by registering our own transforms.
* tui: fix quitting from "nmtui edit CONN-ID"Dan Winship2014-03-217-41/+40
| | | | | | | | | | | If you launched nmtui directly into the editor for a specific connection, it would hang with a blank screen when you quit. Fix this by changing the way startup works a bit, and have the created toplevel NmtNewtForm get returned all the way to nmtui.c, which can then connect to the "quit" signal on it and quit (rather than having the different subprograms trying to guess whether they're supposed to quit-on-exit or not).
* tui: fix selection bugs after deleting a connectionDan Winship2014-03-212-10/+32
| | | | | | | | | | | | | | | | | | nmt_newt_listbox_clear() did not reset active and active_key, which in the case of NmtEditConnectionList meant that after the connection list was rebuilt, the selection would appear to be in the same place, but active_key would still point to the connection that used to be in that row, rather than the one currently in that row, so if you immediately hit Edit or Delete, you'd get unexpected results. (It also meant that it was possible for the selection to land on a header row instead of a connection row.) This was particularly bad in the case of the Delete button, since active_key would be left pointing to a freed NMConnection in that case. Fix NmtNewtListbox, and then add code to NmtEditConnectionList to preserve the selection itself when rebuilding the list.
* devices: send ARPs when configuring static IPv4 addresses (rh #1073447)Dan Winship2014-03-211-1/+99
| | | | | | After applying a configuration with static IPv4 addresses, call /sbin/arping to announce the new addresses to the host's neighbors. (Basic idea copied from Fedora ifup-eth.)
* core: improve ifname matching of existing x generated connections (rh #1077743)Jiří Klimeš2014-03-213-0/+68
| | | | | | | | | | | | | | | | | | | | | | DEVICE="ens3" ONBOOT=yes NETBOOT=yes UUID="23466771-f5fa-4ca9-856f-eaf4a8e20c3f" BOOTPROTO=none IPADDR="10.0.0.2" PREFIX="24" GATEWAY="10.0.0.1" HWADDR="52:54:00:12:34:56" TYPE=Ethernet NAME="ens3" This ifcfg file results in connection.interface-name=ens3. However, device-generated connection didn't set interface-name property. Fix that by setting interface-name property when generating a connection. Also allow matching connections if interface-name is not set in a connection. https://bugzilla.redhat.com/show_bug.cgi?id=1077743
* core: export ActiveConnection before handing it to the device (bgo #723783)Dan Williams2014-03-202-8/+19
| | | | | | | | | | | | | | | | | | The AC doesn't get a D-Bus path until it's exported, but that happens after it's handed to the Device it will be activated on. The Device emits a PropertyChanged event when it's handed the AC, but it ignores ACs that aren't exported yet. Thus when activating, the Device doesn't emit the AC's path at all in the ActiveConnection property because it's NULL. Fix that by exporting the AC immediately before starting activation with it. Second, move the notification of the Device.ActiveConnection property to be emitted along with the state change to PREPARE instead of long before it. While we don't guarantee signal ordering in general, this seems like a more correct ordering. https://bugzilla.gnome.org/show_bug.cgi?id=723783
* core: warn if multiple plugins for the same type are installedDan Winship2014-03-191-2/+9
| | | | | | If we find multiple plugins for the same type (eg, because the user previously installed the "atm" and "bt" plugins, and didn't delete them), log a warning.
* devices: rename "atm" plugin to "adsl", and "bt" to "bluetooth"Dan Winship2014-03-199-11/+11
| | | | | | | | | The atm/adsl plugin really is a generic ATM plugin but (a) it needs a bit of work to do IPoATM rather than just PPPoATM and PPPoEoATM, and (b) most people currently using NM's ATM support are using DSL devices not actual ATM cards anyway, and have no idea what "ATM" even means. If we add the necessary IPoATM support later we can rename the plugin back to -atm
* core: emit PropertyChanged signal for ActiveConnection when disconnectingDan Williams2014-03-181-0/+1
|
* devices: change log message when "deactivating" device on startupDan Winship2014-03-181-9/+14
| | | | | | | nm_device_deactivate() is used when deactivating a device, but also when initializing it when it is first managed. Rename it to nm_device_cleanup(), and use a different log message ("preparing device") in the NM_DEVICE_STATE_REASON_NOW_MANAGED case.
* po: fix syntax errors in Hindi (hi) and Tamil (ta) translations (bgo #726554)Piotr Drąg2014-03-172-5/+5
| | | | | | https://bugzilla.gnome.org/show_bug.cgi?id=726554 Signed-off-by: Thomas Haller <thaller@redhat.com>
* core: add debug logging when setting IP[46]Config instance of a NMDeviceThomas Haller2014-03-171-0/+6
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* core: fix auto-activation of ignore-carrier devices when carrier appears (rh ↵Dan Williams2014-03-171-0/+7
| | | | | | | | | | | | | #1076592) If a device had its carrier ignored, and did not have a carrier on startup, then NetworkManager would not re-check autoconnect connections when the device's carrier appeared. Because ignore-carrier devices are always in DISCONNECTED state when they are managed, the nm-device.c::carrier_changed() code essentially did nothing when the carrier appeared. It needs to also trigger an auto-activation recheck signal when the carrier appears to ensure that now-valid connections (like those that require DHCP or IPv6) can be auto-activated.
* cli: fix bridge priority default value (rh #1073664)Jiří Klimeš2014-03-171-2/+2
| | | | | | It is 32768 (0x8000) instead of 128 (0x80). 13c348d fixes that in the setting. https://bugzilla.redhat.com/show_bug.cgi?id=1073664
* trivial: fix a typo in a commentJiří Klimeš2014-03-171-1/+1
|
* platform: fix crash if link has no name after 5e935dfdDan Williams2014-03-141-0/+1
| | | | | | | | | | | | | | | | When a VPN goes down, like at suspend, and the link has already disappeared, the new platform logging code tries to print the link information using a link object with only the ifindex filled in. When adding/removing/changing links, internal code often fills in just the ifindex (becuase that's all you need). Thus to_string_link() will always fail if that operation fails. at platform/nm-linux-platform.c:688 at platform/nm-linux-platform.c:1835 at vpn-manager/nm-vpn-connection.c:274 Work around that for now and live with the warnings until we decide what to actually do about to_string_link().
* libnm-util: fix Bridge priority default (rh #1073664)Dan Williams2014-03-141-1/+1
| | | | | Due to a misread of the kernel code, the bridge priority default when STP was enabled was 0x80 instead of 0x8000.
* trivial: fix invalid code commentThomas Haller2014-03-141-1/+1
| | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
* libnm-util: remove assert to nm_utils_ip4_netmask_to_prefixThomas Haller2014-03-142-10/+0
| | | | | | | | | | | | | | | | | | | Commit 240c92ddb55c3ae61fa7c4768088eb44b3905a82 added an assert to check that the input netmask is valid. Revert that commit for the most part, some changes to the test function are not reverted. We don't want to assert for a valid netmask, because it's common to read the netmask from (untrusted) user input, so we don't want to assert against it. The caller *could* validate the netmask from untrusted sources, but with the assert in place it cannot validate it in the most obvious way: prefix = nm_utils_ip4_netmask_to_prefix (netmask); if (netmask != nm_utils_ip4_prefix_to_netmask (prefix)) goto fail; Signed-off-by: Thomas Haller <thaller@redhat.com>
* platform: merge branch 'th/platform_link_logging'Thomas Haller2014-03-134-53/+275
|\ | | | | | | | | | | | | | | Add to_string() functions and some refactoring. https://bugzilla.gnome.org/show_bug.cgi?id=725612 Signed-off-by: Thomas Haller <thaller@redhat.com>
| * core: add debug logging for link disconnect actionThomas Haller2014-03-131-8/+20
| | | | | | | | Signed-off-by: Thomas Haller <thaller@redhat.com>
View Lorry Controller Status