summaryrefslogtreecommitdiff
path: root/libnm/tests/test-nm-client.c
diff options
context:
space:
mode:
Diffstat (limited to 'libnm/tests/test-nm-client.c')
-rw-r--r--libnm/tests/test-nm-client.c11
1 files changed, 6 insertions, 5 deletions
diff --git a/libnm/tests/test-nm-client.c b/libnm/tests/test-nm-client.c
index 9e9d480eaf..107cc58871 100644
--- a/libnm/tests/test-nm-client.c
+++ b/libnm/tests/test-nm-client.c
@@ -1002,9 +1002,8 @@ client_devices_changed_cb (GObject *client,
g_assert_cmpstr (nm_device_get_iface (device), ==, "eth0.1");
- if (nm_device_get_active_connection (device))
- info->remaining--;
- else {
+ if (!nm_device_get_active_connection (device)) {
+ info->remaining++;
g_signal_connect (device, "notify::" NM_DEVICE_ACTIVE_CONNECTION,
G_CALLBACK (device_ac_changed_cb), info);
}
@@ -1094,8 +1093,10 @@ test_activate_virtual (void)
g_signal_connect (client, "notify::" NM_CLIENT_DEVICES,
G_CALLBACK (client_devices_changed_cb), &info);
- /* As with test_active_connections() above, except that now we're waiting
- * for NMClient:devices to change rather than NMDevice:active-connections.
+ /* We're expecting a client::devices change, client::activate callback,
+ * and a device::active-connection change.
+ * The client::devices callback can hook a client::active-connections
+ * change and bump this if the property is not yet loaded.
*/
info.remaining = 3;