summaryrefslogtreecommitdiff
path: root/libnm-core/tests
diff options
context:
space:
mode:
Diffstat (limited to 'libnm-core/tests')
-rw-r--r--libnm-core/tests/test-general.c5
-rw-r--r--libnm-core/tests/test-keyfile.c16
2 files changed, 18 insertions, 3 deletions
diff --git a/libnm-core/tests/test-general.c b/libnm-core/tests/test-general.c
index 52c6f80911..414c6659b3 100644
--- a/libnm-core/tests/test-general.c
+++ b/libnm-core/tests/test-general.c
@@ -3900,6 +3900,7 @@ test_connection_normalize_gateway_never_default (void)
nm_connection_add_setting (con, (NMSetting *) s_ip4);
nm_connection_add_setting (con, (NMSetting *) s_ip6);
+ nm_connection_add_setting (con, nm_setting_proxy_new ());
nmtst_assert_connection_verifies_without_normalization (con);
g_assert_cmpstr ("1.1.1.254", ==, nm_setting_ip_config_get_gateway (s_ip4));
@@ -3942,7 +3943,7 @@ test_connection_normalize_may_fail (void)
nm_connection_add_setting (con, (NMSetting *) s_ip4);
nm_connection_add_setting (con, (NMSetting *) s_ip6);
- nmtst_assert_connection_verifies_without_normalization (con);
+ nmtst_assert_connection_verifies_and_normalizable (con);
/* Now set method=disabled/ignore and check that may-fail becomes TRUE
* after normalization
@@ -3989,7 +3990,7 @@ test_connection_normalize_shared_addresses (void)
nm_connection_add_setting (con, (NMSetting *) s_ip4);
nm_connection_add_setting (con, (NMSetting *) s_ip6);
- nmtst_assert_connection_verifies_without_normalization (con);
+ nmtst_assert_connection_verifies_and_normalizable (con);
/* Now we add other addresses and check that they are
* removed during normalization
diff --git a/libnm-core/tests/test-keyfile.c b/libnm-core/tests/test-keyfile.c
index 84dcffbb9f..9944eb5ef8 100644
--- a/libnm-core/tests/test-keyfile.c
+++ b/libnm-core/tests/test-keyfile.c
@@ -28,6 +28,7 @@
#include "nm-setting-wired.h"
#include "nm-setting-8021x.h"
#include "nm-setting-team.h"
+#include "nm-setting-proxy.h"
#include "nm-utils/nm-test-utils.h"
@@ -115,8 +116,21 @@ _nm_keyfile_read (GKeyFile *keyfile,
if (needs_normalization) {
nmtst_assert_connection_verifies_after_normalization (con, 0, 0);
nmtst_connection_normalize (con);
- } else
+ } else {
+ {
+ NMSettingConnection *s_con;
+
+ /* a non-slave connection must have a proxy setting, but
+ * keyfile reader does not add that (unless a [proxy] section
+ * is present. */
+ s_con = nm_connection_get_setting_connection (con);
+ if ( s_con
+ && !nm_setting_connection_get_master (s_con)
+ && !nm_connection_get_setting_proxy (con))
+ nm_connection_add_setting (con, nm_setting_proxy_new ());
+ }
nmtst_assert_connection_verifies_without_normalization (con);
+ }
return con;
}