summaryrefslogtreecommitdiff
path: root/tools/test-networkmanager-service.py
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2019-11-03 22:26:04 +0100
committerThomas Haller <thaller@redhat.com>2019-11-07 11:34:36 +0100
commit6bf206eb810f3f72115e2194f615fce88fb3b0f2 (patch)
treee26b237ffed6d0529dc9d90a2039bfc53bb6f126 /tools/test-networkmanager-service.py
parentfeea4222eff1be4576b959f168fd800d0cf3e317 (diff)
downloadNetworkManager-6bf206eb810f3f72115e2194f615fce88fb3b0f2.tar.gz
libnm/tests: drop test_activate_failed() test
With this test the stub service simulates a failure to add-and-activate the connection. However the implementation of the stub service was not simulating the real behavior of NetworkManager service. libnm will add the possibility to assert against invalid server behavior by setting LIBNM_CLIENT_DEBUG=error. With that change, libnm will complain that the stub service behaves invalid, and rightly so. Instead of fixing the test, just drop it.
Diffstat (limited to 'tools/test-networkmanager-service.py')
-rwxr-xr-xtools/test-networkmanager-service.py8
1 files changed, 0 insertions, 8 deletions
diff --git a/tools/test-networkmanager-service.py b/tools/test-networkmanager-service.py
index e91b45233e..1a8e2e6af5 100755
--- a/tools/test-networkmanager-service.py
+++ b/tools/test-networkmanager-service.py
@@ -1306,14 +1306,6 @@ class NetworkManager(ExportedObj):
ac = ActiveConnection(device, con_inst, None)
self.active_connection_add(ac)
-
- if NmUtil.con_hash_get_id(con_hash) == 'object-creation-failed-test':
- # FIXME: this is not the right test, to delete the active-connection
- # before returning it. It's the wrong order of what NetworkManager
- # would do.
- self.active_connection_remove(ac)
- return ExportedObj.to_path(ac)
-
return ExportedObj.to_path(ac)
def active_connection_add(self, ac):