diff options
| author | Thomas Haller <thaller@redhat.com> | 2019-08-01 10:52:20 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2019-08-08 12:03:15 +0200 |
| commit | 4e36521d4c82b2967628def8125a83ecd13bfd8c (patch) | |
| tree | f7817027ebcbaab8f24283bbe98bae7799c9bd55 /src/settings/plugins/keyfile/tests/test-keyfile-settings.c | |
| parent | b216abb012b97a7e0e50b969e4a04c8b11a4cbe9 (diff) | |
| download | NetworkManager-th/settings-improvements.tar.gz | |
settings: return errno from nms_keyfile_nmmeta_write() for better loggingth/settings-improvements
I encountered a failure in the log
<trace> [1564647990.7822] keyfile: commit: deleting nmmeta file "/etc/NetworkManager/system-connections/35370b0b-e53b-42ea-9fe3-f1b1d552343b.nmmeta" failed
<trace> [1564647990.7822] keyfile: commit: deleting nmmeta file "/etc/NetworkManager/system-connections/35370b0b-e53b-42ea-9fe3-f1b1d552343b.nmmeta" simulated
I think that was due to SELinux (rh #1738010).
Let nms_keyfile_nmmeta_write() return an errno code so we can log
more information about the failure.
Diffstat (limited to 'src/settings/plugins/keyfile/tests/test-keyfile-settings.c')
| -rw-r--r-- | src/settings/plugins/keyfile/tests/test-keyfile-settings.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/settings/plugins/keyfile/tests/test-keyfile-settings.c b/src/settings/plugins/keyfile/tests/test-keyfile-settings.c index f96111a2e4..32f4fc4f8d 100644 --- a/src/settings/plugins/keyfile/tests/test-keyfile-settings.c +++ b/src/settings/plugins/keyfile/tests/test-keyfile-settings.c @@ -2543,7 +2543,7 @@ _assert_keyfile_nmmeta (const char *dirname, nm_clear_g_free (&full_filename); - g_assert (nms_keyfile_nmmeta_write (dirname, uuid, loaded_path, allow_relative, NULL, &full_filename)); + g_assert_cmpint (nms_keyfile_nmmeta_write (dirname, uuid, loaded_path, allow_relative, NULL, &full_filename), ==, 0); g_assert_cmpstr (full_filename, ==, exp_full_filename); nm_clear_g_free (&full_filename); |