diff options
| author | Dan Winship <danw@gnome.org> | 2014-04-08 12:02:28 -0400 |
|---|---|---|
| committer | Dan Winship <danw@gnome.org> | 2014-06-20 11:28:22 -0400 |
| commit | 2d3b8f735731abf6dcbad1714e126c2ce8fc418a (patch) | |
| tree | 4a65adb6a5e661d5adebb24c23cf5f01b283274d /src/nm-activation-request.c | |
| parent | a4b689096e1a9f85bb69073e0241d005025fd7b1 (diff) | |
| download | NetworkManager-danw/wip/gerror.tar.gz | |
all: don't include error->code in log messagesdanw/wip/gerror
GError codes are only unique per domain, so logging the code without
also indicating the domain is not helpful. And anyway, if the error
messages are not distinctive enough to tell the whole story then we
should fix the error messages.
Diffstat (limited to 'src/nm-activation-request.c')
| -rw-r--r-- | src/nm-activation-request.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/nm-activation-request.c b/src/nm-activation-request.c index 11927afae8..18d7d3c4b8 100644 --- a/src/nm-activation-request.c +++ b/src/nm-activation-request.c @@ -245,8 +245,8 @@ nm_act_request_set_shared (NMActRequest *req, gboolean shared) nm_log_info (LOGD_SHARING, "Executing: %s", cmd); if (!g_spawn_sync ("/", argv, envp, G_SPAWN_STDOUT_TO_DEV_NULL | G_SPAWN_STDERR_TO_DEV_NULL, share_child_setup, NULL, NULL, NULL, &status, &error)) { - nm_log_warn (LOGD_SHARING, "Error executing command: (%d) %s", - error->code, error->message); + nm_log_warn (LOGD_SHARING, "Error executing command: %s", + error->message); g_clear_error (&error); } else if (WEXITSTATUS (status)) { nm_log_warn (LOGD_SHARING, "** Command returned exit status %d.", |