diff options
author | Thomas Haller <thaller@redhat.com> | 2018-07-11 07:40:19 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2018-07-11 12:02:06 +0200 |
commit | e1c7a2b5d0b142a3d4347ec6f1934f53c4b402a9 (patch) | |
tree | f61f41729ed8844d566eb68c69d9550a07564215 /libnm-core/nm-setting-team-port.h | |
parent | 7e98b4cad2ff9934d8b5855b291c2baaa7543801 (diff) | |
download | NetworkManager-e1c7a2b5d0b142a3d4347ec6f1934f53c4b402a9.tar.gz |
all: don't use gchar/gshort/gint/glong but C types
We commonly don't use the glib typedefs for char/short/int/long,
but their C types directly.
$ git grep '\<g\(char\|short\|int\|long\|float\|double\)\>' | wc -l
587
$ git grep '\<\(char\|short\|int\|long\|float\|double\)\>' | wc -l
21114
One could argue that using the glib typedefs is preferable in
public API (of our glib based libnm library) or where it clearly
is related to glib, like during
g_object_set (obj, PROPERTY, (gint) value, NULL);
However, that argument does not seem strong, because in practice we don't
follow that argument today, and seldomly use the glib typedefs.
Also, the style guide for this would be hard to formalize, because
"using them where clearly related to a glib" is a very loose suggestion.
Also note that glib typedefs will always just be typedefs of the
underlying C types. There is no danger of glib changing the meaning
of these typedefs (because that would be a major API break of glib).
A simple style guide is instead: don't use these typedefs.
No manual actions, I only ran the bash script:
FILES=($(git ls-files '*.[hc]'))
sed -i \
-e 's/\<g\(char\|short\|int\|long\|float\|double\)\>\( [^ ]\)/\1\2/g' \
-e 's/\<g\(char\|short\|int\|long\|float\|double\)\> /\1 /g' \
-e 's/\<g\(char\|short\|int\|long\|float\|double\)\>/\1/g' \
"${FILES[@]}"
Diffstat (limited to 'libnm-core/nm-setting-team-port.h')
-rw-r--r-- | libnm-core/nm-setting-team-port.h | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/libnm-core/nm-setting-team-port.h b/libnm-core/nm-setting-team-port.h index 4ecb183847..57611750b3 100644 --- a/libnm-core/nm-setting-team-port.h +++ b/libnm-core/nm-setting-team-port.h @@ -72,15 +72,15 @@ NMSetting * nm_setting_team_port_new (void); const char * nm_setting_team_port_get_config (NMSettingTeamPort *setting); NM_AVAILABLE_IN_1_12 -gint nm_setting_team_port_get_queue_id (NMSettingTeamPort *setting); +int nm_setting_team_port_get_queue_id (NMSettingTeamPort *setting); NM_AVAILABLE_IN_1_12 -gint nm_setting_team_port_get_prio (NMSettingTeamPort *setting); +int nm_setting_team_port_get_prio (NMSettingTeamPort *setting); NM_AVAILABLE_IN_1_12 gboolean nm_setting_team_port_get_sticky (NMSettingTeamPort *setting); NM_AVAILABLE_IN_1_12 -gint nm_setting_team_port_get_lacp_prio (NMSettingTeamPort *setting); +int nm_setting_team_port_get_lacp_prio (NMSettingTeamPort *setting); NM_AVAILABLE_IN_1_12 -gint nm_setting_team_port_get_lacp_key (NMSettingTeamPort *setting); +int nm_setting_team_port_get_lacp_key (NMSettingTeamPort *setting); NM_AVAILABLE_IN_1_12 guint nm_setting_team_port_get_num_link_watchers (NMSettingTeamPort *setting); NM_AVAILABLE_IN_1_12 |