diff options
| author | Thomas Haller <thaller@redhat.com> | 2018-04-27 11:10:13 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2018-05-14 17:53:03 +0200 |
| commit | fc475f25f2ad29efad7af0ac8d6bef4989a0bf15 (patch) | |
| tree | 23ae3be37433cb217c48435b76365596e35e51ae /clients/cli/utils.c | |
| parent | 5975e4a39e81fab9a23db4adc74d531097ac5a41 (diff) | |
| download | NetworkManager-th/cli-connection-handling.tar.gz | |
cli: use macro for list of argument for NmcMetaGenericInfo.get_fcn()th/cli-connection-handling
The reasons are:
- I want to locate all implmenetations of the get_fcn() handler. By
consistently using this macro, you can just grep for the macro and
find them all.
- all implementations should follow the same style. This macro
enforces the same names for arguments and avoids copy&paste.
- if we are going to add or change an argument, it becomes easier.
That's because we can easily identify all implementation and can
change arguments in one place.
Diffstat (limited to 'clients/cli/utils.c')
| -rw-r--r-- | clients/cli/utils.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/clients/cli/utils.c b/clients/cli/utils.c index 2c0e3b57d7..958da08100 100644 --- a/clients/cli/utils.c +++ b/clients/cli/utils.c @@ -93,7 +93,8 @@ _meta_type_nmc_generic_info_get_fcn (const NMMetaAbstractInfo *abstract_info, nm_assert (out_to_free || NM_IN_SET (get_type, NM_META_ACCESSOR_GET_TYPE_COLOR)); if (info->get_fcn) { - return info->get_fcn (environment, environment_user_data, + return info->get_fcn (environment, + environment_user_data, info, target, get_type, get_flags, |