diff options
| author | Thomas Haller <thaller@redhat.com> | 2013-11-01 19:47:07 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2013-11-13 15:29:24 +0100 |
| commit | ab92a0d69c6f75eb8137674a00cd9735556b06ad (patch) | |
| tree | 6d8dad47d5aeb06f0789cbe94b7d2f04324846f7 /cli/src/connections.c | |
| parent | 0139ad37f723e3a587dcfbdbf33845815ad52025 (diff) | |
| download | NetworkManager-ab92a0d69c6f75eb8137674a00cd9735556b06ad.tar.gz | |
cli: fix reading IP config for *-slaves
Error found by running Coverity
https://bugzilla.redhat.com/show_bug.cgi?id=1025894
Signed-off-by: Thomas Haller <thaller@redhat.com>
Diffstat (limited to 'cli/src/connections.c')
| -rw-r--r-- | cli/src/connections.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/cli/src/connections.c b/cli/src/connections.c index b0c21daea8..d5006be123 100644 --- a/cli/src/connections.c +++ b/cli/src/connections.c @@ -4227,23 +4227,25 @@ cleanup_olpc: if (!nmc_parse_args (exp_args, TRUE, &argc, &argv, error)) return FALSE; + /* coverity[dead_error_begin] */ if (ip4) { ip4addr = nmc_parse_and_build_ip4_address (ip4, gw4, error); if (!ip4addr) { g_prefix_error (error, _("Error: ")); return FALSE; } + add_ip4_address_to_connection (ip4addr, connection); } - add_ip4_address_to_connection (ip4addr, connection); + /* coverity[dead_error_begin] */ if (ip6) { ip6addr = nmc_parse_and_build_ip6_address (ip6, gw6, error); if (!ip6addr) { g_prefix_error (error, _("Error: ")); return FALSE; } + add_ip6_address_to_connection (ip6addr, connection); } - add_ip6_address_to_connection (ip6addr, connection); } /* Ask for addresses if '--ask' is specified. */ |