diff options
| author | Dan Winship <danw@gnome.org> | 2014-04-08 12:02:28 -0400 |
|---|---|---|
| committer | Dan Winship <danw@gnome.org> | 2014-06-20 11:28:22 -0400 |
| commit | 2d3b8f735731abf6dcbad1714e126c2ce8fc418a (patch) | |
| tree | 4a65adb6a5e661d5adebb24c23cf5f01b283274d /cli/src/connections.c | |
| parent | a4b689096e1a9f85bb69073e0241d005025fd7b1 (diff) | |
| download | NetworkManager-danw/wip/gerror.tar.gz | |
all: don't include error->code in log messagesdanw/wip/gerror
GError codes are only unique per domain, so logging the code without
also indicating the domain is not helpful. And anyway, if the error
messages are not distinctive enough to tell the whole story then we
should fix the error messages.
Diffstat (limited to 'cli/src/connections.c')
| -rw-r--r-- | cli/src/connections.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/cli/src/connections.c b/cli/src/connections.c index a393dc0ec7..7e84432f85 100644 --- a/cli/src/connections.c +++ b/cli/src/connections.c @@ -5001,8 +5001,8 @@ add_connection_cb (NMRemoteSettings *settings, if (error) { g_string_printf (nmc->return_text, - _("Error: Failed to add '%s' connection: (%d) %s"), - info->con_name, error->code, error->message); + _("Error: Failed to add '%s' connection: %s"), + info->con_name, error->message); nmc->return_value = NMC_RESULT_ERROR_CON_ACTIVATION; } else { printf (_("Connection '%s' (%s) successfully added.\n"), @@ -7489,10 +7489,10 @@ editor_menu_main (NmCli *nmc, NMConnection *connection, const char *connection_t g_cond_wait (&nmc_editor_cond, &nmc_editor_mutex); if (nmc_editor_error) { - printf (_("Error: Failed to save '%s' (%s) connection: (%d) %s\n"), + printf (_("Error: Failed to save '%s' (%s) connection: %s\n"), nm_connection_get_id (connection), nm_connection_get_uuid (connection), - nmc_editor_error->code, nmc_editor_error->message); + nmc_editor_error->message); g_error_free (nmc_editor_error); } else { @@ -7579,10 +7579,10 @@ editor_menu_main (NmCli *nmc, NMConnection *connection, const char *connection_t g_cond_wait (&nmc_editor_cond, &nmc_editor_mutex); if (nmc_editor_error) { - printf (_("Error: Failed to activate '%s' (%s) connection: (%d) %s\n"), + printf (_("Error: Failed to activate '%s' (%s) connection: %s\n"), nm_connection_get_id (connection), nm_connection_get_uuid (connection), - nmc_editor_error->code, nmc_editor_error->message); + nmc_editor_error->message); g_error_free (nmc_editor_error); } else { printf (_("Monitoring connection activation (press any key to continue)\n")); @@ -8029,9 +8029,9 @@ modify_connection_cb (NMRemoteConnection *connection, if (error) { g_string_printf (nmc->return_text, - _("Error: Failed to modify connection '%s': (%d) %s"), + _("Error: Failed to modify connection '%s': %s"), nm_connection_get_id (NM_CONNECTION (connection)), - error->code, error->message); + error->message); nmc->return_value = NMC_RESULT_ERROR_UNKNOWN; } else { if (nmc->print_output == NMC_PRINT_PRETTY) |