diff options
author | Thomas Haller <thaller@redhat.com> | 2019-05-29 14:47:57 +0200 |
---|---|---|
committer | Thomas Haller <thaller@redhat.com> | 2019-05-29 14:48:03 +0200 |
commit | 9a7929bdb154c5d884638bbd39cac82688e21a8b (patch) | |
tree | 90efcf1126994c9bef32b596510cf14a9205ad78 | |
parent | 58eee5896d1696192bab45115aed08c785ab76ed (diff) | |
download | NetworkManager-9a7929bdb154c5d884638bbd39cac82688e21a8b.tar.gz |
dhcp/trivial: add fixme comment about stopping clients
-rw-r--r-- | src/dhcp/nm-dhcp-manager.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/dhcp/nm-dhcp-manager.c b/src/dhcp/nm-dhcp-manager.c index fe843a2ce4..42a5eca971 100644 --- a/src/dhcp/nm-dhcp-manager.c +++ b/src/dhcp/nm-dhcp-manager.c @@ -208,6 +208,12 @@ client_start (NMDhcpManager *self, /* Kill any old client instance */ client = get_client_for_ifindex (self, addr_family, ifindex); if (client) { + /* FIXME: we cannot just call synchronously "stop()" and forget about the client. + * We need to wait for the client to be fully stopped because most/all clients + * cannot quit right away. + * + * FIXME(shutdown): also fix this during shutdown, to wait for all DHCP clients + * to be fully stopped. */ remove_client (self, client); nm_dhcp_client_stop (client, FALSE); g_object_unref (client); |