diff options
| author | Thomas Haller <thaller@redhat.com> | 2015-04-17 14:09:55 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2015-04-17 14:26:49 +0200 |
| commit | de9848aa66d2ef97a53ad04c537df4859baea243 (patch) | |
| tree | 260ea21b97a77cd7c1669a8485c7a211f296fe6c | |
| parent | 6b0f84bddaae8d315aaa28997b0ab7e71d3be091 (diff) | |
| download | NetworkManager-de9848aa66d2ef97a53ad04c537df4859baea243.tar.gz | |
core: optimize nm_match_spec_s390_subchannels() to return early
No need to parse the subchannels if the spec list is empty.
This isn't actually an issue, because nm_match_spec_s390_subchannels()
was never called with empty spec list.
| -rw-r--r-- | src/NetworkManagerUtils.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/NetworkManagerUtils.c b/src/NetworkManagerUtils.c index 2a88c946a4..82d695c4d6 100644 --- a/src/NetworkManagerUtils.c +++ b/src/NetworkManagerUtils.c @@ -1108,6 +1108,9 @@ nm_match_spec_s390_subchannels (const GSList *specs, const char *subchannels) g_return_val_if_fail (subchannels != NULL, NM_MATCH_SPEC_NO_MATCH); + if (!specs) + return NM_MATCH_SPEC_NO_MATCH; + if (!parse_subchannels (subchannels, &a, &b, &c)) return NM_MATCH_SPEC_NO_MATCH; |