summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLubomir Rintel <lkundrak@v3.sk>2015-06-07 15:26:43 +0200
committerLubomir Rintel <lkundrak@v3.sk>2015-07-02 09:33:58 +0200
commitdf69bd1625e0d28aac3f910401780f6ae7d09641 (patch)
tree00fdc75d65c4bd68386aaf8daad4af66faf02eda
parent8fdf19863290a82e4000c1549cbc114210f545f1 (diff)
downloadNetworkManager-df69bd1625e0d28aac3f910401780f6ae7d09641.tar.gz
cli: trivial: move is_property_valid()
This removes one extra forward definition and saves one in future.
-rw-r--r--clients/cli/connections.c49
1 files changed, 24 insertions, 25 deletions
diff --git a/clients/cli/connections.c b/clients/cli/connections.c
index b4388647fe..cafe935f9d 100644
--- a/clients/cli/connections.c
+++ b/clients/cli/connections.c
@@ -4124,6 +4124,30 @@ do_questionnaire_ip (NMConnection *connection)
maybe_ask_for_gateway (connection, AF_INET6);
}
+static NMSetting *
+is_setting_valid (NMConnection *connection, const NameItem *valid_settings, char *setting)
+{
+ const char *setting_name;
+
+ if (!(setting_name = check_valid_name (setting, valid_settings, NULL)))
+ return NULL;
+ return nm_connection_get_setting_by_name (connection, setting_name);
+}
+
+static char *
+is_property_valid (NMSetting *setting, const char *property, GError **error)
+{
+ char **valid_props = NULL;
+ const char *prop_name;
+ char *ret;
+
+ valid_props = nmc_setting_get_valid_properties (setting);
+ prop_name = nmc_string_is_valid (property, (const char **) valid_props, error);
+ ret = g_strdup (prop_name);
+ g_strfreev (valid_props);
+ return ret;
+}
+
static gboolean
complete_connection_by_type (NMConnection *connection,
const char *con_type,
@@ -6379,7 +6403,6 @@ should_complete_vpn_uuids (const char *prompt, const char *line)
return _get_and_check_property (prompt, line, uuid_properties, NULL, NULL);
}
-static char *is_property_valid (NMSetting *setting, const char *property, GError **error);
static const char **
get_allowed_property_values (void)
{
@@ -7493,30 +7516,6 @@ split_editor_main_cmd_args (const char *str, char **setting, char **property, ch
}
static NMSetting *
-is_setting_valid (NMConnection *connection, const NameItem *valid_settings, char *setting)
-{
- const char *setting_name;
-
- if (!(setting_name = check_valid_name (setting, valid_settings, NULL)))
- return NULL;
- return nm_connection_get_setting_by_name (connection, setting_name);
-}
-
-static char *
-is_property_valid (NMSetting *setting, const char *property, GError **error)
-{
- char **valid_props = NULL;
- const char *prop_name;
- char *ret;
-
- valid_props = nmc_setting_get_valid_properties (setting);
- prop_name = nmc_string_is_valid (property, (const char **) valid_props, error);
- ret = g_strdup (prop_name);
- g_strfreev (valid_props);
- return ret;
-}
-
-static NMSetting *
create_setting_by_name (const char *name, const NameItem *valid_settings)
{
const char *setting_name;