summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2017-11-29 20:57:42 +0100
committerThomas Haller <thaller@redhat.com>2017-12-05 21:24:22 +0100
commitaef573d6ac6ce39922b82fea3262d42a820332e9 (patch)
tree288aaafb14a3841e3bdd69d4b06a41d015d83193
parentf27d798c472a77c0cf6b54987f27186d6764ca1e (diff)
downloadNetworkManager-aef573d6ac6ce39922b82fea3262d42a820332e9.tar.gz
settings: log pretty names for settings-connection flags
(cherry picked from commit c3dd5d8df2388813c22d2662985725b188450b85)
-rw-r--r--src/settings/nm-settings-connection.c13
-rw-r--r--src/settings/nm-settings-connection.h6
2 files changed, 15 insertions, 4 deletions
diff --git a/src/settings/nm-settings-connection.c b/src/settings/nm-settings-connection.c
index 9b289f9f21..5e6c93da4a 100644
--- a/src/settings/nm-settings-connection.c
+++ b/src/settings/nm-settings-connection.c
@@ -2115,6 +2115,13 @@ nm_settings_connection_get_unsaved (NMSettingsConnection *self)
/*****************************************************************************/
+NM_UTILS_FLAGS2STR_DEFINE_STATIC (_settings_connection_flags_to_string, NMSettingsConnectionFlags,
+ NM_UTILS_FLAGS2STR (NM_SETTINGS_CONNECTION_FLAGS_NONE, "none"),
+ NM_UTILS_FLAGS2STR (NM_SETTINGS_CONNECTION_FLAGS_UNSAVED, "unsaved"),
+ NM_UTILS_FLAGS2STR (NM_SETTINGS_CONNECTION_FLAGS_NM_GENERATED, "nm-generatd"),
+ NM_UTILS_FLAGS2STR (NM_SETTINGS_CONNECTION_FLAGS_VOLATILE, "volatile"),
+);
+
NMSettingsConnectionFlags
nm_settings_connection_get_flags (NMSettingsConnection *self)
{
@@ -2151,7 +2158,11 @@ nm_settings_connection_set_flags_all (NMSettingsConnection *self, NMSettingsConn
old_flags = priv->flags;
if (old_flags != flags) {
- _LOGT ("update settings-connection flags to 0x%x (was 0x%x)", (guint) flags, (guint) priv->flags);
+ char buf1[255], buf2[255];
+
+ _LOGT ("update settings-connection flags to %s (was %s)",
+ _settings_connection_flags_to_string (flags, buf1, sizeof (buf1)),
+ _settings_connection_flags_to_string (priv->flags, buf2, sizeof (buf2)));
priv->flags = flags;
_notify (self, PROP_FLAGS);
if (NM_FLAGS_HAS (old_flags, NM_SETTINGS_CONNECTION_FLAGS_UNSAVED) != NM_FLAGS_HAS (flags, NM_SETTINGS_CONNECTION_FLAGS_UNSAVED))
diff --git a/src/settings/nm-settings-connection.h b/src/settings/nm-settings-connection.h
index 3672bc08c1..dd9e9c213c 100644
--- a/src/settings/nm-settings-connection.h
+++ b/src/settings/nm-settings-connection.h
@@ -65,9 +65,9 @@
*
* #NMSettingsConnection flags.
**/
-typedef enum
-{
+typedef enum {
NM_SETTINGS_CONNECTION_FLAGS_NONE = 0x00,
+
NM_SETTINGS_CONNECTION_FLAGS_UNSAVED = 0x01,
NM_SETTINGS_CONNECTION_FLAGS_NM_GENERATED = 0x02,
NM_SETTINGS_CONNECTION_FLAGS_VOLATILE = 0x04,
@@ -76,7 +76,7 @@ typedef enum
NM_SETTINGS_CONNECTION_FLAGS_ALL = ((__NM_SETTINGS_CONNECTION_FLAGS_LAST - 1) << 1) - 1,
} NMSettingsConnectionFlags;
-typedef enum { /*< skip >*/
+typedef enum {
NM_SETTINGS_CONNECTION_COMMIT_REASON_NONE = 0,
NM_SETTINGS_CONNECTION_COMMIT_REASON_USER_ACTION = (1LL << 0),
NM_SETTINGS_CONNECTION_COMMIT_REASON_ID_CHANGED = (1LL << 1),