diff options
| author | Thomas Haller <thaller@redhat.com> | 2016-09-23 09:37:21 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2016-09-23 09:37:21 +0200 |
| commit | c6ac2310dc6e552682099e908f2786dd2e61575f (patch) | |
| tree | 40086f68c4b57c2f964517d3d2d942258ea5bae1 | |
| parent | 0fb723e7205f7c0ba038c463047eb780171e85a2 (diff) | |
| download | NetworkManager-c6ac2310dc6e552682099e908f2786dd2e61575f.tar.gz | |
dhcp: add FIXME comment to nm-dhcp-helper.c
| -rw-r--r-- | src/dhcp-manager/nm-dhcp-helper.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/src/dhcp-manager/nm-dhcp-helper.c b/src/dhcp-manager/nm-dhcp-helper.c index 9c6f69b839..f50c5cec02 100644 --- a/src/dhcp-manager/nm-dhcp-helper.c +++ b/src/dhcp-manager/nm-dhcp-helper.c @@ -136,6 +136,12 @@ main (int argc, char *argv[]) nm_g_type_init (); + /* FIXME: g_dbus_connection_new_for_address_sync() tries to connect to the socket in + * non-blocking mode, which can easily fail with EAGAIN, causing the creation of the + * socket to fail with "Could not connect: Resource temporarily unavailable". + * + * We should instead create the GIOStream ourself and block on connecting to + * the socket. */ connection = g_dbus_connection_new_for_address_sync ("unix:path=" NMRUNDIR "/private-dhcp", G_DBUS_CONNECTION_FLAGS_AUTHENTICATION_CLIENT, NULL, NULL, &error); |