diff options
| author | Jiří Klimeš <jklimes@redhat.com> | 2014-12-04 16:39:45 +0100 |
|---|---|---|
| committer | Jiří Klimeš <jklimes@redhat.com> | 2014-12-05 09:38:40 +0100 |
| commit | d80bb52872e0c8b520c92e9839843fda83a41a95 (patch) | |
| tree | 8ef9583ff28ab23753f023b5b687c807b857d07e | |
| parent | f93128194eb6e0d3ba7387ff6fc4430da6ae6cfe (diff) | |
| download | NetworkManager-d80bb52872e0c8b520c92e9839843fda83a41a95.tar.gz | |
tui: width and height parameters was swapped, but they are ignored anyway
Coverity: Defect type: SWAPPED_ARGUMENTS
clients/tui/newt/nmt-newt-section.c:328: swapped_arguments: The positions of arguments in the call to "nmt_newt_widget_size_request" do not match the ordering of the parameters: * "&border_height" is passed to "width" * "&border_width" is passed to "height"
| -rw-r--r-- | clients/tui/newt/nmt-newt-section.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/clients/tui/newt/nmt-newt-section.c b/clients/tui/newt/nmt-newt-section.c index df5b188945..1a5035fc09 100644 --- a/clients/tui/newt/nmt-newt-section.c +++ b/clients/tui/newt/nmt-newt-section.c @@ -260,12 +260,12 @@ nmt_newt_section_size_request (NmtNewtWidget *widget, int *height) { NmtNewtSectionPrivate *priv = NMT_NEWT_SECTION_GET_PRIVATE (widget); - int border_width, border_height; + int w_ignore, h_ignore; g_return_if_fail (priv->header != NULL && priv->body != NULL); if (priv->show_border) - nmt_newt_widget_size_request (priv->border_grid, &border_width, &border_height); + nmt_newt_widget_size_request (priv->border_grid, &w_ignore, &h_ignore); nmt_newt_widget_size_request (priv->header, &priv->hwidth_req, &priv->hheight_req); nmt_newt_widget_size_request (priv->body, &priv->bwidth_req, &priv->bheight_req); @@ -322,10 +322,10 @@ nmt_newt_section_size_allocate (NmtNewtWidget *widget, NmtNewtSectionPrivate *priv = NMT_NEWT_SECTION_GET_PRIVATE (widget); if (priv->show_border) { - int border_height, border_width; + int w_ignore, h_ignore; adjust_border_for_allocation (priv, height); - nmt_newt_widget_size_request (priv->border_grid, &border_height, &border_width); + nmt_newt_widget_size_request (priv->border_grid, &w_ignore, &h_ignore); nmt_newt_widget_size_allocate (priv->border_grid, x, y, 1, height); nmt_newt_widget_size_allocate (priv->header, x + 2, y, width, priv->hheight_req); } else |