summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBeniamino Galvani <bgalvani@redhat.com>2022-04-13 09:07:21 +0200
committerBeniamino Galvani <bgalvani@redhat.com>2022-05-03 09:07:29 +0200
commit15a42113039994ca10bb97919319cb253a22e339 (patch)
tree05c2993ce6302bbea07cdfc33ba1abdbca2d2279
parentf20ac6bdc7cd8ac8dc3ebc5ee338fdf2533a16f2 (diff)
downloadNetworkManager-15a42113039994ca10bb97919319cb253a22e339.tar.gz
dhcp: fix logging domain
Fix wrong domain when logging a lease: dhcp6 (veth0): valid_lft 7200 dhcp6 (veth0): preferred_lft 5400 dhcp6 (veth0): address fd00:db8:db8::11:2233:4455 dhcp (veth0): domain search 'domain'
-rw-r--r--src/core/dhcp/nm-dhcp-utils.c13
1 files changed, 7 insertions, 6 deletions
diff --git a/src/core/dhcp/nm-dhcp-utils.c b/src/core/dhcp/nm-dhcp-utils.c
index 63341515f8..ecb6eea67a 100644
--- a/src/core/dhcp/nm-dhcp-utils.c
+++ b/src/core/dhcp/nm-dhcp-utils.c
@@ -295,7 +295,7 @@ process_classful_routes(const char *iface,
return;
if ((NM_PTRARRAY_LEN(searches) % 2) != 0) {
- _LOG2I(LOGD_DHCP, iface, " static routes provided, but invalid");
+ _LOG2I(LOGD_DHCP4, iface, " static routes provided, but invalid");
return;
}
@@ -305,11 +305,11 @@ process_classful_routes(const char *iface,
guint32 rt_addr, rt_route;
if (inet_pton(AF_INET, *s, &rt_addr) <= 0) {
- _LOG2W(LOGD_DHCP, iface, "DHCP provided invalid static route address: '%s'", *s);
+ _LOG2W(LOGD_DHCP4, iface, "DHCP provided invalid static route address: '%s'", *s);
continue;
}
if (inet_pton(AF_INET, *(s + 1), &rt_route) <= 0) {
- _LOG2W(LOGD_DHCP, iface, "DHCP provided invalid static route gateway: '%s'", *(s + 1));
+ _LOG2W(LOGD_DHCP4, iface, "DHCP provided invalid static route gateway: '%s'", *(s + 1));
continue;
}
@@ -340,7 +340,7 @@ process_classful_routes(const char *iface,
nm_l3_config_data_add_route_4(l3cd, &route);
- _LOG2I(LOGD_DHCP,
+ _LOG2I(LOGD_DHCP4,
iface,
" static route %s",
nm_platform_ip4_route_to_string(&route, sbuf, sizeof(sbuf)));
@@ -352,6 +352,7 @@ process_domain_search(int addr_family, const char *iface, const char *str, NML3C
{
gs_free const char **searches = NULL;
gs_free char *unescaped = NULL;
+ NMLogDomain logd = NM_IS_IPv4(addr_family) ? LOGD_DHCP4 : LOGD_DHCP6;
const char **s;
char *p;
int i;
@@ -373,13 +374,13 @@ process_domain_search(int addr_family, const char *iface, const char *str, NML3C
} while (*p++);
if (strchr(unescaped, '\\')) {
- _LOG2W(LOGD_DHCP, iface, " invalid domain search: '%s'", unescaped);
+ _LOG2W(logd, iface, " invalid domain search: '%s'", unescaped);
return;
}
searches = nm_strsplit_set(unescaped, " ");
for (s = searches; searches && *s; s++) {
- _LOG2I(LOGD_DHCP, iface, " domain search '%s'", *s);
+ _LOG2I(logd, iface, " domain search '%s'", *s);
nm_l3_config_data_add_search(l3cd, addr_family, *s);
}
}