diff options
author | Beniamino Galvani <bgalvani@redhat.com> | 2022-12-22 11:23:46 +0100 |
---|---|---|
committer | Beniamino Galvani <bgalvani@redhat.com> | 2022-12-22 11:24:37 +0100 |
commit | a39ec8ca75eee38fcef18b5e3f1e5e61128f82ba (patch) | |
tree | b03c0a93112bd506adf38f61810354c36cd8272e | |
parent | d1f010b3058b30bb964ac979647e0710137e5d83 (diff) | |
download | NetworkManager-a39ec8ca75eee38fcef18b5e3f1e5e61128f82ba.tar.gz |
nmcli: fix double free
src/nmcli/devices.c:1196: double_free: Calling "_nm_auto_strfreev" frees pointer "arg_arr" which has already been freed.
Fixes: c5d45848dd07 ('cli: mark argv argument for command line parsing as const')
-rw-r--r-- | src/nmcli/devices.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/nmcli/devices.c b/src/nmcli/devices.c index 20e69b00a2..f71a7d036d 100644 --- a/src/nmcli/devices.c +++ b/src/nmcli/devices.c @@ -1149,7 +1149,7 @@ get_device_list(NmCli *nmc, int *argc, const char *const **argv) if (*argc == 0) { g_string_printf(nmc->return_text, _("Error: No interface specified.")); nmc->return_value = NMC_RESULT_ERROR_USER_INPUT; - goto error; + return NULL; } devices = nmc_get_devices_sorted(nmc->client); @@ -1190,9 +1190,6 @@ get_device_list(NmCli *nmc, int *argc, const char *const **argv) } g_free(devices); -error: - g_strfreev(arg_arr); - return queue; } |