summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJiří Klimeš <jklimes@redhat.com>2014-12-12 22:11:48 +0100
committerJiří Klimeš <jklimes@redhat.com>2014-12-15 14:11:03 +0100
commit09180fa4e70bbef01e4519f17f1720cac5e62f47 (patch)
tree1c1def1c39fa7b4d20ef3dbd313a7c4bfde4a5d1
parentadbe151c3ad15550dd11c8b1dd1a67ee29d55d46 (diff)
downloadNetworkManager-09180fa4e70bbef01e4519f17f1720cac5e62f47.tar.gz
tests: mute coverity INFINITE_LOOP error
Error: INFINITE_LOOP (CWE-835): [#def17] NetworkManager-0.9.11.0/libnm/tests/test-nm-client.c:93: loop_top: Top of the loop. NetworkManager-0.9.11.0/libnm/tests/test-nm-client.c:94: loop_bottom: Bottom of the loop. NetworkManager-0.9.11.0/libnm/tests/test-nm-client.c:93: loop_condition: If "notified" is initially true then it will remain true. Error: INFINITE_LOOP (CWE-835): [#def18] NetworkManager-0.9.11.0/libnm/tests/test-nm-client.c:191: loop_top: Top of the loop. NetworkManager-0.9.11.0/libnm/tests/test-nm-client.c:192: loop_bottom: Bottom of the loop. NetworkManager-0.9.11.0/libnm/tests/test-nm-client.c:191: loop_condition: If "result & NOTIFY_MASK" is initially true then it will remain true. NetworkManager-0.9.11.0/libnm/tests/test-nm-client.c:191: loop_condition: If "result & SIGNAL_MASK" is initially true then it will remain true.
-rw-r--r--libnm/tests/test-nm-client.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/libnm/tests/test-nm-client.c b/libnm/tests/test-nm-client.c
index 48b16b4690..3541c741e1 100644
--- a/libnm/tests/test-nm-client.c
+++ b/libnm/tests/test-nm-client.c
@@ -90,6 +90,7 @@ test_device_added (void)
/* Tell the test service to add a new device */
nm_test_service_add_device (sinfo, client, "AddWiredDevice", "eth0");
+ /* coverity[loop_condition] */
while (!notified)
g_main_context_iteration (NULL, TRUE);
@@ -188,6 +189,7 @@ test_device_added_signal_after_init (void)
/* Ensure the 'device-added' signal doesn't show up before
* the 'Devices' property change notification */
+ /* coverity[loop_condition] */
while (!(result & SIGNAL_MASK) && !(result & NOTIFY_MASK))
g_main_context_iteration (NULL, TRUE);