summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Haller <thaller@redhat.com>2021-08-10 17:26:07 +0200
committerThomas Haller <thaller@redhat.com>2021-08-17 13:18:07 +0200
commitf7635c9ffe738f1b9376d04d8c4acec2fc3caf8b (patch)
tree170905057ee8e4d25d5c128adecac40dc31ea091
parent68a5d1cfe5126241892fc26736daad2c5b5f553d (diff)
downloadNetworkManager-f7635c9ffe738f1b9376d04d8c4acec2fc3caf8b.tar.gz
platform/netlink: use switch for type check in validate_nla()
-rw-r--r--src/libnm-platform/nm-netlink.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/src/libnm-platform/nm-netlink.c b/src/libnm-platform/nm-netlink.c
index d836e4c9ff..c7dfb3664a 100644
--- a/src/libnm-platform/nm-netlink.c
+++ b/src/libnm-platform/nm-netlink.c
@@ -622,14 +622,17 @@ validate_nla(const struct nlattr *nla, int maxtype, const struct nla_policy *pol
if (pt->maxlen && len > pt->maxlen)
return -NME_UNSPEC;
- if (pt->type == NLA_STRING) {
- const char *data;
+ switch (pt->type) {
+ case NLA_STRING:
+ {
+ const char *data = nla_data(nla);
nm_assert(minlen > 0);
- data = nla_data(nla);
if (data[len - 1u] != '\0')
return -NME_UNSPEC;
+ break;
+ }
}
return 0;