summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBeniamino Galvani <bgalvani@redhat.com>2019-10-07 11:42:12 +0200
committerBeniamino Galvani <bgalvani@redhat.com>2019-10-07 13:35:02 +0200
commitd0db41c1d48ae326eb12217b553582b6dde19cd9 (patch)
tree8cec4a4f30e9f00eece505082eeec05e393a91ac
parentc6d53c550094163af8b7f91540162507e84b5639 (diff)
downloadNetworkManager-d0db41c1d48ae326eb12217b553582b6dde19cd9.tar.gz
cli: fix crash in 'nmcli connection add'
The connection type can be NULL. Fixes: e1ec22f74b1e ('cli: cleanup setting default interface-name')
-rw-r--r--clients/cli/connections.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/clients/cli/connections.c b/clients/cli/connections.c
index 2c05754d5a..67d9bef772 100644
--- a/clients/cli/connections.c
+++ b/clients/cli/connections.c
@@ -3752,11 +3752,11 @@ set_default_interface_name (NmCli *nmc,
con_type = nm_setting_connection_get_connection_type (s_con);
/* Set a sensible bond/team/bridge interface name by default */
- if (nm_streq (con_type, NM_SETTING_BOND_SETTING_NAME))
+ if (nm_streq0 (con_type, NM_SETTING_BOND_SETTING_NAME))
default_name = "nm-bond";
- else if (nm_streq (con_type, NM_SETTING_TEAM_SETTING_NAME))
+ else if (nm_streq0 (con_type, NM_SETTING_TEAM_SETTING_NAME))
default_name = "nm-team";
- else if (nm_streq (con_type, NM_SETTING_BRIDGE_SETTING_NAME))
+ else if (nm_streq0 (con_type, NM_SETTING_BRIDGE_SETTING_NAME))
default_name = "nm-bridge";
else
default_name = NULL;