diff options
| author | Thomas Haller <thaller@redhat.com> | 2018-10-25 11:20:10 +0200 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2018-10-25 11:20:10 +0200 |
| commit | f8fed7dd52d1979dedb4ee4bb4939f05dcbea99d (patch) | |
| tree | 4264f680c2d0fbd27a5089e9feb8a73b029c04b4 | |
| parent | 168e8b9b6fccf0145dd2fac784612953d94285d4 (diff) | |
| download | NetworkManager-f8fed7dd52d1979dedb4ee4bb4939f05dcbea99d.tar.gz | |
checkpatch: complain about XXX markers in code
We have a few source code tags like "TODO" and "FIXME".
"XXX" is not intended to be merged, it is for marking
places in code while still working on it.
| -rwxr-xr-x | contrib/scripts/checkpatch.pl | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/contrib/scripts/checkpatch.pl b/contrib/scripts/checkpatch.pl index 67ffbc4256..2ac931c2bc 100755 --- a/contrib/scripts/checkpatch.pl +++ b/contrib/scripts/checkpatch.pl @@ -141,6 +141,7 @@ complain ("Don't use \"unsigned int\" but just use \"unsigned\"") if $line =~ /\ complain ("Please use LGPL2+ for new files") if $is_patch and $line =~ /under the terms of the GNU General Public License/; complain ("Don't use space inside elvis operator ?:") if $line =~ /\?[\t ]+:/; complain ("Don't add Emacs editor formatting hints to source files") if $line_no == 1 and $line =~ /-\*-.+-\*-/; +complain ("XXX marker are reserved for development while work-in-progress. Use TODO or FIXME comment instead?") if $line =~ /\bXXX\b/; new_hunk if $_ eq ''; my ($this_indent) = /^(\s*)/; |