core/trivial: add FIXME comment about immutable applied-connection

2 files changed, 4 insertions, 0 deletions

diff --git a/src/devices/nm-device.c b/src/devices/nm-device.c
index b77d0fd36a..b905855cf5 100644
--- a/src/devices/nm-device.c
+++ b/src/devices/nm-device.c
@@ -12557,6 +12557,8 @@ check_and_reapply_connection(NMDevice *    self,
 
         con_old = applied_clone = nm_simple_connection_new_clone(applied);
         con_new                 = applied;
+        /* FIXME(applied-connection-immutable): we should not modify the applied
+         *   connection but replace it with a new (immutable) instance. */
         nm_connection_replace_settings_from_connection(applied, connection_clean);
         nm_connection_clear_secrets(applied);
     } else
diff --git a/src/devices/ovs/nm-ovsdb.c b/src/devices/ovs/nm-ovsdb.c
index f3ef54a1b0..56b7421182 100644
--- a/src/devices/ovs/nm-ovsdb.c
+++ b/src/devices/ovs/nm-ovsdb.c
@@ -216,6 +216,8 @@ ovsdb_call_method(NMOvsdb *           self,
     case OVSDB_MONITOR:
         break;
     case OVSDB_ADD_INTERFACE:
+        /* FIXME(applied-connection-immutable): we should not modify the applied
+         *   connection, consequently there is no need to clone the connections. */
         call->bridge           = nm_simple_connection_new_clone(bridge);
         call->port             = nm_simple_connection_new_clone(port);
         call->interface        = nm_simple_connection_new_clone(interface);