diff options
| author | Thomas Haller <thaller@redhat.com> | 2016-03-04 09:02:45 +0100 |
|---|---|---|
| committer | Thomas Haller <thaller@redhat.com> | 2016-03-04 09:06:21 +0100 |
| commit | d17aedf91f4f5cdb8f5399540a730abe57f548d0 (patch) | |
| tree | 813c851f2955bda4f78a188f44d3f954bc8dc24d | |
| parent | 9f164989380109a69209d0683b56bf422b33ad11 (diff) | |
| download | NetworkManager-d17aedf91f4f5cdb8f5399540a730abe57f548d0.tar.gz | |
all: explicitly ignore return values
Coverity warns that usually we check for the return value.
| -rw-r--r-- | src/devices/bluetooth/nm-bluez4-adapter.c | 2 | ||||
| -rw-r--r-- | src/nm-core-utils.c | 3 | ||||
| -rw-r--r-- | src/platform/nm-linux-platform.c | 2 |
3 files changed, 4 insertions, 3 deletions
diff --git a/src/devices/bluetooth/nm-bluez4-adapter.c b/src/devices/bluetooth/nm-bluez4-adapter.c index deeebcb667..9d8fd21056 100644 --- a/src/devices/bluetooth/nm-bluez4-adapter.c +++ b/src/devices/bluetooth/nm-bluez4-adapter.c @@ -203,7 +203,7 @@ get_properties_cb (GObject *proxy, GAsyncResult *result, gpointer user_data) properties = g_variant_get_child_value (ret, 0); - g_variant_lookup (properties, "Address", "s", &priv->address); + (void) g_variant_lookup (properties, "Address", "s", &priv->address); if (g_variant_lookup (properties, "Devices", "^ao", &devices)) { for (i = 0; devices[i]; i++) device_created (priv->proxy, devices[i], self); diff --git a/src/nm-core-utils.c b/src/nm-core-utils.c index a7d85c298c..256be10888 100644 --- a/src/nm-core-utils.c +++ b/src/nm-core-utils.c @@ -454,10 +454,11 @@ nm_utils_modprobe (GError **error, gboolean suppress_error_logging, const char * nm_log (llevel, LOGD_CORE, "modprobe: '%s' failed: %s", ARGV_TO_STR (argv), local->message); g_propagate_error (error, local); return -1; - } else if (exit_status != 0) + } else if (exit_status != 0) { nm_log (llevel, LOGD_CORE, "modprobe: '%s' exited with error %d%s%s%s%s%s%s", ARGV_TO_STR (argv), exit_status, std_out&&*std_out ? " (" : "", std_out&&*std_out ? _trunk_first_line (std_out) : "", std_out&&*std_out ? ")" : "", std_err&&*std_err ? " (" : "", std_err&&*std_err ? _trunk_first_line (std_err) : "", std_err&&*std_err ? ")" : ""); + } return exit_status; } diff --git a/src/platform/nm-linux-platform.c b/src/platform/nm-linux-platform.c index 091c9ef645..68d6aac9f0 100644 --- a/src/platform/nm-linux-platform.c +++ b/src/platform/nm-linux-platform.c @@ -3925,7 +3925,7 @@ link_add (NMPlatform *platform, * bond0 automatically. */ if (!g_file_test ("/sys/class/net/bonding_masters", G_FILE_TEST_EXISTS)) - nm_utils_modprobe (NULL, TRUE, "bonding", "max_bonds=0", NULL); + (void) nm_utils_modprobe (NULL, TRUE, "bonding", "max_bonds=0", NULL); } _LOGD ("link: add link '%s' of type '%s' (%d)", |