summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* libmm-glib,cdma: fix potential NULL dereferenceBen Chan2017-08-111-3/+4
| | | | | | | | | This patch fixes a potential NULL referenece issue in mm_cdma_manual_activation_properties_get_prl() where it accesses `self->priv->prl->data' when `self->priv->prl' could be potentially NULL. (cherry picked from commit 2b08a66645740df2e1e490df5ec44a7b5c537cc5)
* libmm-glib,sms-properties: fix potential NULL dereferenceBen Chan2017-08-111-3/+3
| | | | | | | | This patch fixes a potential NULL referenece issue in mm_sms_properties_get_data() where it accesses `self->priv->data->data' when `self->priv->data' could be potentially NULL. (cherry picked from commit c02dcd397ab6ccbc3c021bf6d96d76de7bce8b91)
* udev: remove default ID_MM_PLATFORM_DRIVER_PROBE whitelistAleksander Morgado2017-08-102-14/+0
| | | | | | | | | | | | The whitelist made all platform TTYs managed by the 'atmel_usart' kernel driver probed by ModemManager, which isn't something we want, as most of these aren't broadband modems. We leave the logic supporting the ID_MM_PLATFORM_DRIVER_PROBE udev tag as there may be a case where the user does need ModemManager to probe a given platform TTY. (cherry picked from commit e6f245c6dfe48be33e1099e842dec1c0e30a1508)
* iface-modem: remove unnecessary error checkBen Chan2017-08-081-12/+6
| | | | | | | This patch removes an unnecessary error check in the update_unlock_retries() where the error is never set. (cherry picked from commit 05a1097a27ff7c7349e6d9730a7009c3b6d9670b)
* broadband-bearer: run init sequence after flashing in disconnectionAleksander Morgado2017-08-041-0/+18
| | | | | | | | The init-sequence configured for the TTY that is being used as data port must not be launched during the port reopen() sequence; instead we must run it manually after the port flashing has finished. (cherry picked from commit e51ee31d503ee8c79255f438f10a541448146a3a)
* mbm: set GPS data port for DellDW5560Aleksander Morgado2017-08-041-0/+1
| | | | | | See https://lists.freedesktop.org/archives/modemmanager-devel/2017-August/005506.html (cherry picked from commit f455ce33b4fc41b055ec706aac7f33c09e76b131)
* location-gps-nmea: fix memory leaksBen Chan2017-08-041-4/+8
| | | | | | | | | | | | | | | | | | | | | There are potential memory leaks in MMLocationGpsNmea: - When the `trace' string provided to location_gps_nmea_take_trace() isn't added to the hash table, its ownership is still considered transferred. It should thus be freed. Similarly, the `trace_type' string isn't added the hash table and should thus be freed. - mm_location_gps_nmea_add_trace() duplicates a given trace string and then passes the trace copy to location_gps_nmea_take_trace(). When location_gps_nmea_take_trace() returns FALSE, the ownership of the copy isn't transferred. mm_location_gps_nmea_add_trace() should thus free the copy. This patch fixes the above memory leaks by having location_gps_nmea_take_trace() always take the ownership of the `trace' string and internally free `trace' and `trace_type' when necessary. (cherry picked from commit e33aa01963172a138833fbf84e54ef6b537c93bd)
* broadband-modem-qmi: fix potential use-after-freed issuesBen Chan2017-08-041-2/+2
| | | | | | | | | | | This patch fixes some potential use-after-freed issues in dms_get_ids_ready(). When an invalid ESN / MEID is retrieved, `ctx->self->priv->esn' / `ctx->self->priv->meid' is freed but not reset to NULL. If no IMEI is retrieved, `str' can be set to the already freed `ctx->self->priv->esn' / `ctx->self->priv->meid' and then propagated to a GSimpleAsyncResult object. (cherry picked from commit 0d3cca2c6f545cf9a91c75aed451df6d16ae5511)
* bearer-mbim: minor update in debug log messagesAleksander Morgado2017-08-041-2/+2
| | | | (cherry picked from commit f81a518515cdd213f53527025a12f7d40b5cfbbc)
* bearer-mbim: avoid accessing invalid session_id and nw_errorBen Chan2017-08-041-2/+6
| | | | | | | | This patch fixes an issue in disconnect_set_ready(). If mbim_message_connect_response_parse(), `session_id' and `nw_error' are not set to a valid value, and thus shouldn't be used. (cherry picked from commit d58305bf1fc89dd44e3d3f267dd4ed7579e7fd61)
* sms-part-cdma: add missing break statements in cause_code_to_delivery_stateBen Chan2017-08-031-0/+2
| | | | | | | | | | | This patch fixes cause_code_to_delivery_state() by adding two missing break statements for the case ERROR_CLASS_TEMPORARY and ERROR_CLASS_PERMANENT in the `switch (error_class)` statement. Without the break statements, the switch always falls through to the default and returns MM_SMS_DELIVERY_STATE_UNKNOWN for an `error_class' of value ERROR_CLASS_TEMPORARY or ERROR_CLASS_PERMANENT. (cherry picked from commit 0bb01ab68d36e63d08f9ed827524a24829c26835)
* libmm-glib,firmware: fix unique_id checksBen Chan2017-08-031-2/+2
| | | | | | | | | | | | | | The following checks in mm_modem_firmware_select() and mm_modem_firmware_select_sync() could result in a NULL pointer dereference if `unique_id' is NULL: g_return_if_fail (unique_id != NULL || unique_id[0] == '\0') g_return_val_if_fail (unique_id != NULL || unique_id[0] == '\0', FALSE) This patch fixes the checks to properly verify that `unique_id' is neither NULL nor an empty string. (cherry picked from commit bae4590784e9c4ca9b902b9fc69606cffe0ddb14)
* mmcli: description of the location-set-gps-refresh-rate optionValentin Blot2017-07-311-0/+5
| | | | | | | | | Commit 6c35878f12ab37604d85cb3a864e3859973bd195 introduced a new option for setting the refresh rate of location on DBus. This patch describes the option in the man page. https://bugs.freedesktop.org/show_bug.cgi?id=89924 (cherry picked from commit b2c7244b6c73dc615e67cf2f90f30ad671b43a84)
* bearer-mbim: avoid calling mbim_message_unref on NULL MbimMessageBen Chan2017-07-271-1/+2
| | | | (cherry picked from commit 4e468d04acd1e17c91ab5e66f3032db1b7e51c39)
* broadband-bearer: fix crm_range_readyBen Chan2017-07-191-0/+1
| | | | | | | | crm_range_ready() misses a return statement after it invokes interface_initialization_step(), which will lead to an invalid access of the already freed InitAsyncContext. (cherry picked from commit 8af44d3589615b054221a34e39c0525dd0a2e491)
* broadband-modem: plug memleak in init_current_storages()Aleksander Morgado2017-07-181-4/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ==28664== 4 bytes in 1 blocks are definitely lost in loss record 33 of 4,317 ==28664== at 0x4C2BE1F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28664== by 0x4C2E164: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28664== by 0x644E0CF: g_realloc (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x6469C06: ??? (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x6469C61: g_string_sized_new (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x4E8514A: mm_common_build_sms_storages_string (mm-common-helpers.c:116) ==28664== by 0x489035: cpms_query_ready (mm-broadband-modem.c:5428) ==28664== by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2) ==28664== by 0x44EADF: at_command_ready (mm-base-modem-at.c:503) ==28664== by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2) ==28664== by 0x4D8122: serial_command_ready (mm-port-serial-at.c:392) ==28664== by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2) ==28664== ==28664== 4 bytes in 1 blocks are definitely lost in loss record 34 of 4,317 ==28664== at 0x4C2BE1F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28664== by 0x4C2E164: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28664== by 0x644E0CF: g_realloc (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x6469C06: ??? (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x6469C61: g_string_sized_new (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x4E8514A: mm_common_build_sms_storages_string (mm-common-helpers.c:116) ==28664== by 0x489067: cpms_query_ready (mm-broadband-modem.c:5430) ==28664== by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2) ==28664== by 0x44EADF: at_command_ready (mm-base-modem-at.c:503) ==28664== by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2) ==28664== by 0x4D8122: serial_command_ready (mm-port-serial-at.c:392) ==28664== by 0x5E8E335: g_simple_async_result_complete (in /usr/lib/libgio-2.0.so.0.5200.2) (cherry picked from commit 14dbbad1ad0e18be3e9623b357fc9a0daf02d6da)
* port-serial: plug memleak on error processingAleksander Morgado2017-07-181-0/+1
| | | | | | | | | | | | | | | | | | ==28664== 216 (120 direct, 96 indirect) bytes in 5 blocks are definitely lost in loss record 4,109 of 4,317 ==28664== at 0x4C2BEEF: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==28664== by 0x644E018: g_malloc (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x6465B05: g_slice_alloc (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x6469C32: g_string_sized_new (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x4D7861: parse_response (mm-port-serial-at.c:142) ==28664== by 0x4D3B52: parse_response_buffer (mm-port-serial.c:857) ==28664== by 0x4D40F2: common_input_available (mm-port-serial.c:981) ==28664== by 0x4D41B4: iochannel_input_available (mm-port-serial.c:1004) ==28664== by 0x64488B4: g_main_context_dispatch (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x6448C77: ??? (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x6448F91: g_main_loop_run (in /usr/lib/libglib-2.0.so.0.5200.2) ==28664== by 0x438035: main (main.c:180) (cherry picked from commit bad79cb5e1063fcb269543c07a7be5b32762b3cb)
* zte,icera: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit 5ee0b32298b0d3d1ce1199d0e3addf394df005d5)
* zte: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit 7b392398e4c0a0e2084b49e50bb6566357db3699)
* simtech: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit ef274b5fa2f9911caa55103282088c35ec66f8ec)
* option,hso: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit a3c980c78b32ba53d1373e07e2535a7e15b03ebb)
* option: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit f3a301db3c62ebe1ed1a89aa2d98765ac66759fc)
* mtk: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit e2246da507c4f93ec2f0f885586e6e5748cb829d)
* mbm: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit 15a221e88d57be200fcc45599c994b14f5376e4c)
* altair-lte: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit 0be6e7d2ea41b97caeb086040e2d50d11fb28a91)
* icera: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit c44fa6c681a6417f174b947076085224b2dc97dd)
* huawei: skip unrequired explicit casts to GSimpleAsyncResultAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit f1f313c214ccc3e5b62ec17cf039b6a4a693c9d0)
* huawei: fix async completion in 3gpp event handlers settingAleksander Morgado2017-07-171-3/+2
| | | | (cherry picked from commit 91bbcb5c5f708628688c2a429b81b3f035c1c567)
* huawei: fix async completion in voice event handlers settingAleksander Morgado2017-07-171-3/+2
| | | | (cherry picked from commit c0c2e8aae8de4d72dd483c742462032ffc2f7d30)
* huawei: fix async completion in cdma event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit 7b0c0bc96bf501a261de2a30bf0095c61ea3ef16)
* via: fix async completion in cdma event handlers settingAleksander Morgado2017-07-171-2/+2
| | | | (cherry picked from commit 24e8785a83eb9ac88a36b58c0c5ba83a4689800b)
* libmm-glib,voice: fix object unref in list_call_context_complete_and_freeBen Chan2017-06-231-1/+1
| | | | (cherry picked from commit 9920f868ebb4d3a1b645cccf2f473d5d51b4c29e)
* libmm-glib,modem: fix object unref in list_bearers_context_complete_and_freeBen Chan2017-06-231-1/+1
| | | | (cherry picked from commit c927c0236e5762ef9244c8e3369acd2cf1cf21a3)
* libmm-glib,messaging: fix object unref in list_sms_context_complete_and_freeBen Chan2017-06-231-1/+1
| | | | (cherry picked from commit 8c1bc84af8f52ebdef25d464c28146987cf80c00)
* systemd: drop After=syslog.target ruleAleksander Morgado2017-06-181-1/+0
| | | | | | | | | syslog implementations are using socket activation nowadays, so an explicit ordering is not necessary anymore. Plus, syslog.target was already dropped from systemd in v198. Reported-by: Michael Biebl <biebl@debian.org> (cherry picked from commit 0e854644dbd896577eaa8f9b05c10aa6283b9533)
* build: post release version bump to 1.6.9Aleksander Morgado2017-06-171-1/+1
|
* release: bump version to 1.6.81.6.8Aleksander Morgado2017-06-171-1/+1
|
* NEWS: update for 1.6.8Aleksander Morgado2017-06-171-0/+24
|
* bearer-qmi: fix build with libqmi 1.16Aleksander Morgado2017-06-171-6/+28
| | | | | | | | | MM 1.6 depends on at least libqmi 1.16, so the build should go on with that minimum version. The 1.6.6 release was failing because the WDS Event Report Indications were being enabled unconditionally, and these were only supported since libqmi 1.18. Reported-by: Michael Biebl <biebl@debian.org>
* telit: fix #PSNT values interpretation for HSDPA and LTE modemsDaniele Palmas2017-06-161-1/+10
| | | | | | | | | | | Telit LTE modems use #PSNT: 4 for LTE access technology, and #PSNT: 5 for unknown access technology, while HSDPA modems use #PSNT: 4 for unknown access technology. This patch fixes those #PSNT values interpretation according to the modem capabilities. (cherry picked from commit 4dbea97e1bb74ddf1a1cee15892d18a2bdafa003)
* telit: add LTE access technology reportingDan Williams2017-06-161-0/+3
| | | | (cherry picked from commit ab48dc5b17f90f12e82ccdd58a40d137858e1490)
* modem-helpers: new uint list parser, including interval supportAleksander Morgado2017-06-163-0/+147
| | | | (cherry picked from commit 3a886d848dadd98eda8dff354c1d10450d7613fe)
* helpers: extend +WS46=? response parser to support rangesDaniele Palmas2017-06-162-13/+44
| | | | | | | | | | Telit LTE modems could reply to +WS46=? with: +WS46: (12,22,25,28-31) This patch extends +WS46=? response parser to support ranges. (cherry picked from commit 58206664959a73deb8008b82b5070edb4ef87df2)
* broadband-modem-qmi: allow prefix match for Modem images ending with '?'Dan Williams2017-06-141-1/+23
| | | | | | | Assume that a modem image build_id "02.08.02.00_?" matches a pri build_id of "02.08.02.00_ATT" or "02.08.02.00_GENERIC". (cherry picked from commit e37e81c2e40b0ddfaa0b8d0075aa83b962d7c32e)
* huawei: let the E3372 run NDISDUP via TTYAleksander Morgado2017-06-021-0/+3
| | | | | | | | | | | This modem ends up exposing a cdc-wdm port and a WWAN network interface, but the cdc-wdm port is totally unusable, it won't reply to any AT command or anything. Instead this modem can do NDISDUP via TTY, which is what the Windows drivers are also doing. (cherry picked from commit b5e94185bb487d39f75537755c1ea03b40737ca8)
* mbm: fix async method completion enabling unsolicited eventsAleksander Morgado2017-05-211-0/+1
| | | | (cherry picked from commit a6909379024fcdd48275aa89372b574b867a40d6)
* blacklist: ignore default Linux USB Serial GadgetAleksander Morgado2017-05-181-0/+3
| | | | | | | | | | | | | | | | | Blacklist the default VID:PID for the Linux USB Serial Gadget in ACM mode: {LINUX}/drivers/usb/gadget/legacy/serial.c #define GS_VENDOR_ID 0x0525 /* NetChip */ #define GS_CDC_PRODUCT_ID 0xa4a7 /* ... as CDC-ACM */ This should never be reused for real products by hardware manufacturers, but anyway... Patch actually ported from downstream Ubuntu: https://bugs.launchpad.net/ubuntu/+source/modemmanager/+bug/1105352 (cherry picked from commit cab81f679f08beefc85a7582990cce2f276b6190)
* iface-modem: fix setting up signal quality retrieval logicAleksander Morgado2017-05-151-3/+3
| | | | | | | | | If going directly e.g. from "Searching" to "Connecting", just setup the signal quality retrieval logic right away, don't assume we always go through "Registered" state before starting a connection. Reported-by: <colin.helliwell@ln-systems.com> (cherry picked from commit e8acfe0296d2883f6f337cb71fd809cc2c90f564)
* build: post release version bump to 1.6.7Aleksander Morgado2017-05-111-1/+1
|
* release: bump version to 1.6.61.6.6Aleksander Morgado2017-05-111-1/+1
|
View Lorry Controller Status