summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* cli: avoid attempting to setup timeout on NULL proxymm-1-14Aleksander Morgado2021-04-121-1/+2
| | | | | | | mm_manager_get_proxy() may actually return NULL if creating the internal GDBusProxy for the Manager interface fails. (cherry picked from commit 5a735317f7c0c42b2ddce52dbf1fa1edfc1c41f4)
* shared-qmi: acquisition order preference TLV always same itemsAleksander Morgado2021-03-153-81/+100
| | | | | | | | | | | | The acquisition order preference TLV must always have the same number of elements, just the order of the elements should be different. Also, always prefer the acquisition order preference TLV to the GSM+WCDMA specific one, which is the same logic the modem applies. Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/340 (cherry picked from commit fdfd4b270aa3bb31185feb833691f134c887f869)
* shared-qmi: process all feature checks in SSP response togetherAleksander Morgado2021-03-151-7/+14
| | | | | | | | Loading capabilities is the very first step of the state machines, and so we can rely on the "NAS Get SSP" method performed there to process all feature checks of the SSP response. (cherry picked from commit bb5bc9c8c560a24ef2951bdb9e1da18dedd7c5b0)
* shared-qmi: if getting TP/SSP fails, assume unsupportedAleksander Morgado2021-03-151-2/+2
| | | | | | | | | | | | Until now we were only considering TP/SSP unsupported if we received a QMI protocol error (e.g. reporting unknown command). We now also consider TP/SSP unsupported if the actual request succeeds, but an error is reported in the response. There is no point in considering TP/SSP supported if the plain get request without input TLVs given fails. (cherry picked from commit 65a7624ffdd39b015d5013743913af8361e83513)
* shared-qmi: add missing feature check flag initialization to UNKNOWNAleksander Morgado2021-03-151-0/+1
| | | | (cherry picked from commit 1a5f90f15bda7b939c75c6b8c7d0022c8f919b42)
* shared-qmi: rename feature check variablesAleksander Morgado2021-03-151-34/+34
| | | | | | | We want the "extended_lte_band_preference" with the "nas_ssp" prefix, as we're going to add more checks for SSP features. (cherry picked from commit 67b64eb7eeab5c50381014945cfbd73ebc4cbe11)
* build: post-release version bump to 1.14.13Aleksander Morgado2021-03-121-1/+1
|
* release: bump version to 1.14.121.14.12Aleksander Morgado2021-03-121-1/+1
|
* NEWS: update for 1.14.12Aleksander Morgado2021-03-121-0/+12
|
* bearer-mbim: plug MbimDevice leak in disconnection contextAleksander Morgado2021-03-111-0/+1
| | | | (cherry picked from commit a772b70632008d6c375487a8e711b80bb343a931)
* shared-qmi: network registration cancellation logic with asserts disabledAleksander Morgado2021-02-261-1/+1
| | | | | | | g_assert() calls may be disabled, and if so, the network registration task would never get completed. (cherry picked from commit c7d366671f749689c143f7effe2a183eb710def9)
* bearer-mbim: IP type may be reported as deactivated and still have IP settingsAleksander Morgado2021-02-231-20/+41
| | | | | | | | | | | | | If we were requesting for IPv4v6 and we only got IPv4 reported as activated, we would right away ignore the IPv6 bits, even if we received IPv6 settings later on when querying for them. Change that, so that if an IP address of a given type is received, we assume the corresponding context was really activated even if the modem didn't report it in the connect set response. Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/320 (cherry picked from commit a546201470ee1067be5494ab5f678016bb2bc2ec)
* build: post-release version bump to 1.14.11Aleksander Morgado2021-01-161-1/+1
|
* release: bump version to 1.14.101.14.10Aleksander Morgado2021-01-161-1/+1
|
* NEWS: update for 1.14.10Aleksander Morgado2021-01-161-0/+30
|
* zte: add 1 second delay after sim unlock to avoid IMSI reading issueLouis-Alexis Eyraud2021-01-161-6/+14
| | | | | | | Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/306 Signed-off-by: Louis-Alexis Eyraud <louis-alexis.eyraud@sigfox.com> (cherry picked from commit 9c353cf6f0a7650cfe1b914d6881890de9dff0b0)
* iface-modem: avoid leaking the MmGdbusModem when bearers are updatedAleksander Morgado2021-01-131-0/+1
| | | | | | See See https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/302 (cherry picked from commit d12ab8a25a60323a753e3437c81a984a503deb40)
* telit: plug GPS data port leakAleksander Morgado2021-01-131-1/+1
| | | | | | | | | The _get_port_gps() returns a full reference, use _peek_port_gps() instead. See https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/302 (cherry picked from commit 102de14c15b1c278988de376d03262bcb078211d)
* mmcli: don't assume that mm_object_peek_modem or mm_object_get_modem return ↵Frederic Martinsons2021-01-132-3/+10
| | | | | | | | | | | | | non null This very peculiar case can happen when an intermediate initiliazition step of a modem fails. The ModemManager daemon should always expose the modem interface but let not assume that in mmcli and protect these calls. Signed-off-by: Frederic Martinsons <frederic.martinsons@sigfox.com> (cherry picked from commit 18b72a046e89d00d7e7b9f2d718c43d64e595de0)
* iface-modem: don't consider charset setup failure as fatal.Frederic Martinsons2021-01-131-6/+1
| | | | | | | | | | | | | | On some modem (for example SORACOM SC-QGLC4-C1) , the character set setup step fails with "Unknown error" when the SIM card is missing or locked. This leads to not expose Modem interface and not being able to unlocked the SIM. We should not consider this step as fatal but just issue a warning to let other steps continue (which will let modem in failed state anyway). Closes #289 Signed-off-by: Frederic Martinsons <frederic.martinsons@sigfox.com> (cherry picked from commit 2f53a08e5f1eef8c1892dc55f32fbacba85565a0)
* cinterion: add AT primary/secondary port type hints for PLS8Aleksander Morgado2021-01-131-0/+2
| | | | (cherry picked from commit 243272c11178e68914d7cc2dcfdc28248edb2aa7)
* cinterion: add QCDM and GPS port type hints for PLS62Aleksander Morgado2021-01-131-10/+10
| | | | (cherry picked from commit ba4b3f60b7605441bb127be231eab49450c29404)
* cinterion: add PLS83 port type hintsAleksander Morgado2021-01-131-0/+10
| | | | (cherry picked from commit 067b09c8358ad92ff0ca3c266d0229e9518069d0)
* broadband-modem-mbim: ignore MS SAR notifications explicitlyAleksander Morgado2020-12-191-0/+3
| | | | | | | SAR service will be introduced in the stable libmbim 1.26.0, but it's been flagged in the dev 1.25.1 version already. (cherry picked from commit bee8a391bf46e33f8378504f71c4e087d7a82fb5)
* broadband-modem-mbim: plug memleak when processing USSD in GSM7Aleksander Morgado2020-12-191-2/+2
| | | | (cherry picked from commit 0729ba5c88eb038e60ffbe3faf9431e9650f7ca1)
* broadband-modem-qmi: fix reporting of signal strength indicationsAleksander Morgado2020-12-021-0/+1
| | | | | | | | | | | | We had all the logic in place... but we were never actually enabling the signal strength indications because the `enable` flag in the context was never set. The bug was introduced back in May 2018, and released with 1.10.0. Fixes baefe53ab9c0ea0612d2bf7da64b6f6cf9753bcd (cherry picked from commit 12dd53a12e81e4f4752ded5579a52751141461ca)
* sms: fix 7-bit ASCII SMS decodingDavid Leonard2020-11-201-1/+1
| | | | | | | | | | Fixes an issue where (5+8n)-character long SMS messages received on a CDMA network would be dropped with a "cannot read user data" error, while other length SMS messages would be delivered fine. Fix thanks to Peter Hunt (cherry picked from commit 7ac42e76482acd687464f9dca2ef3ac7b67825a1)
* build: post-release version bump to 1.14.9Aleksander Morgado2020-11-161-1/+1
|
* release: bump version to 1.14.81.14.8Aleksander Morgado2020-11-161-1/+1
|
* NEWS: update for 1.14.8Aleksander Morgado2020-11-161-0/+18
|
* kerneldevice,generic: plug cached string leaksAleksander Morgado2020-11-091-7/+9
| | | | | | Both 'physdev_subsystem' and 'interface_description' were leaking. (cherry picked from commit 37b3771ef5003adb1797c29deceb6500ebe60e6d)
* build: fix distcheck with new gtk-docAleksander Morgado2020-11-082-0/+2
| | | | | | | | | | The .actions file is generated by newer gtk-doc releases, we just treat it as e.g. the .signals or .types files. This is also already fixed in upstream gtk-doc: https://gitlab.gnome.org/GNOME/gtk-doc/-/merge_requests/61 (cherry picked from commit 50c69d540341733dfee031282e5d8e18ebc814cb)
* build: do not require xsltproc when building from a release tarballAleksander Morgado2020-11-081-3/+6
| | | | | | Fixes https://gitlab.freedesktop.org/mobile-broadband/ModemManager/-/issues/276 (cherry picked from commit 904adbfb5e07e538516c26b8467c2238fc2718e9)
* build: don't remove ModemManager-names.h on 'clean'Aleksander Morgado2020-11-081-1/+1
| | | | | | | | | | The ModemManager-names.h header file is generated on git builds, and shipped within the release tarball, so treat it as a maintainer managed file that should only be removed on 'maintainer-clean'. This allows us to avoid requiring xsltproc to build release tarballs. (cherry picked from commit 3bda0562b94aa56177f0e481cd29e4149f5a531d)
* mm-kernel-device: Fix cmp to exclude subtypesAndrew Lassalle2020-11-081-1/+1
| | | | | | | | | If multiple kernel device types inherit from MMKernerDevice, and those are compared against each other, the current logic returns TRUE if the G_OBJECT_TYPE of one of them is smaller than the other. This function is checking for equality, so returning FALSE is enough. (cherry picked from commit d7288861a595db7f07b8ecf6bdc30d957b8b6843)
* base-modem: sort port info array by port nameAleksander Morgado2020-11-081-18/+28
| | | | | | | | | | | | | | | | | So that the list of ports shown in the Ports DBus property is also alphabetically sorted by port name, instead of having a mess like this: ----------------------------- System | device: qcom-soc | drivers: bam-dmux | plugin: qcom-soc | primary port: rpmsg0 | ports: rmnet5 (net), rmnet_usb0 (unknown), rmnet4 (net), | rpmsg1 (at), rmnet3 (net), rpmsg0 (qmi), rmnet2 (net), rmnet1 (net), | rmnet7 (net), rmnet0 (net), rmnet6 (net) (cherry picked from commit c385031941c9cd1ce07ae2d5b37ded26e4838dae)
* log: ignore fatal flag for logging purposesAleksander Morgado2020-11-081-0/+5
| | | | | | | Running with G_DEBUG=fatal-warnings will end up reporting warning logs with G_LOG_FLAG_FATAL, which breaks our own logging logic. (cherry picked from commit a31d762250edba7bbad34adec051d9cff0279f66)
* broadband-modem-qmi: fix crash when device removed during initAleksander Morgado2020-10-211-8/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | If the modem goes away (ports removed) during the initialization phase (e.g. while QMI clients are being allocated), the MMPortQmi object will be closed and it will lose its internal QmiDevice. We should therefore consider the lack of QmiDevice a valid usecase in track_qmi_device_removed() and return a GError when that happens. #0 0x00007fb544618cc9 in raise () from /lib/libc.so.6 #1 0x00007fb54461bd68 in abort () from /lib/libc.so.6 #2 0x00007fb544e2213d in g_assertion_message () from /usr/lib/libglib-2.0.so.0 #3 0x00007fb544e221ba in g_assertion_message_expr () from /usr/lib/libglib-2.0.so.0 #4 0x00000000004be584 in track_qmi_device_removed () #5 0x00000000004be5e3 in allocate_next_client () #6 0x00000000004be7b1 in qmi_port_allocate_client_ready () #7 0x00007fb5453690a3 in g_task_return_now () from /usr/lib/libgio-2.0.so.0 #8 0x00007fb54536967e in g_task_return () from /usr/lib/libgio-2.0.so.0 #9 0x00000000004dd8f8 in allocate_client_ready () #10 0x00007fb5453690a3 in g_task_return_now () from /usr/lib/libgio-2.0.so.0 #11 0x00007fb54536967e in g_task_return () from /usr/lib/libgio-2.0.so.0 #12 0x00007fb54591d4de in allocate_cid_ready () from /usr/lib/libqmi-glib.so.5 ... (cherry picked from commit 8a54baa346c7fe375b2683e2e333104acf648eff)
* broadband-modem-qmi: minor coding style fixesAleksander Morgado2020-10-211-3/+3
| | | | (cherry picked from commit 1ed9f7e94e5948f408d1d09ad8c219a594669066)
* build: post-release version bump to 1.14.7Aleksander Morgado2020-10-141-1/+1
|
* release: bump version to 1.14.61.14.6Aleksander Morgado2020-10-141-1/+1
|
* NEWS: update for 1.14.6Aleksander Morgado2020-10-141-0/+13
|
* xmm: fix missing GError initializationAleksander Morgado2020-10-141-2/+2
| | | | (cherry picked from commit f013e94ff89680d1acd7dba12ff4a6a0fa7b58bf)
* simtech: fix missing GError initializationAleksander Morgado2020-10-141-2/+2
| | | | (cherry picked from commit 3b6176cbe2bc64bbf19fa0378b1c65b646bb6d13)
* cinterion: fix missing GError initializationAleksander Morgado2020-10-141-2/+2
| | | | (cherry picked from commit 50c1550c9f808ddd080f7992bf2d7f4dfae6e0ec)
* broadband-modem-qmi: ensure GError is initialized to NULLAleksander Morgado2020-10-141-1/+1
| | | | | | | | | | | | | (ModemManager:21568): GLib-WARNING **: 22:11:27.828: GError set over the top of a previous GError or uninitialized memory. This indicates a bug in someone's code. You must ensure an error is NULL before it's set. The overwriting error message was: QMI protocol error (94): 'NotSupported' [21568]: <warn> [1582841487.829678] [modem0] couldn't load facility locks: (NULL) [21568]: <debug> [1582841487.830746] [modem0] loading UE mode of operation for EPS... [21568]: <debug> [1582841487.832138] [modem0/ttyUSB2/at] device open count is 2 (open) Segmentation fault This issue is only applicable in the mm-1-14 branch. Fixes cd686f10e049cf0494678f4d87e17e62e8f53e76.
* build: post-release version bump to 1.14.5Aleksander Morgado2020-10-141-1/+1
|
* release: bump version to 1.14.41.14.4Aleksander Morgado2020-10-141-1/+1
|
* NEWS: update for 1.14.4Aleksander Morgado2020-10-141-0/+35
|
* iface-modem-3gpp: print consolidated reg state info only when updatingAleksander Morgado2020-10-141-52/+34
| | | | (cherry picked from commit c6f38ecac3ed2ac783dbab706c5e155ba7409747)