summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* broadband-bearer-mbm: connect errors should trigger a disconnectdcbw/mbm-connect-disconnect-cleanupDan Williams2016-05-111-4/+34
| | | | | | Otherwise we may leave a bearer connected when ModemManager doesn't think it's connected. Prevents a CME ERROR 277 loop on connect when the bearer hasn't been torn down correctly.
* broadband-bearer-mbm: wait for disconnect to completeDan Williams2016-05-111-13/+130
| | | | | | | | | | | Wait for either an E2NAP unsolicited disconnect status or (for older devices) an ENAP poll response before completing the disconnect. Otherwise the client may start connecting again (such as NetworkManager autoconnect retry) and the unsolicited E2NAP may abort it, or the modem may return CME ERROR 277 ("not disconnected yet") for the next connection attempt. https://bugs.freedesktop.org/attachment.cgi?id=123525
* broadband-bearer-mbm: simplify dial_3gpp connection setup flowDan Williams2016-05-111-185/+112
| | | | | | | | | | | | | | | | | | | | | | | | | | There are a few key parts to this patch: 1) move the poll id into the Dial3gppContext structure as it is conceptually part of the connection context data. This simplifies context cleanup by keeping the poll id cleanup in one place. 2) move unsolicited connection status (E2NAP) handling into the normal connection codepath, instead of completing the connection context from the report_connection_status() E2NAP handler. This simplifies connect code by not requiring checks for a NULL context everywhere, and allows us to pass the Dial3gppContext structure around instead of the Bearer object, since the Dial3gppContext will never be comleted/freed outside the normal connection flow codepaths like GLib idles and AT command requests. 3) use the connect context cancellable for all AT command requests in the connect path. This lets us use the error return from mm_base_modem_at_command_full_finish() to handle cancellation and also not bother listening to the 'cancelled' signal of the cancellable, since we can just check for cancellation the next time the ENAP poll function runs. https://bugs.freedesktop.org/show_bug.cgi?id=95304
* mbm: clean up the context on activate_readyLubomir Rintel2016-05-101-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Otherwise the dangling pointer to the context that's being deallocated causes a crash on spontaneous E2NAP receipt: ModemManager[1567]: <info> [1462468083.031326] [mm-iface-modem.c:1431] __iface_modem_update_state_internal(): Modem /org/freedesktop/ModemManager1/Modem/0: state changed (connecting -> registered) ModemManager[1567]: <debug> [1462468083.053745] [mm-port-serial-at.c:459] debug_log(): (ttyACM0): <-- '<CR><LF>*E2NAP: 0,36<CR><LF>' ModemManager[1567]: <debug> [1462468083.053857] [mbm/mm-broadband-modem-mbm.c:824] e2nap_received(): disconnected (ModemManager:1567): GLib-GIO-CRITICAL **: g_simple_async_result_set_error: assertion 'G_IS_SIMPLE_ASYNC_RESULT (simple)' failed Program received signal SIGTRAP, Trace/breakpoint trap. g_logv (log_domain=0x7ffff7086798 "GLib-GIO", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffcda0) at gmessages.c:1046 1046 g_private_set (&g_log_depth, GUINT_TO_POINTER (depth)); Missing separate debuginfos, use: debuginfo-install libmbim-1.12.4-2.el7.centos.x86_64 libqmi-1.14.2-1.el7.centos.x86_64 (gdb) bt #0 0x00007ffff6a508c3 in g_logv (log_domain=0x7ffff7086798 "GLib-GIO", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=args@entry=0x7fffffffcda0) at gmessages.c:1046 #1 0x00007ffff6a50a3f in g_log (log_domain=log_domain@entry=0x7ffff7086798 "GLib-GIO", log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7ffff6abe73d "%s: assertion '%s' failed") at gmessages.c:1079 #2 0x00007ffff6a50a79 in g_return_if_fail_warning (log_domain=log_domain@entry=0x7ffff7086798 "GLib-GIO", pretty_function=pretty_function@entry=0x7ffff7092ce0 <__FUNCTION__.13394> "g_simple_async_result_set_error", expression=expression@entry=0x7ffff7092a40 "G_IS_SIMPLE_ASYNC_RESULT (simple)") at gmessages.c:1088 #3 0x00007ffff6ff9d3d in g_simple_async_result_set_error (simple=0x7fffe8006e40, domain=297, code=0, format=0x7ffff175b53f "Call setup failed") at gsimpleasyncresult.c:719 #4 0x00007ffff17569ea in report_connection_status (bearer=0x7fffe4008a40 [MMBroadbandBearerMbm], status=MM_BEARER_CONNECTION_STATUS_DISCONNECTED) at mbm/mm-broadband-bearer-mbm.c:174 #5 0x000055555559c9f1 in mm_base_bearer_report_connection_status (self=0x7fffe4008a40 [MMBroadbandBearerMbm], status=MM_BEARER_CONNECTION_STATUS_DISCONNECTED) at mm-base-bearer.c:1118 #6 0x00007ffff17548ed in bearer_list_report_status_foreach (bearer=0x7fffe4008a40 [MMBroadbandBearerMbm], ctx=0x7fffffffd060) at mbm/mm-broadband-modem-mbm.c:805 #7 0x00007ffff6a45f18 in g_list_foreach (list=<optimized out>, func=0x7ffff17548c9 <bearer_list_report_status_foreach>, user_data=0x7fffffffd060) at glist.c:994 #8 0x00005555555a224b in mm_bearer_list_foreach (self=0x5555558e0680 [MMBearerList], func=0x7ffff17548c9 <bearer_list_report_status_foreach>, user_data=0x7fffffffd060) at mm-bearer-list.c:146 #9 0x00007ffff1754a3d in e2nap_received (port=0x5555558e24c0 [MMPortSerialAt], info=0x555555935730, self=0x555555900330 [MMBroadbandModemMbm]) at mbm/mm-broadband-modem-mbm.c:850 #10 0x000055555563d9fd in parse_unsolicited (port=0x5555558e24c0 [MMPortSerialAt], response=0x7fffe80054f0) at mm-port-serial-at.c:280 #11 0x0000555555639915 in parse_response_buffer (self=0x5555558e24c0 [MMPortSerialAt]) at mm-port-serial.c:889 #12 0x0000555555639f0b in common_input_available (self=0x5555558e24c0 [MMPortSerialAt], condition=G_IO_IN) at mm-port-serial.c:1019 #13 0x0000555555639fc7 in iochannel_input_available (iochannel=0x555555926df0, condition=G_IO_IN, data=0x5555558e24c0) at mm-port-serial.c:1042 #14 0x00007ffff6a4979a in g_main_context_dispatch (context=0x5555558a4a00) at gmain.c:3109 #15 0x00007ffff6a4979a in g_main_context_dispatch (context=context@entry=0x5555558a4a00) at gmain.c:3708 #16 0x00007ffff6a49ae8 in g_main_context_iterate (context=0x5555558a4a00, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at gmain.c:3779 #17 0x00007ffff6a49dba in g_main_loop_run (loop=0x5555558acf10) at gmain.c:3973 #18 0x000055555558d068 in main (argc=2, argv=0x7fffffffdc38) at main.c:181 (gdb) https://bugzilla.redhat.com/show_bug.cgi?id=1333293 https://bugs.freedesktop.org/show_bug.cgi?id=95303
* mtk: add D-Link DWM-156 A3Lubomir Rintel2016-05-041-0/+6
|
* build: modified Telit and Dell sectionsDaniele Palmas2016-05-031-6/+22
| | | | | This patch adds section for building Telit common code and modifies Dell section for using Telit library
* dell: add udev rules for 413c/81baDaniele Palmas2016-05-031-0/+16
| | | | | udev rules for Dell-branded 413c/81ba Telit modem are used for dynamic port configuration in Telit plugin custom init
* dell: add Telit manufacturerDaniele Palmas2016-05-031-2/+51
| | | | Dell-branded AT based Telit modems should use Telit plugin functions
* telit: code refactoringDaniele Palmas2016-05-033-298/+360
| | | | | This patch moves init and port grabbing functions to a separate file to allow functions call from Dell plugin
* bearer-mbim: fine-tune bearer IP method reportingDan Williams2016-05-032-28/+54
| | | | | | | | | | | | | | v4: modems/providers may not return DNS servers and not all modems support DHCP, so lack of DNS servers should not indicate a bearer IP method of "DHCP". IP config daemon/scripts already have to handle missing DNS anyway. v6: IPv6 requires SLAAC or DHCPv6 as part of the specification, so for now we assume modems will support it. Provide all the info the modem sent, but if there is any missing information use an IP method of "DHCP" to indicate that info should be obtained via SLAAC/DHCPv6. Only use an IP method of "STATIC" when all basic properties are given by the modem.
* libmm-glib,common-helpers: fix reading boolean from stringAleksander Morgado2016-04-191-5/+6
| | | | | | The "0" case wasn't being handled properly: $ sudo mmcli -m 0 --create-bearer="apn=,allow-roaming=0" Error parsing properties string: 'Cannot get boolean from string '0''
* release: bump version to 1.5.992 (1.6-rc3)1.6-rc3Aleksander Morgado2016-04-181-1/+1
|
* NEWS: include QMI network disconnectionsAleksander Morgado2016-04-181-0/+1
|
* bearer-qmi: listen for Packet Service Status indication and handle disconnectionDan Williams2016-04-151-0/+139
| | | | | Hook up to the WDS Packet Service Status indication, listen for disconnection events, and disconnect the bearer when we get one.
* huawei: fix reading IPv4 address in BE systemsAleksander Morgado2016-04-131-1/+1
| | | | | | Tested by: <than@redhat.com> https://bugs.freedesktop.org/show_bug.cgi?id=94777
* port-probe: fix missing task disposalsAleksander Morgado2016-04-131-0/+2
|
* port-probe: make sure stored task pointer is set to NULL before completingAleksander Morgado2016-04-081-84/+100
| | | | | | | | | | | | | | | | | | | | When we were completing tasks in idle, the logic was like this: * Schedule task completion in idle * self->priv->task = NULL * (idle) Task completion callback called This meant that the self->priv->task was always set to NULL before the completion callback was called, which is what we wanted as a new task may be scheduled in the callback itself. Now, without completing in idle, we were wrongly doing: * Task completion callback called * self->priv->task = NULL This commit fixes the logic by making sure self->priv->task = NULL before any task completion.
* dell: fixed cgmi_retries in dell_custom_initCarlo Lobrano2016-04-061-1/+2
| | | | | | | | | | Initialized "cgmi_retries" variable from CustomInitContext with the same value as the other retries, moreover the context is now allocated with g_slice_new0. Before this changes, when cgmi_retries assumed big values during the probing of no AT-capable ports, the command AT+CGMI (mm-plugin-dell.c:custom_init_step) was sent a semi-infinite number of times, blocking the plugin's initialization.
* build: make '--with-suspend-resume' auto by defaultAleksander Morgado2016-04-031-7/+17
| | | | If systemd is found, enable suspend resume support.
* build: use 'no' to disable suspend/resume support, instead of 'none'Aleksander Morgado2016-04-031-3/+3
|
* build: use 'no' to disable polkit, instead of 'none'Aleksander Morgado2016-04-031-6/+4
|
* device: port probe may be in the ignored listAleksander Morgado2016-03-271-2/+7
|
* context: use G_OPTION_ARG_FILENAME when a file path is expectedAleksander Morgado2016-03-272-3/+3
|
* context: fix --help outputAleksander Morgado2016-03-271-2/+2
| | | | | | | | | | | | The options that require an argument should explicitly specify so. Before: --log-level=INFO Log level: one of [ERR, WARN, INFO, DEBUG] --log-file Path to log file After: --log-level=[LEVEL] Log level: one of ERR, WARN, INFO, DEBUG --log-file=[PATH] Path to log file
* base-modem: remove unused 'mm_base_modem_get_port()' methodAleksander Morgado2016-03-272-27/+0
|
* base-modem: remove unused 'mm_base_modem_owns_port()' methodAleksander Morgado2016-03-272-11/+0
|
* base-modem: remove unused 'mm_base_modem_release_port()' methodAleksander Morgado2016-03-272-85/+0
|
* serial: do not restore termios on port closeTomas Jura2016-03-261-10/+0
|
* release: bump version to 1.5.991 (1.6-rc2)1.6-rc2Aleksander Morgado2016-03-251-1/+1
|
* libmm-glib: fix enum conversion warning/errorBrian Norris2016-03-251-1/+1
| | | | | | | | | | | | | mm-modem-oma.c:400:51: error: implicit conversion from enumeration type 'MMOmaSessionType' to different enumeration type 'MMOmaFeature' [-Werror,-Wenum-conversion] g_return_val_if_fail (MM_IS_MODEM_OMA (self), MM_OMA_SESSION_TYPE_UNKNOWN); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /usr/include/glib-2.0/glib/gmessages.h:382:11: note: expanded from macro 'g_return_val_if_fail' return (val); \ ~~~~~~ ^~~ This should be MMOmaFeature, not MMOmaSessionType. The end result is the same, as both are 0.
* po: sleep monitor source file was renamedAleksander Morgado2016-03-231-1/+1
| | | | Reported by: Michael Biebl <biebl@debian.org>
* port-probe: unlink the task from probe before completing itLubomir Rintel2016-03-221-2/+5
| | | | | | | | | The task completion may try to enqueue a next probe task and in mm_port_probe_run() it asserts there's no task linked. https://bugs.freedesktop.org/show_bug.cgi?id=94664 Fixes: 1939c5ace50240127276efacec5c7f166483bb79
* build: rename sleep monitor source file, only one implementation availableAleksander Morgado2016-03-212-1/+1
|
* UPower signaling obsolescencepoma2016-03-213-161/+2
| | | | | | | | | | | | "Newer upower versions no longer emit that signal since this handled by systemd." by Michael Biebl <mbiebl@gmail.org> https://lists.freedesktop.org/archives/devkit-devel/2014-March/001575.html See also "Plans for UPower 1.0" by Richard Hughes <hughsient@gmail.com> https://lists.freedesktop.org/archives/devkit-devel/2013-January/001339.html Signed-off-by: poma <pomidorabelisima@gmail.com>
* cinterion: drop unused constantsLubomir Rintel2016-03-211-24/+0
| | | | GCC 6 doesn't like this. Unused since f2024b7.
* wmc: fix a typo in the testLubomir Rintel2016-03-211-2/+2
| | | | GCC 6 notices an unused constant and errors out.
* build: fix missing MMCLI_LIBS variableAleksander Morgado2016-03-211-1/+1
|
* build: run configure script from builddir rather than srcdirAleksander Morgado2016-03-211-3/+3
| | | | | | | Based on an equivalent patch from Philip Withnall <philip@tecnocode.co.uk> for libmbim; see: https://bugs.freedesktop.org/show_bug.cgi?id=94639
* release: bump version to 1.5.900 (1.6-rc1)1.6-rc1Aleksander Morgado2016-03-181-3/+3
| | | | Also bump soname of libmm-glib, as the interface has grown since the last tag.
* NEWS: update for 1.6.0Aleksander Morgado2016-03-181-0/+101
|
* build: require libmbim 1.12 and libqmi 1.14Aleksander Morgado2016-03-181-2/+2
| | | | | Preparing for the new ModemManager stable release, we now require the latest stable series of both libmbim and libqmi.
* libmm-glib,modem-voice: fix unknown methods in documentationAleksander Morgado2016-03-162-3/+3
| | | | | | | html/MMCallProperties.html:141: warning: no link for: 'mm-modem-voice-create' -> (<code class="function">mm_modem_voice_create()</code>). html/MMCallProperties.html:141: warning: no link for: 'mm-modem-voice-create-sync' -> (<code class="function">mm_modem_voice_create_sync()</code>). html/MMModemVoice.html:379: warning: no link for: 'mm-modem-voice-delete-finish' -> (<code class="function">mm_modem_voice_delete_finish()</code>). html/MMModemVoice.html:380: warning: no link for: 'mm-modem-voice-delete-sync' -> (<code class="function">mm_modem_voice_delete_sync()</code>).
* libmm-glib,modem-location: fix unknown method in documentationAleksander Morgado2016-03-161-1/+1
| | | | html/MMModemLocation.html:516: warning: no link for: 'mm-modem-dup-supl-server' -> (<code class="function">mm_modem_dup_supl_server()</code>).
* build: work around automake-1.15 & intltool complaining about translations ↵Dan Williams2016-03-151-0/+2
| | | | | | | | | | | | | | | in build dir make distcheck runs a build in dist directory subtirs and then runs intltool -m which in turn complains about translations in a built file: The following files contain translations and are currently not in use. Please consider adding these to the POTFILES.in file, located in the po/ directory. sub/data/org.freedesktop.ModemManager.policy.in The issue is reported to intltool upstream already: https://bugs.launchpad.net/intltool/+bug/1117944
* build,libmm-glib: built headers shouldn't be included in distAleksander Morgado2016-03-151-1/+1
|
* build: end all multiline list variables with $(NULL)Aleksander Morgado2016-03-155-41/+87
| | | | | So that appending a new item in the list only inserts one new line (i.e. the last $(NULL) is the last item always).
* build,plugins: update build rulesAleksander Morgado2016-03-151-333/+514
| | | | | | | | | | | | We try to combine in common envvars the compiler and linker flags shared by the different components, and where possible, also re-using the implicit AM_CFLAGS and AM_LDFLAGS variables that automake provides, and which apply to all objects being built in the same Makefile.am. The plugins build rules are also updated so that whenever a plugin has some testable 'helpers', these are compiled into a noinst library and then the new library included by both the plugin and the tester program. This avoids multiple recompilations of the same sources for different objects.
* build,core: update build rulesAleksander Morgado2016-03-154-274/+184
| | | | | | | | | We try to combine in common envvars the compiler and linker flags shared by the different components, and where possible, also re-using the implicit AM_CFLAGS and AM_LDFLAGS variables that automake provides, and which apply to all objects being built in the same Makefile.am. The internal libmodem-helpers.la library is also renamed to libhelpers.la
* build,libmm-glib: fix gdbus-codegen rulesAleksander Morgado2016-03-151-12/+45
| | | | | | | | | The rule with multiple targets means that for each of the target the command specified is run; not that a single run of the command generates all the targets specified. So, generate the .c file with the command, and make the .h and the .xml files a side-effect of the .c generation.
* modem-helpers: fix handling split PDP context ID reporting in CGDCONT=? responseDan Williams2016-03-152-1/+17
| | | | | Cinterion PHS8-US devices send split PDP context ID like "(1-17,101-112)" and that caused the modem-helpers to choke.
View Lorry Controller Status