summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDan Williams <dcbw@redhat.com>2016-06-01 11:33:33 -0500
committerDan Williams <dcbw@redhat.com>2016-06-01 11:34:13 -0500
commitf232afffe92e61b0c0471608ec55fa8e748196a2 (patch)
treed753fd9949f1fefa6d81c0861264b8bc6d2033b5
parenta5baec65be1b20e0d3a223c54ed79230b6d9509e (diff)
downloadModemManager-f232afffe92e61b0c0471608ec55fa8e748196a2.tar.gz
broadband-modem: document why firmware/OMA interfaces are left enabled in FAILURE state
-rw-r--r--src/mm-broadband-modem.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/src/mm-broadband-modem.c b/src/mm-broadband-modem.c
index e57195bee..e1fd7ca35 100644
--- a/src/mm-broadband-modem.c
+++ b/src/mm-broadband-modem.c
@@ -9795,13 +9795,16 @@ initialize_step (InitializeContext *ctx)
"Modem is unusable, "
"cannot fully initialize");
} else {
- /* Fatal SIM failure :-( */
+ /* Fatal SIM, firmware, or modem failure :-( */
g_simple_async_result_set_error (ctx->result,
MM_CORE_ERROR,
MM_CORE_ERROR_WRONG_STATE,
"Modem is unusable, "
"cannot fully initialize");
- /* Ensure we only leave the Modem interface around */
+ /* Ensure we only leave the Modem, OMA, and Firmware interfaces
+ * around. A failure could be caused by firmware issues, which
+ * a firmware update, switch, or provisioning could fix.
+ */
mm_iface_modem_3gpp_shutdown (MM_IFACE_MODEM_3GPP (ctx->self));
mm_iface_modem_3gpp_ussd_shutdown (MM_IFACE_MODEM_3GPP_USSD (ctx->self));
mm_iface_modem_cdma_shutdown (MM_IFACE_MODEM_CDMA (ctx->self));