summaryrefslogtreecommitdiff
path: root/morphlib/stagingarea.py
diff options
context:
space:
mode:
authorRichard Maw <richard.maw@codethink.co.uk>2013-08-06 14:53:26 +0000
committerRichard Maw <richard.maw@codethink.co.uk>2013-08-06 15:35:08 +0000
commit5261ebca7a0d4e3dfc86b9ad8655c2587e7d0548 (patch)
tree97c2dca250adc513f82b7548b8e981b137fcda88 /morphlib/stagingarea.py
parent4fa9c69157ee93e01d9a2cb3edd12ffc4e2708e1 (diff)
downloadmorph-5261ebca7a0d4e3dfc86b9ad8655c2587e7d0548.tar.gz
stagingarea: move to failed on construction fail
This uses the same logic as when a build fails, so it's been consolidated into `StagingArea.abort()`. You could argue that if a build fails before any commands are run, then there's nothing interesting to see, but it will be useful if the hardlink/tarball extract algorithm fails in some corner case.
Diffstat (limited to 'morphlib/stagingarea.py')
-rw-r--r--morphlib/stagingarea.py14
1 files changed, 14 insertions, 0 deletions
diff --git a/morphlib/stagingarea.py b/morphlib/stagingarea.py
index 9aa8021b..3d756df7 100644
--- a/morphlib/stagingarea.py
+++ b/morphlib/stagingarea.py
@@ -309,3 +309,17 @@ class StagingArea(object):
(self.dirname, ' '.join(argv)))
else:
return self._app.runcmd(argv, **kwargs)
+
+ def abort(self): # pragma: no cover
+ '''Handle what to do with a staging area in the case of failure.
+ This may either remove it or save it for later inspection.
+ '''
+ # TODO: when we add the option to throw away failed builds,
+ # hook it up here
+
+
+ dest_dir = os.path.join(self._app.settings['tempdir'],
+ 'failed', os.path.basename(self.dirname))
+ os.rename(self.dirname, dest_dir)
+ self.dirname = dest_dir
+