localrepocache: return error description

Also change _fetch to throw its exception as since it is more pythonic
to throw exceptions than return exit status, other error handling needed
to be caught, so it hsa been kept consistent.

This required the tests to throw an exception as well

1 files changed, 3 insertions, 2 deletions

diff --git a/morphlib/localrepocache_tests.py b/morphlib/localrepocache_tests.py
index 72f000f9..49dc021f 100644
--- a/morphlib/localrepocache_tests.py
+++ b/morphlib/localrepocache_tests.py
@@ -15,6 +15,7 @@
 
 
 import unittest
+import urllib2
 
 import morphlib
 
@@ -65,7 +66,7 @@ class LocalRepoCacheTests(unittest.TestCase):
         self.removed.append(filename)
 
     def not_found(self, url, path):
-        return False
+        raise urllib2.URLError('Not found')
 
     def fake_fetch(self, url, path):
         self.fetched.append(url)
@@ -135,6 +136,6 @@ class LocalRepoCacheTests(unittest.TestCase):
         self.assertFalse('/' in escaped)
 
     def test_noremote_error_message_contains_repo_name(self):
-        e = morphlib.localrepocache.NoRemote(self.repourl)
+        e = morphlib.localrepocache.NoRemote(self.repourl, [])
         self.assertTrue(self.repourl in str(e))