diff options
author | Sam Thursfield <sam.thursfield@codethink.co.uk> | 2015-07-28 15:23:09 +0000 |
---|---|---|
committer | Sam Thursfield <sam.thursfield@codethink.co.uk> | 2015-10-14 14:34:29 +0000 |
commit | b8b8de2b123ff96e6469196934359485bcd06b04 (patch) | |
tree | 2bb774dcaf3db88d6dafb8ab34322b5df4550ce0 /morphlib/definitions_repo.py | |
parent | 3c59628c80ffe47992bf7347268ca587fc6d368d (diff) | |
download | morph-b8b8de2b123ff96e6469196934359485bcd06b04.tar.gz |
Add support for Baserock definitions version 7
This adds a new 'Defaults' class to represent definitions defaults
The Python 'jsonschema' module is used to validate the contents of the
Defaults file. This module is already included in Baserock 'build' and
'devel' reference systems by way of the 'openstack-common' stratum.
This commit embeds a copy of the JSON-Schema schema for the DEFAULTS
file. I think the canonical location of this schema should be in the
reference definitions.git, for now. In future, the schemas should maybe
have their own repos. Either way, Morph should embed a copy for the time
being so that we are sure the schema matches how Morph expects to parse
the file.
Morph's automated tests are all updated to use definitions version 7.
I removed most of the tests for built-in build systems, because the
built-ins themselves are no longer part of Morph. Only the mechanism for
defining them needs to be tested now.
Change-Id: I65f8f1c967683ef605852bfae5c68518e53f9981
Diffstat (limited to 'morphlib/definitions_repo.py')
-rw-r--r-- | morphlib/definitions_repo.py | 21 |
1 files changed, 19 insertions, 2 deletions
diff --git a/morphlib/definitions_repo.py b/morphlib/definitions_repo.py index 301e5b86..6d14fcbb 100644 --- a/morphlib/definitions_repo.py +++ b/morphlib/definitions_repo.py @@ -23,6 +23,7 @@ import logging import os import urlparse import uuid +import warnings import morphlib import gitdir @@ -236,9 +237,25 @@ class DefinitionsRepo(gitdir.GitDirectory): mf = morphlib.morphologyfinder.MorphologyFinder(self) version_text = mf.read_file('VERSION') - morphlib.definitions_version.check_version_file(version_text) + version = morphlib.definitions_version.check_version_file(version_text) - loader = morphlib.morphloader.MorphologyLoader() + defaults_text = mf.read_file('DEFAULTS', allow_missing=True) + + if version < 7: + if defaults_text is not None: + warnings.warn( + "Ignoring DEFAULTS file, because these definitions are " + "version %i" % version) + defaults_text = None + else: + if defaults_text is None: + warnings.warn("No DEFAULTS file found.") + + defaults = morphlib.defaults.Defaults(version, + text=defaults_text) + + loader = morphlib.morphloader.MorphologyLoader( + predefined_build_systems=defaults.build_systems()) return loader |