Stop using bare except: statements

It is almost never a good idea to catch all exceptions, and then do
nothing about them. This patch logs all caught exceptions so that the
user has some possibilty to debug what is happening.

Also, make ./check check for bare excepts and fail the test suite if it
finds anything.

1 files changed, 5 insertions, 4 deletions

diff --git a/morphlib/cachedrepo_tests.py b/morphlib/cachedrepo_tests.py
index 9251a473..3e042b19 100644
--- a/morphlib/cachedrepo_tests.py
+++ b/morphlib/cachedrepo_tests.py
@@ -14,6 +14,7 @@
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
 
+import logging
 import os
 import unittest
 
@@ -42,7 +43,7 @@ class CachedRepoTests(unittest.TestCase):
         }
         try:
             return output[ref]
-        except:
+        except KeyError:
             raise cliapp.AppException('git rev-parse --verify %s' % ref)
 
     def show_tree_hash(self, absref):
@@ -56,7 +57,7 @@ class CachedRepoTests(unittest.TestCase):
         }
         try:
             return output[absref]
-        except:
+        except KeyError:
             raise cliapp.AppException('git log -1 --format=format:%%T %s' %
                                       absref)
 
@@ -67,7 +68,7 @@ class CachedRepoTests(unittest.TestCase):
         }
         try:
             return output['%s:%s' % (ref, filename)]
-        except:
+        except KeyError:
             raise cliapp.AppException(
                 'git cat-file blob %s:%s' % (ref, filename))
 
@@ -91,7 +92,7 @@ class CachedRepoTests(unittest.TestCase):
         }
         try:
             return output[ref]
-        except:
+        except KeyError:
             raise cliapp.AppException('git ls-tree --name-only %s' % (ref))
 
     def clone_into(self, target_dir, ref):