diff options
author | Sam Thursfield <sam.thursfield@codethink.co.uk> | 2015-02-18 11:23:56 +0000 |
---|---|---|
committer | Sam Thursfield <sam.thursfield@codethink.co.uk> | 2015-02-18 16:32:50 +0000 |
commit | 46a8e0de14ce2cca4c93ec53648d7e01333bbf65 (patch) | |
tree | a0bf88f196cbff5f181d98b801f3c41f98df4338 /distbuild/initiator_connection.py | |
parent | 51afd2289db20bcf5063ad9512ab1164154ff093 (diff) | |
download | morph-46a8e0de14ce2cca4c93ec53648d7e01333bbf65.tar.gz |
distbuild: Remove the build-steps message
This message was hundreds of kilobytes in size, as it contained a
recursive list of dependencies for each artifact in the build graph. It
was used in the initiator only to print this message:
Build steps in total: 592
This message is now gone. The 'Need to build %d artifacts'
build-progress message now indicates the total build steps instead:
Need to build 300 artifacts, of 592 total
This is a compatible change to the distbuild protocol: old initiators
will continue to work as normal with new controllers that don't send
the build-steps message.
Diffstat (limited to 'distbuild/initiator_connection.py')
-rw-r--r-- | distbuild/initiator_connection.py | 22 |
1 files changed, 0 insertions, 22 deletions
diff --git a/distbuild/initiator_connection.py b/distbuild/initiator_connection.py index 0db13a15..4cd13db3 100644 --- a/distbuild/initiator_connection.py +++ b/distbuild/initiator_connection.py @@ -77,8 +77,6 @@ class InitiatorConnection(distbuild.StateMachine): 'idle', self._send_build_failed_message), ('idle', distbuild.BuildController, distbuild.BuildProgress, 'idle', self._send_build_progress_message), - ('idle', distbuild.BuildController, distbuild.BuildSteps, - 'idle', self._send_build_steps_message), ('idle', distbuild.BuildController, distbuild.BuildStepStarted, 'idle', self._send_build_step_started_message), ('idle', distbuild.BuildController, @@ -164,26 +162,6 @@ class InitiatorConnection(distbuild.StateMachine): self.jm.send(msg) self._log_send(msg) - def _send_build_steps_message(self, event_source, event): - - def make_step_dict(artifact): - return { - 'name': distbuild.build_step_name(artifact), - 'build-depends': [ - distbuild.build_step_name(x) - for x in artifact.source.dependencies - ] - } - - if event.id in self.our_ids: - step_names = distbuild.map_build_graph( - event.artifact, make_step_dict) - msg = distbuild.message('build-steps', - id=self._route_map.get_incoming_id(event.id), - steps=step_names) - self.jm.send(msg) - self._log_send(msg) - def _send_build_step_started_message(self, event_source, event): logging.debug('InitiatorConnection: build_step_started: ' 'id=%s step_name=%s worker_name=%s' % |