Make builder get submodule cache repo path cleanly

3 files changed, 19 insertions, 13 deletions

diff --git a/morph b/morph
index 6a53645b..2f4c4d44 100755
--- a/morph
+++ b/morph
@@ -236,7 +236,7 @@ class Morph(cliapp.Application):
             staging_area = morphlib.stagingarea.StagingArea(staging_root,
                                                             staging_temp)
 
-            builder = morphlib.builder2.Builder(staging_area, lac,
+            builder = morphlib.builder2.Builder(staging_area, lac, lrc,
                                                 build_env,
                                                 self.settings['max-jobs'])
             for group in order.groups:
diff --git a/morphlib/builder2.py b/morphlib/builder2.py
index b5ef89e3..a27c35ab 100644
--- a/morphlib/builder2.py
+++ b/morphlib/builder2.py
@@ -27,11 +27,12 @@ class BuilderBase(object):
 
     '''Base class for building artifacts.'''
 
-    def __init__(self, staging_area, artifact_cache, artifact, build_env, 
-                 max_jobs):
+    def __init__(self, staging_area, artifact_cache, artifact, repo_cache,
+                 build_env, max_jobs):
         self.staging_area = staging_area
         self.artifact_cache = artifact_cache
         self.artifact = artifact
+        self.repo_cache = repo_cache
         self.build_env = build_env
         self.max_jobs = max_jobs
     
@@ -135,13 +136,12 @@ class ChunkBuilder(BuilderBase):
             except morphlib.git.NoModulesFileError:
                 return []
             else:
-                # FIXME: This is ugly, but the best I can do atm. We need
-                # to combine sub.path, which is a relative path, with the
-                # directory in the cache where the git repos are. --liw
-                return [(os.path.join(cache_dir, sub.path), 
-                         sub.commit, 
-                         os.path.join(destdir, sub.path))
-                        for sub in submodules]
+                tuples = []
+                for sub in submodules:
+                    cached_repo = self.repo_cache.get_repo(sub.repo)
+                    sub_dir = os.path.join(destdir, sub.path)
+                    tuples.append((cached_repo.path, sub.commit, sub_dir))
+                return tuples
 
         s = self.artifact.source
         todo = [(s.repo.path, s.sha1, srcdir)]
@@ -393,16 +393,19 @@ class Builder(object): # pragma: no cover
         'system': SystemBuilder,
     }
 
-    def __init__(self, staging_area, artifact_cache, build_env, max_jobs):
+    def __init__(self, staging_area, artifact_cache, repo_cache, build_env, 
+                 max_jobs):
         self.staging_area = staging_area
         self.artifact_cache = artifact_cache
+        self.repo_cache = repo_cache
         self.build_env = build_env
         self.max_jobs = max_jobs
         
     def build_and_cache(self, artifact):
         kind = artifact.source.morphology['kind']
         o = self.classes[kind](self.staging_area, self.artifact_cache, 
-                               artifact, self.build_env, self.max_jobs)
+                               artifact, self.repo_cache, self.build_env, 
+                               self.max_jobs)
         logging.debug('Builder.build: artifact %s with %s' %
                       (artifact.name, repr(o)))
         o.build_and_cache()
diff --git a/morphlib/builder2_tests.py b/morphlib/builder2_tests.py
index 44608c75..4f94d6c2 100644
--- a/morphlib/builder2_tests.py
+++ b/morphlib/builder2_tests.py
@@ -83,11 +83,13 @@ class BuilderBaseTests(unittest.TestCase):
         self.staging_area = FakeStagingArea(self.fake_runcmd)
         self.artifact_cache = None # Not used by tests
         self.artifact = FakeArtifact('le-artifact')
+        self.repo_cache = None
         self.build_env = FakeBuildEnv()
         self.max_jobs = 1
         self.builder = morphlib.builder2.BuilderBase(self.staging_area,
                                                      self.artifact_cache,
                                                      self.artifact,
+                                                     self.repo_cache,
                                                      self.build_env,
                                                      self.max_jobs)
 
@@ -134,7 +136,8 @@ class BuilderBaseTests(unittest.TestCase):
 class ChunkBuilderTests(unittest.TestCase):
 
     def setUp(self):
-        self.build = morphlib.builder2.ChunkBuilder(None, None, None, None, 1)
+        self.build = morphlib.builder2.ChunkBuilder(None, None, None, None, 
+                                                    None, 1)
 
     def test_uses_morphology_commands_when_given(self):
         m = { 'build-commands': ['build-it'] }