summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Thursfield <sam.thursfield@codethink.co.uk>2015-03-13 14:39:39 +0000
committerSam Thursfield <sam.thursfield@codethink.co.uk>2015-03-13 15:14:29 +0000
commit77901928199ff71a65e8bec83830051d52a4a5c4 (patch)
tree97be2eb1368e04326af210e3048581431624796a
parent89813b3df6df2c68cb09b301ac1cd70532daf251 (diff)
downloadinfrastructure-77901928199ff71a65e8bec83830051d52a4a5c4.tar.gz
gerrit: Disable 'Verified' label for now
Changes can't be merged that aren't +1 Verified. But we don't have Mason set up yet, so nothing can actually set things +1 Verified.
-rw-r--r--baserock_gerrit/All-Projects/groups8
-rw-r--r--baserock_gerrit/All-Projects/project.config14
2 files changed, 16 insertions, 6 deletions
diff --git a/baserock_gerrit/All-Projects/groups b/baserock_gerrit/All-Projects/groups
index f0d26cc9..da2baa74 100644
--- a/baserock_gerrit/All-Projects/groups
+++ b/baserock_gerrit/All-Projects/groups
@@ -6,3 +6,11 @@ global:Registered-Users Registered Users
# This file is filled in with the other group IDs by the
# gerrit-access-config.yml Ansible playbook.
+b660c33b68509db9dbd9578ae00035da90c0d5eb Administrators
+8e467a11f116bb716a65ac85e28bf09ebfeb0d63 Non-Interactive Users
+898d9c4232b8fcac6a3b128f7264c5d4c8b1eead Developers
+b8fc45c681b94669fe3fa965c48d5221a515a3a6 Mergers
+8c788c828285c3dd0a8c1cc152de6735085def9f Mirroring Tools
+a7a9cc6639bd943e47da0d20b39267a08b43cd91 Release Team
+d643abb0ad6e9d5ac33093af5cd3a3d4e484d95d Reviewers
+cea6c19a08e11b74e63a567e050bec2c6eeb14dc Testers
diff --git a/baserock_gerrit/All-Projects/project.config b/baserock_gerrit/All-Projects/project.config
index dfec0e61..0b16b280 100644
--- a/baserock_gerrit/All-Projects/project.config
+++ b/baserock_gerrit/All-Projects/project.config
@@ -45,7 +45,7 @@
label-Code-Review = -2..+2 group Mergers
submit = group Mergers
label-Code-Review = -1..+1 group Reviewers
- label-Verified = -1..+1 group Testers
+# label-Verified = -1..+1 group Testers
create = group Administrators
forgeCommitter = group Administrators
@@ -96,8 +96,10 @@
value = +1 Looks good to me, but someone else must approve
value = +2 Looks good to me, approved
-[label "Verified"]
- function = MaxWithBlock
- value = -1 Failed
- value = 0 No score
- value = +1 Verified
+# Disabled for now, because there is no automated test tool hooked up to our
+# Gerrit yet.
+#[label "Verified"]
+# function = MaxWithBlock
+# value = -1 Failed
+# value = 0 No score
+# value = +1 Verified