summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPaul Sherwood <paul.sherwood@codethink.co.uk>2014-04-20 15:40:50 +0000
committerPaul Sherwood <paul.sherwood@codethink.co.uk>2014-04-20 15:40:50 +0000
commita0e42d6be4e73d58f3568264a399cf6a39fc3e42 (patch)
tree8eec5e915b41c6d07b6cd5fdc8aab85c5f0fa9f6
parent8bb0d71ba1ada3c26b6bfa553c2ceb831c161818 (diff)
downloaddefinitions-a0e42d6be4e73d58f3568264a399cf6a39fc3e42.tar.gz
fix the Virtualbox version checking
-rwxr-xr-xvirtualbox-ssh.write4
1 files changed, 2 insertions, 2 deletions
diff --git a/virtualbox-ssh.write b/virtualbox-ssh.write
index 2a2f3f7b..b9d53579 100755
--- a/virtualbox-ssh.write
+++ b/virtualbox-ssh.write
@@ -116,7 +116,7 @@ class VirtualBoxPlusSshWriteExtension(morphlib.writeexts.WriteExtension):
# comparing against the major, minor and patch numbers directly
self.status(msg='Checking version of remote VirtualBox')
build_id = cliapp.ssh_runcmd(ssh_host, ['VBoxManage', '--version'])
- version_string = re.match(r"^([0-9\.])+.*$", build_id.strip()).group(1)
+ version_string = re.match(r"^([0-9\.]+).*$", build_id.strip()).group(1)
return tuple(int(s or '0') for s in version_string.split('.'))
def create_virtualbox_guest(self, ssh_host, vm_name, vdi_path, autostart):
@@ -130,7 +130,7 @@ class VirtualBoxPlusSshWriteExtension(morphlib.writeexts.WriteExtension):
hostonly_iface = self.get_host_interface(ssh_host)
- if self.virtualbox_version(ssh_host) < (4, 3):
+ if self.virtualbox_version(ssh_host) < (4, 3, 0):
sataportcount_option = '--sataportcount'
else:
sataportcount_option = '--portcount'